Trace terminal loop failures

src/bin/dosh-client.rs

@@ -486,7 +486,8 @@ async fn main() -> Result<()> {
                         detach_once(&socket, &cred, 2).await?;
                         return Ok(());
                     }
-                    return run_terminal(
+                    return trace_terminal_result(
+                        run_terminal(
                             socket,
                             cred,
                             Some(target_udp_addr),
@@ -501,7 +502,8 @@ async fn main() -> Result<()> {
                             false,
                             None,
                         )
-                    .await;
+                        .await,
+                    );
                 }
                 Err(err) => {
                     log_debug(
@@ -525,7 +527,8 @@ async fn main() -> Result<()> {
                         detach_once(&socket, &cred, 2).await?;
                         return Ok(());
                     }
-                    return run_terminal(
+                    return trace_terminal_result(
+                        run_terminal(
                             socket,
                             cred,
                             Some(target_udp_addr),
@@ -540,7 +543,8 @@ async fn main() -> Result<()> {
                             false,
                             None,
                         )
-                    .await;
+                        .await,
+                    );
                 }
                 Err(err) => {
                     log_debug(
@@ -601,7 +605,8 @@ async fn main() -> Result<()> {
                     detach_once(&socket, &cred, 2).await?;
                     return Ok(());
                 }
-                return run_terminal(
+                return trace_terminal_result(
+                    run_terminal(
                         socket,
                         cred,
                         Some(addr),
@@ -616,7 +621,8 @@ async fn main() -> Result<()> {
                         args.forward_only,
                         agent_sock,
                     )
-                .await;
+                    .await,
+                );
             }
             Err(err) if !forwarding_requested && auth_allows(&auth_preference, "ssh") => {
                 log_debug(
@@ -680,6 +686,7 @@ async fn main() -> Result<()> {
         detach_once(&socket, &cred, 2).await?;
         return Ok(());
     }
+    trace_terminal_result(
         run_terminal(
             socket,
             cred,
@@ -695,7 +702,8 @@ async fn main() -> Result<()> {
             false,
             None,
         )
-    .await
+        .await,
+    )
 }
 
 fn run_trust_command(config: &dosh::config::ClientConfig, args: &Args) -> Result<()> {
@@ -6495,6 +6503,13 @@ fn terminal_input_channel() -> (mpsc::Sender<Vec<u8>>, mpsc::Receiver<Vec<u8>>)
     mpsc::channel(STDIN_QUEUE_CAPACITY)
 }
 
+fn trace_terminal_result(result: Result<()>) -> Result<()> {
+    if let Err(err) = &result {
+        dosh::trace::event("client.terminal_error", &[("error", format!("{err:#}"))]);
+    }
+    result
+}
+
 #[allow(clippy::too_many_arguments)]
 async fn run_terminal(
     socket: UdpSocket,