Preserve OpenSSH alias config for hosts
ci / test (push) Has been cancelled
ci / fuzz-smoke (push) Has been cancelled
ci / windows-client (push) Has been cancelled
ci / package-release (linux-x86_64, ubuntu-latest) (push) Has been cancelled
ci / package-release (macos-aarch64, macos-14) (push) Has been cancelled
ci / package-release (macos-x86_64, macos-13) (push) Has been cancelled
ci / package-release (windows-x86_64, windows-latest) (push) Has been cancelled
ci / remote-bench (push) Has been cancelled
ci / test (push) Has been cancelled
ci / fuzz-smoke (push) Has been cancelled
ci / windows-client (push) Has been cancelled
ci / package-release (linux-x86_64, ubuntu-latest) (push) Has been cancelled
ci / package-release (macos-aarch64, macos-14) (push) Has been cancelled
ci / package-release (macos-x86_64, macos-13) (push) Has been cancelled
ci / package-release (windows-x86_64, windows-latest) (push) Has been cancelled
ci / remote-bench (push) Has been cancelled
This commit is contained in:
Generated
+1
-1
@@ -436,7 +436,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "dosh"
|
name = "dosh"
|
||||||
version = "1.0.0-rc19"
|
version = "1.0.0-rc20"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"base64",
|
"base64",
|
||||||
|
|||||||
+1
-1
@@ -1,6 +1,6 @@
|
|||||||
[package]
|
[package]
|
||||||
name = "dosh"
|
name = "dosh"
|
||||||
version = "1.0.0-rc19"
|
version = "1.0.0-rc20"
|
||||||
edition = "2024"
|
edition = "2024"
|
||||||
license = "MIT"
|
license = "MIT"
|
||||||
|
|
||||||
|
|||||||
@@ -98,6 +98,16 @@ cache_attach_tickets = true
|
|||||||
disconnect_status = true
|
disconnect_status = true
|
||||||
```
|
```
|
||||||
|
|
||||||
|
Example host entry:
|
||||||
|
|
||||||
|
```toml
|
||||||
|
[prod]
|
||||||
|
ssh = "prod"
|
||||||
|
ssh_config = "prod" # OpenSSH alias for IdentityFile, ProxyJump, SendEnv, etc.
|
||||||
|
dosh_host = "prod.example.com"
|
||||||
|
port = 50000
|
||||||
|
```
|
||||||
|
|
||||||
## Rust Library
|
## Rust Library
|
||||||
|
|
||||||
Dosh exposes a Rust transport for encrypted, reconnecting application streams.
|
Dosh exposes a Rust transport for encrypted, reconnecting application streams.
|
||||||
|
|||||||
+39
-28
@@ -302,8 +302,7 @@ async fn main() -> Result<()> {
|
|||||||
.get(&requested_server)
|
.get(&requested_server)
|
||||||
.cloned()
|
.cloned()
|
||||||
.unwrap_or_default();
|
.unwrap_or_default();
|
||||||
let raw_server = host.ssh.clone().unwrap_or_else(|| requested_server.clone());
|
let server = ssh_command_target(&requested_server, &host);
|
||||||
let server = ssh_with_user(&raw_server, host.user.as_deref());
|
|
||||||
let startup_command = resolved_startup_command(&args.command, &config, &host);
|
let startup_command = resolved_startup_command(&args.command, &config, &host);
|
||||||
let local_forwards = parse_local_forwards(&args.local_forward)?;
|
let local_forwards = parse_local_forwards(&args.local_forward)?;
|
||||||
let remote_forwards = parse_remote_forwards(&args.remote_forward)?;
|
let remote_forwards = parse_remote_forwards(&args.remote_forward)?;
|
||||||
@@ -655,8 +654,7 @@ fn run_trust_command(config: &dosh::config::ClientConfig, args: &Args) -> Result
|
|||||||
|
|
||||||
let hosts = load_hosts_config(None).unwrap_or_default();
|
let hosts = load_hosts_config(None).unwrap_or_default();
|
||||||
let host_config = hosts.hosts.get(host).cloned().unwrap_or_default();
|
let host_config = hosts.hosts.get(host).cloned().unwrap_or_default();
|
||||||
let raw_server = host_config.ssh.clone().unwrap_or_else(|| host.to_string());
|
let server = ssh_command_target(host, &host_config);
|
||||||
let server = ssh_with_user(&raw_server, host_config.user.as_deref());
|
|
||||||
let ssh_port = args.ssh_port.or(host_config.ssh_port).or(config.ssh_port);
|
let ssh_port = args.ssh_port.or(host_config.ssh_port).or(config.ssh_port);
|
||||||
let ssh_auth_command = args
|
let ssh_auth_command = args
|
||||||
.ssh_auth_command
|
.ssh_auth_command
|
||||||
@@ -701,8 +699,8 @@ async fn run_setup_command(config: &dosh::config::ClientConfig, args: &Args) ->
|
|||||||
for entry in imported {
|
for entry in imported {
|
||||||
match entry.action {
|
match entry.action {
|
||||||
ImportAction::Added => println!(
|
ImportAction::Added => println!(
|
||||||
"[ok] host config: [{}] ssh={} dosh_host={} port={}",
|
"[ok] host config: [{}] ssh={} ssh_config={} dosh_host={} port={}",
|
||||||
entry.alias, entry.ssh, entry.dosh_host, entry.port
|
entry.alias, entry.ssh, entry.ssh_config, entry.dosh_host, entry.port
|
||||||
),
|
),
|
||||||
ImportAction::Skipped => println!("[ok] host config: [{}] already exists", entry.alias),
|
ImportAction::Skipped => println!("[ok] host config: [{}] already exists", entry.alias),
|
||||||
}
|
}
|
||||||
@@ -710,8 +708,7 @@ async fn run_setup_command(config: &dosh::config::ClientConfig, args: &Args) ->
|
|||||||
|
|
||||||
let hosts = load_hosts_config(None).unwrap_or_default();
|
let hosts = load_hosts_config(None).unwrap_or_default();
|
||||||
let host_config = hosts.hosts.get(&host).cloned().unwrap_or_default();
|
let host_config = hosts.hosts.get(&host).cloned().unwrap_or_default();
|
||||||
let raw_server = host_config.ssh.clone().unwrap_or_else(|| host.clone());
|
let server = ssh_command_target(&host, &host_config);
|
||||||
let server = ssh_with_user(&raw_server, host_config.user.as_deref());
|
|
||||||
let ssh_port = args.ssh_port.or(host_config.ssh_port).or(config.ssh_port);
|
let ssh_port = args.ssh_port.or(host_config.ssh_port).or(config.ssh_port);
|
||||||
let ssh_auth_command = args
|
let ssh_auth_command = args
|
||||||
.ssh_auth_command
|
.ssh_auth_command
|
||||||
@@ -843,9 +840,15 @@ fn run_restart_command(config: &dosh::config::ClientConfig, args: &Args) -> Resu
|
|||||||
}
|
}
|
||||||
|
|
||||||
fn status_ssh_target(requested: &str, host_config: &dosh::config::HostConfig) -> String {
|
fn status_ssh_target(requested: &str, host_config: &dosh::config::HostConfig) -> String {
|
||||||
|
ssh_command_target(requested, host_config)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn ssh_command_target(requested: &str, host_config: &dosh::config::HostConfig) -> String {
|
||||||
let raw_server = host_config
|
let raw_server = host_config
|
||||||
.ssh
|
.ssh_config
|
||||||
.clone()
|
.as_ref()
|
||||||
|
.or(host_config.ssh.as_ref())
|
||||||
|
.cloned()
|
||||||
.unwrap_or_else(|| requested.to_string());
|
.unwrap_or_else(|| requested.to_string());
|
||||||
ssh_with_user(&raw_server, host_config.user.as_deref())
|
ssh_with_user(&raw_server, host_config.user.as_deref())
|
||||||
}
|
}
|
||||||
@@ -882,11 +885,7 @@ async fn run_doctor_for_host(
|
|||||||
) -> Result<()> {
|
) -> Result<()> {
|
||||||
let hosts = load_hosts_config(None).unwrap_or_default();
|
let hosts = load_hosts_config(None).unwrap_or_default();
|
||||||
let host_config = hosts.hosts.get(requested).cloned().unwrap_or_default();
|
let host_config = hosts.hosts.get(requested).cloned().unwrap_or_default();
|
||||||
let raw_server = host_config
|
let server = ssh_command_target(requested, &host_config);
|
||||||
.ssh
|
|
||||||
.clone()
|
|
||||||
.unwrap_or_else(|| requested.to_string());
|
|
||||||
let server = ssh_with_user(&raw_server, host_config.user.as_deref());
|
|
||||||
let ssh_port = args.ssh_port.or(host_config.ssh_port).or(config.ssh_port);
|
let ssh_port = args.ssh_port.or(host_config.ssh_port).or(config.ssh_port);
|
||||||
let dosh_port = args
|
let dosh_port = args
|
||||||
.dosh_port
|
.dosh_port
|
||||||
@@ -1393,8 +1392,7 @@ async fn run_proxy_stdio_command(config: &dosh::config::ClientConfig, args: &Arg
|
|||||||
.get(&requested_server)
|
.get(&requested_server)
|
||||||
.cloned()
|
.cloned()
|
||||||
.unwrap_or_default();
|
.unwrap_or_default();
|
||||||
let raw_server = host.ssh.clone().unwrap_or_else(|| requested_server.clone());
|
let server = ssh_command_target(&requested_server, &host);
|
||||||
let server = ssh_with_user(&raw_server, host.user.as_deref());
|
|
||||||
let ssh_port = args.ssh_port.or(host.ssh_port).or(config.ssh_port);
|
let ssh_port = args.ssh_port.or(host.ssh_port).or(config.ssh_port);
|
||||||
let resolved_ssh_config = ssh_config(&server, ssh_port).unwrap_or_default();
|
let resolved_ssh_config = ssh_config(&server, ssh_port).unwrap_or_default();
|
||||||
let requested_udp_host = args
|
let requested_udp_host = args
|
||||||
@@ -1561,11 +1559,7 @@ fn ensure_vscode_ssh_host(
|
|||||||
) -> Result<GeneratedVscodeHost> {
|
) -> Result<GeneratedVscodeHost> {
|
||||||
let hosts = load_hosts_config(None).unwrap_or_default();
|
let hosts = load_hosts_config(None).unwrap_or_default();
|
||||||
let host_config = hosts.hosts.get(requested).cloned().unwrap_or_default();
|
let host_config = hosts.hosts.get(requested).cloned().unwrap_or_default();
|
||||||
let raw_server = host_config
|
let server = ssh_command_target(requested, &host_config);
|
||||||
.ssh
|
|
||||||
.clone()
|
|
||||||
.unwrap_or_else(|| requested.to_string());
|
|
||||||
let server = ssh_with_user(&raw_server, host_config.user.as_deref());
|
|
||||||
let ssh_port = args.ssh_port.or(host_config.ssh_port).or(config.ssh_port);
|
let ssh_port = args.ssh_port.or(host_config.ssh_port).or(config.ssh_port);
|
||||||
let ssh_config = ssh_config(&server, ssh_port).unwrap_or_default();
|
let ssh_config = ssh_config(&server, ssh_port).unwrap_or_default();
|
||||||
let target_ssh_port = ssh_config.port.or(ssh_port).unwrap_or(22);
|
let target_ssh_port = ssh_config.port.or(ssh_port).unwrap_or(22);
|
||||||
@@ -3247,6 +3241,7 @@ enum ImportAction {
|
|||||||
struct ImportedHost {
|
struct ImportedHost {
|
||||||
alias: String,
|
alias: String,
|
||||||
ssh: String,
|
ssh: String,
|
||||||
|
ssh_config: String,
|
||||||
dosh_host: String,
|
dosh_host: String,
|
||||||
port: u16,
|
port: u16,
|
||||||
action: ImportAction,
|
action: ImportAction,
|
||||||
@@ -3260,8 +3255,8 @@ fn run_import_ssh(config: &dosh::config::ClientConfig, aliases: &[String]) -> Re
|
|||||||
for entry in imported {
|
for entry in imported {
|
||||||
match entry.action {
|
match entry.action {
|
||||||
ImportAction::Added => eprintln!(
|
ImportAction::Added => eprintln!(
|
||||||
"dosh import-ssh: added [{}] ssh={} dosh_host={}",
|
"dosh import-ssh: added [{}] ssh={} ssh_config={} dosh_host={}",
|
||||||
entry.alias, entry.ssh, entry.dosh_host
|
entry.alias, entry.ssh, entry.ssh_config, entry.dosh_host
|
||||||
),
|
),
|
||||||
ImportAction::Skipped => {
|
ImportAction::Skipped => {
|
||||||
eprintln!(
|
eprintln!(
|
||||||
@@ -3303,6 +3298,7 @@ fn import_ssh_aliases(
|
|||||||
imported.push(ImportedHost {
|
imported.push(ImportedHost {
|
||||||
alias: alias.clone(),
|
alias: alias.clone(),
|
||||||
ssh: alias.clone(),
|
ssh: alias.clone(),
|
||||||
|
ssh_config: alias.clone(),
|
||||||
dosh_host: udp_host,
|
dosh_host: udp_host,
|
||||||
port: config.dosh_port,
|
port: config.dosh_port,
|
||||||
action: ImportAction::Skipped,
|
action: ImportAction::Skipped,
|
||||||
@@ -3312,6 +3308,7 @@ fn import_ssh_aliases(
|
|||||||
raw.push('\n');
|
raw.push('\n');
|
||||||
raw.push_str(&format!("[{}]\n", toml_bare_key_or_quoted(alias)));
|
raw.push_str(&format!("[{}]\n", toml_bare_key_or_quoted(alias)));
|
||||||
raw.push_str(&format!("ssh = {}\n", toml_string(alias)));
|
raw.push_str(&format!("ssh = {}\n", toml_string(alias)));
|
||||||
|
raw.push_str(&format!("ssh_config = {}\n", toml_string(alias)));
|
||||||
raw.push_str(&format!("dosh_host = {}\n", toml_string(&udp_host)));
|
raw.push_str(&format!("dosh_host = {}\n", toml_string(&udp_host)));
|
||||||
raw.push_str(&format!("port = {}\n", config.dosh_port));
|
raw.push_str(&format!("port = {}\n", config.dosh_port));
|
||||||
if let Some(user) = &ssh_config.user {
|
if let Some(user) = &ssh_config.user {
|
||||||
@@ -3326,6 +3323,7 @@ fn import_ssh_aliases(
|
|||||||
imported.push(ImportedHost {
|
imported.push(ImportedHost {
|
||||||
alias: alias.clone(),
|
alias: alias.clone(),
|
||||||
ssh: alias.clone(),
|
ssh: alias.clone(),
|
||||||
|
ssh_config: alias.clone(),
|
||||||
dosh_host: udp_host,
|
dosh_host: udp_host,
|
||||||
port: config.dosh_port,
|
port: config.dosh_port,
|
||||||
action: ImportAction::Added,
|
action: ImportAction::Added,
|
||||||
@@ -7773,10 +7771,10 @@ mod tests {
|
|||||||
server_version_mismatch, should_flush_terminal_input_after_contact,
|
server_version_mismatch, should_flush_terminal_input_after_contact,
|
||||||
should_hold_during_startup_gate, should_hold_post_submit_input,
|
should_hold_during_startup_gate, should_hold_post_submit_input,
|
||||||
should_repaint_idle_alternate_screen, split_after_command_submit, ssh_destination_host,
|
should_repaint_idle_alternate_screen, split_after_command_submit, ssh_destination_host,
|
||||||
ssh_username, ssh_with_user, startup_command, status_ssh_target, strip_stale_mouse_reports,
|
ssh_username, ssh_with_user, ssh_command_target, startup_command, status_ssh_target,
|
||||||
strip_terminal_focus_reports, terminal_private_mode_transition, toml_bare_key_or_quoted,
|
strip_stale_mouse_reports, strip_terminal_focus_reports, terminal_private_mode_transition,
|
||||||
unix_update_script, update_installer_url, update_version_status, upsert_managed_block,
|
toml_bare_key_or_quoted, unix_update_script, update_installer_url, update_version_status,
|
||||||
valid_forward_host, vscode_safe_alias, windows_update_script,
|
upsert_managed_block, valid_forward_host, vscode_safe_alias, windows_update_script,
|
||||||
};
|
};
|
||||||
use dosh::config::{ClientConfig, CommandExtension, HostConfig};
|
use dosh::config::{ClientConfig, CommandExtension, HostConfig};
|
||||||
use dosh::native::EnvVar;
|
use dosh::native::EnvVar;
|
||||||
@@ -9017,6 +9015,19 @@ mod tests {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn ssh_command_target_prefers_explicit_ssh_config_alias() {
|
||||||
|
let host = HostConfig {
|
||||||
|
ssh: Some("server.example.com".to_string()),
|
||||||
|
ssh_config: Some("work-alias".to_string()),
|
||||||
|
user: Some("alice".to_string()),
|
||||||
|
..HostConfig::default()
|
||||||
|
};
|
||||||
|
|
||||||
|
assert_eq!(ssh_command_target("work", &host), "alice@work-alias");
|
||||||
|
assert_eq!(status_ssh_target("work", &host), "alice@work-alias");
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn status_detects_local_targets() {
|
fn status_detects_local_targets() {
|
||||||
assert!(is_local_status_target("localhost"));
|
assert!(is_local_status_target("localhost"));
|
||||||
|
|||||||
@@ -150,6 +150,12 @@ pub struct ClientConfig {
|
|||||||
#[derive(Debug, Clone, Default, Serialize, Deserialize)]
|
#[derive(Debug, Clone, Default, Serialize, Deserialize)]
|
||||||
pub struct HostConfig {
|
pub struct HostConfig {
|
||||||
pub ssh: Option<String>,
|
pub ssh: Option<String>,
|
||||||
|
/// Optional OpenSSH config host name to use for SSH-backed bootstrap,
|
||||||
|
/// trust/setup/doctor checks, and native-auth identity selection. This lets
|
||||||
|
/// a Dosh host keep a separate UDP endpoint while still inheriting
|
||||||
|
/// alias-scoped OpenSSH settings like IdentityFile, ProxyJump, and SendEnv.
|
||||||
|
#[serde(default)]
|
||||||
|
pub ssh_config: Option<String>,
|
||||||
pub user: Option<String>,
|
pub user: Option<String>,
|
||||||
pub dosh_host: Option<String>,
|
pub dosh_host: Option<String>,
|
||||||
pub port: Option<u16>,
|
pub port: Option<u16>,
|
||||||
|
|||||||
Reference in New Issue
Block a user