Compare commits
15
Commits
v0.1.12
...
v1.0.0-rc4
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
b90c34dc17 | ||
|
|
f205e0c128 | ||
|
|
92c94176bd | ||
|
|
4b2e9a62d5 | ||
|
|
689d20f7e7 | ||
|
|
252f081a61 | ||
|
|
b1e8326b0a | ||
|
|
3b4931aa8f | ||
|
|
5c54601cdf | ||
|
|
c085137250 | ||
|
|
237ad52bef | ||
|
|
a8ba852f16 | ||
|
|
f1a3de7730 | ||
|
|
80699dcf9d | ||
|
|
274c0f505e |
Generated
+1
-1
@@ -436,7 +436,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "dosh"
|
name = "dosh"
|
||||||
version = "0.1.12"
|
version = "1.0.0-rc4"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"base64",
|
"base64",
|
||||||
|
|||||||
+1
-1
@@ -1,6 +1,6 @@
|
|||||||
[package]
|
[package]
|
||||||
name = "dosh"
|
name = "dosh"
|
||||||
version = "0.1.12"
|
version = "1.0.0-rc4"
|
||||||
edition = "2024"
|
edition = "2024"
|
||||||
license = "MIT"
|
license = "MIT"
|
||||||
|
|
||||||
|
|||||||
@@ -1,4 +1,4 @@
|
|||||||
.PHONY: build test fmt clippy release-check install package-release package-release-linux package-release-windows publish-release bench-report bench-local bench-local-json bench-docker-ssh bench-docker-mosh fuzz-smoke fuzz-deep soak-local tui-harness
|
.PHONY: build test fmt clippy release-check 1.0-check reconnect-check hostile-network-check persistence-check package-check install package-release package-release-linux package-release-windows publish-release bench-report bench-local bench-local-json bench-docker-ssh bench-docker-mosh fuzz-smoke fuzz-deep soak-local tui-harness
|
||||||
|
|
||||||
build:
|
build:
|
||||||
cargo build --release
|
cargo build --release
|
||||||
@@ -19,6 +19,25 @@ release-check:
|
|||||||
cargo test
|
cargo test
|
||||||
$(MAKE) tui-harness
|
$(MAKE) tui-harness
|
||||||
|
|
||||||
|
1.0-check: release-check reconnect-check hostile-network-check persistence-check package-check
|
||||||
|
|
||||||
|
reconnect-check:
|
||||||
|
cargo test --test integration_smoke resume_updates_udp_endpoint_for_roaming -- --nocapture
|
||||||
|
DOSH_SOAK_SECONDS=$${DOSH_SOAK_SECONDS:-300} cargo test --test integration_smoke sleep_roaming_soak_30m -- --ignored --nocapture
|
||||||
|
|
||||||
|
hostile-network-check:
|
||||||
|
cargo test --test hostile_network -- --nocapture
|
||||||
|
DOSH_BADNET_SOAK_SECONDS=$${DOSH_BADNET_SOAK_SECONDS:-300} cargo test --test hostile_network bad_network_tui_work_soak_30m -- --ignored --nocapture
|
||||||
|
|
||||||
|
persistence-check:
|
||||||
|
cargo test --test integration_smoke session_survives_server_restart_same_shell_and_screen -- --nocapture
|
||||||
|
cargo test --test integration_smoke multiple_persistent_named_sessions_survive_restart_independently -- --nocapture
|
||||||
|
|
||||||
|
package-check:
|
||||||
|
$(MAKE) package-release-linux
|
||||||
|
$(MAKE) package-release-windows
|
||||||
|
sh scripts/verify-release-artifacts.sh
|
||||||
|
|
||||||
install:
|
install:
|
||||||
sh install.sh --from-current
|
sh install.sh --from-current
|
||||||
|
|
||||||
|
|||||||
+1
-10
@@ -426,18 +426,9 @@ Wants=network-online.target
|
|||||||
[Service]
|
[Service]
|
||||||
Type=simple
|
Type=simple
|
||||||
ExecStart=$bindir/dosh-server serve
|
ExecStart=$bindir/dosh-server serve
|
||||||
Restart=on-failure
|
Restart=always
|
||||||
RestartSec=1
|
RestartSec=1
|
||||||
KillMode=process
|
KillMode=process
|
||||||
NoNewPrivileges=true
|
|
||||||
PrivateTmp=true
|
|
||||||
ProtectSystem=strict
|
|
||||||
ProtectHome=read-only
|
|
||||||
ReadWritePaths=$config_dir $data_dir
|
|
||||||
RestrictAddressFamilies=AF_INET AF_INET6 AF_UNIX AF_NETLINK
|
|
||||||
RestrictRealtime=true
|
|
||||||
LockPersonality=true
|
|
||||||
MemoryDenyWriteExecute=true
|
|
||||||
|
|
||||||
[Install]
|
[Install]
|
||||||
WantedBy=default.target
|
WantedBy=default.target
|
||||||
|
|||||||
@@ -6,18 +6,9 @@ Wants=network-online.target
|
|||||||
[Service]
|
[Service]
|
||||||
Type=simple
|
Type=simple
|
||||||
ExecStart=%h/.local/bin/dosh-server serve
|
ExecStart=%h/.local/bin/dosh-server serve
|
||||||
Restart=on-failure
|
Restart=always
|
||||||
RestartSec=1
|
RestartSec=1
|
||||||
KillMode=process
|
KillMode=process
|
||||||
NoNewPrivileges=true
|
|
||||||
PrivateTmp=true
|
|
||||||
ProtectSystem=strict
|
|
||||||
ProtectHome=read-only
|
|
||||||
ReadWritePaths=%h/.config/dosh %h/.local/share/dosh
|
|
||||||
RestrictAddressFamilies=AF_INET AF_INET6 AF_UNIX AF_NETLINK
|
|
||||||
RestrictRealtime=true
|
|
||||||
LockPersonality=true
|
|
||||||
MemoryDenyWriteExecute=true
|
|
||||||
|
|
||||||
[Install]
|
[Install]
|
||||||
WantedBy=default.target
|
WantedBy=default.target
|
||||||
|
|||||||
@@ -67,6 +67,7 @@ cleanup() {
|
|||||||
kill "$server_pid" 2>/dev/null || true
|
kill "$server_pid" 2>/dev/null || true
|
||||||
wait "$server_pid" 2>/dev/null || true
|
wait "$server_pid" 2>/dev/null || true
|
||||||
fi
|
fi
|
||||||
|
pkill -f "$server_bin hold --runtime-dir $home/sessions/run" 2>/dev/null || true
|
||||||
rm -rf "$home"
|
rm -rf "$home"
|
||||||
}
|
}
|
||||||
trap cleanup EXIT INT TERM
|
trap cleanup EXIT INT TERM
|
||||||
@@ -86,6 +87,7 @@ scrollback = 5000
|
|||||||
auth_ttl_secs = 30
|
auth_ttl_secs = 30
|
||||||
attach_ticket_ttl_secs = 3600
|
attach_ticket_ttl_secs = 3600
|
||||||
allow_attach_tickets = true
|
allow_attach_tickets = true
|
||||||
|
persist_sessions = false
|
||||||
client_timeout_secs = 60
|
client_timeout_secs = 60
|
||||||
retransmit_window = 256
|
retransmit_window = 256
|
||||||
default_input_mode = "read-write"
|
default_input_mode = "read-write"
|
||||||
|
|||||||
@@ -0,0 +1,46 @@
|
|||||||
|
#!/usr/bin/env sh
|
||||||
|
set -eu
|
||||||
|
|
||||||
|
repo_root="$(CDPATH= cd -- "$(dirname -- "$0")/.." && pwd)"
|
||||||
|
cd "$repo_root"
|
||||||
|
|
||||||
|
version="$(sed -n 's/^version = "\(.*\)"/\1/p' Cargo.toml | sed -n '1p')"
|
||||||
|
out_dir="${DOSH_PACKAGE_DIR:-target/dosh-release}"
|
||||||
|
|
||||||
|
artifact_version() {
|
||||||
|
artifact="$1"
|
||||||
|
case "$artifact" in
|
||||||
|
*.tar.gz)
|
||||||
|
tar -xOf "$artifact" dosh/VERSION 2>/dev/null | tr -d '\r\n'
|
||||||
|
;;
|
||||||
|
*.zip)
|
||||||
|
unzip -p "$artifact" dosh/VERSION 2>/dev/null | tr -d '\r\n'
|
||||||
|
;;
|
||||||
|
*)
|
||||||
|
return 1
|
||||||
|
;;
|
||||||
|
esac
|
||||||
|
}
|
||||||
|
|
||||||
|
failed=0
|
||||||
|
for artifact in \
|
||||||
|
"$out_dir/dosh-linux-x86_64.tar.gz" \
|
||||||
|
"$out_dir/dosh-macos-aarch64.tar.gz" \
|
||||||
|
"$out_dir/dosh-windows-x86_64.zip"; do
|
||||||
|
if [ ! -f "$artifact" ]; then
|
||||||
|
echo "missing release artifact: $artifact" >&2
|
||||||
|
failed=1
|
||||||
|
continue
|
||||||
|
fi
|
||||||
|
if [ ! -f "$artifact.sha256" ]; then
|
||||||
|
echo "missing release checksum: $artifact.sha256" >&2
|
||||||
|
failed=1
|
||||||
|
fi
|
||||||
|
actual="$(artifact_version "$artifact" || true)"
|
||||||
|
if [ "$actual" != "$version" ]; then
|
||||||
|
echo "artifact version mismatch: $artifact has ${actual:-unknown}, expected $version" >&2
|
||||||
|
failed=1
|
||||||
|
fi
|
||||||
|
done
|
||||||
|
|
||||||
|
exit "$failed"
|
||||||
+313
-40
@@ -36,6 +36,7 @@ use dosh::transport::{
|
|||||||
DoshTransport, SessionEvent, SessionRole, SessionTransportConfig, TransportConfig,
|
DoshTransport, SessionEvent, SessionRole, SessionTransportConfig, TransportConfig,
|
||||||
TransportEvent,
|
TransportEvent,
|
||||||
};
|
};
|
||||||
|
use dosh::udp::is_transient_udp_send_error;
|
||||||
use serde::{Deserialize, Serialize};
|
use serde::{Deserialize, Serialize};
|
||||||
use sha2::{Digest, Sha256};
|
use sha2::{Digest, Sha256};
|
||||||
use std::collections::BTreeMap;
|
use std::collections::BTreeMap;
|
||||||
@@ -63,6 +64,8 @@ const STREAM_INITIAL_WINDOW: usize = 1024 * 1024;
|
|||||||
const MAX_PENDING_USER_INPUT_BYTES: usize = 1024 * 1024;
|
const MAX_PENDING_USER_INPUT_BYTES: usize = 1024 * 1024;
|
||||||
const STARTUP_INPUT_HOLD: Duration = Duration::from_millis(750);
|
const STARTUP_INPUT_HOLD: Duration = Duration::from_millis(750);
|
||||||
const POST_SUBMIT_ALL_INPUT_HOLD: Duration = Duration::from_millis(120);
|
const POST_SUBMIT_ALL_INPUT_HOLD: Duration = Duration::from_millis(120);
|
||||||
|
const STALE_TERMINAL_INPUT_AFTER: Duration = Duration::from_secs(2);
|
||||||
|
const POST_RECONNECT_STALE_INPUT_GRACE: Duration = Duration::from_secs(2);
|
||||||
|
|
||||||
/// Sentinel `target_host` the server uses on a server-initiated `StreamOpen` that
|
/// Sentinel `target_host` the server uses on a server-initiated `StreamOpen` that
|
||||||
/// represents an SSH-agent connection (rather than a TCP target). The client
|
/// represents an SSH-agent connection (rather than a TCP target). The client
|
||||||
@@ -3524,6 +3527,14 @@ fn resolve_addr(host: &str, port: u16) -> Result<SocketAddr> {
|
|||||||
.ok_or_else(|| anyhow!("no UDP address resolved for {host}:{port}"))
|
.ok_or_else(|| anyhow!("no UDP address resolved for {host}:{port}"))
|
||||||
}
|
}
|
||||||
|
|
||||||
|
async fn send_terminal_udp(socket: &UdpSocket, packet: &[u8], addr: SocketAddr) -> Result<bool> {
|
||||||
|
match socket.send_to(packet, addr).await {
|
||||||
|
Ok(_) => Ok(true),
|
||||||
|
Err(err) if is_transient_udp_send_error(&err) => Ok(false),
|
||||||
|
Err(err) => Err(err).with_context(|| format!("send UDP packet to {addr}")),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
#[allow(clippy::too_many_arguments)]
|
#[allow(clippy::too_many_arguments)]
|
||||||
async fn try_native_auth(
|
async fn try_native_auth(
|
||||||
socket: &UdpSocket,
|
socket: &UdpSocket,
|
||||||
@@ -4271,7 +4282,7 @@ async fn run_terminal(
|
|||||||
let mut status_tick = tokio::time::interval(Duration::from_secs(1));
|
let mut status_tick = tokio::time::interval(Duration::from_secs(1));
|
||||||
let mut resize_tick = tokio::time::interval(Duration::from_millis(250));
|
let mut resize_tick = tokio::time::interval(Duration::from_millis(250));
|
||||||
let mut stream_retransmit_tick = tokio::time::interval(Duration::from_millis(200));
|
let mut stream_retransmit_tick = tokio::time::interval(Duration::from_millis(200));
|
||||||
let mut frame_gap_tick = tokio::time::interval(Duration::from_millis(100));
|
let mut frame_gap_tick = tokio::time::interval(Duration::from_millis(250));
|
||||||
let mut last_size = terminal_size();
|
let mut last_size = terminal_size();
|
||||||
// React to terminal resize the instant it happens via SIGWINCH (mosh-style),
|
// React to terminal resize the instant it happens via SIGWINCH (mosh-style),
|
||||||
// instead of waiting up to one `resize_tick`. The 250ms poll below stays as a
|
// instead of waiting up to one `resize_tick`. The 250ms poll below stays as a
|
||||||
@@ -4322,6 +4333,7 @@ async fn run_terminal(
|
|||||||
let mut pending_user_input_bytes = 0usize;
|
let mut pending_user_input_bytes = 0usize;
|
||||||
let mut startup_input_hold_until: Option<Instant> = None;
|
let mut startup_input_hold_until: Option<Instant> = None;
|
||||||
let mut startup_gate_mode = StartupGateMode::HoldControl;
|
let mut startup_gate_mode = StartupGateMode::HoldControl;
|
||||||
|
let mut stale_terminal_input_suppress_until: Option<Instant> = None;
|
||||||
if let Some(frame) = first_frame {
|
if let Some(frame) = first_frame {
|
||||||
if !forward_only {
|
if !forward_only {
|
||||||
render_frame(&frame)?;
|
render_frame(&frame)?;
|
||||||
@@ -4337,7 +4349,13 @@ async fn run_terminal(
|
|||||||
&& cred.mode != "view-only"
|
&& cred.mode != "view-only"
|
||||||
&& !forward_only
|
&& !forward_only
|
||||||
{
|
{
|
||||||
send_input(&socket, addr, &cred, &mut send_seq, bytes).await?;
|
if !send_input(&socket, addr, &cred, &mut send_seq, bytes.clone()).await? {
|
||||||
|
queue_stale_pending_user_input(
|
||||||
|
&mut pending_user_input,
|
||||||
|
&mut pending_user_input_bytes,
|
||||||
|
bytes,
|
||||||
|
)?;
|
||||||
|
}
|
||||||
startup_input_hold_until = Some(Instant::now() + STARTUP_INPUT_HOLD);
|
startup_input_hold_until = Some(Instant::now() + STARTUP_INPUT_HOLD);
|
||||||
startup_gate_mode = StartupGateMode::HoldAll;
|
startup_gate_mode = StartupGateMode::HoldAll;
|
||||||
}
|
}
|
||||||
@@ -4373,10 +4391,19 @@ async fn run_terminal(
|
|||||||
biased;
|
biased;
|
||||||
stdin_msg = stdin_rx.recv() => {
|
stdin_msg = stdin_rx.recv() => {
|
||||||
match stdin_msg {
|
match stdin_msg {
|
||||||
Some(bytes) => {
|
Some(mut bytes) => {
|
||||||
if input_matches_escape(&bytes, escape_key.as_deref()) {
|
if input_matches_escape(&bytes, escape_key.as_deref()) {
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
if should_strip_stale_terminal_reports(
|
||||||
|
last_packet_at.elapsed(),
|
||||||
|
stale_terminal_input_suppress_until,
|
||||||
|
) {
|
||||||
|
bytes = strip_stale_mouse_reports(&bytes);
|
||||||
|
if bytes.is_empty() {
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
}
|
||||||
if cred.mode != "view-only" && cred.mode != "forward-only" {
|
if cred.mode != "view-only" && cred.mode != "forward-only" {
|
||||||
if let Some(deadline) = startup_input_hold_until {
|
if let Some(deadline) = startup_input_hold_until {
|
||||||
if !predictor.alternate_screen
|
if !predictor.alternate_screen
|
||||||
@@ -4411,8 +4438,15 @@ async fn run_terminal(
|
|||||||
&& let Some((send_now, mut hold_for_later)) =
|
&& let Some((send_now, mut hold_for_later)) =
|
||||||
split_after_command_submit(&bytes)
|
split_after_command_submit(&bytes)
|
||||||
{
|
{
|
||||||
predictor.observe_input(&send_now)?;
|
if send_input(&socket, addr, &cred, &mut send_seq, send_now.clone()).await? {
|
||||||
send_input(&socket, addr, &cred, &mut send_seq, send_now).await?;
|
predictor.observe_input(&send_now)?;
|
||||||
|
} else {
|
||||||
|
queue_stale_pending_user_input(
|
||||||
|
&mut pending_user_input,
|
||||||
|
&mut pending_user_input_bytes,
|
||||||
|
send_now,
|
||||||
|
)?;
|
||||||
|
}
|
||||||
startup_input_hold_until = Some(
|
startup_input_hold_until = Some(
|
||||||
Instant::now()
|
Instant::now()
|
||||||
+ post_submit_hold_duration(&hold_for_later),
|
+ post_submit_hold_duration(&hold_for_later),
|
||||||
@@ -4431,15 +4465,23 @@ async fn run_terminal(
|
|||||||
)?;
|
)?;
|
||||||
continue;
|
continue;
|
||||||
} else if !hold_for_later.is_empty() {
|
} else if !hold_for_later.is_empty() {
|
||||||
predictor.observe_input(&hold_for_later)?;
|
let sent = send_input(
|
||||||
send_input(
|
|
||||||
&socket,
|
&socket,
|
||||||
addr,
|
addr,
|
||||||
&cred,
|
&cred,
|
||||||
&mut send_seq,
|
&mut send_seq,
|
||||||
std::mem::take(&mut hold_for_later),
|
hold_for_later.clone(),
|
||||||
)
|
)
|
||||||
.await?;
|
.await?;
|
||||||
|
if sent {
|
||||||
|
predictor.observe_input(&hold_for_later)?;
|
||||||
|
} else {
|
||||||
|
queue_stale_pending_user_input(
|
||||||
|
&mut pending_user_input,
|
||||||
|
&mut pending_user_input_bytes,
|
||||||
|
std::mem::take(&mut hold_for_later),
|
||||||
|
)?;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
@@ -4460,6 +4502,9 @@ async fn run_terminal(
|
|||||||
.await?
|
.await?
|
||||||
{
|
{
|
||||||
refresh_live_addr(&mut addr, &cred)?;
|
refresh_live_addr(&mut addr, &cred)?;
|
||||||
|
arm_stale_terminal_input_suppression(
|
||||||
|
&mut stale_terminal_input_suppress_until,
|
||||||
|
);
|
||||||
if !forward_only {
|
if !forward_only {
|
||||||
render_frame(&frame)?;
|
render_frame(&frame)?;
|
||||||
predictor.observe_output(&frame.bytes);
|
predictor.observe_output(&frame.bytes);
|
||||||
@@ -4477,8 +4522,15 @@ async fn run_terminal(
|
|||||||
.await?;
|
.await?;
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
predictor.observe_input(&bytes)?;
|
if send_input(&socket, addr, &cred, &mut send_seq, bytes.clone()).await? {
|
||||||
send_input(&socket, addr, &cred, &mut send_seq, bytes).await?;
|
predictor.observe_input(&bytes)?;
|
||||||
|
} else {
|
||||||
|
queue_stale_pending_user_input(
|
||||||
|
&mut pending_user_input,
|
||||||
|
&mut pending_user_input_bytes,
|
||||||
|
bytes,
|
||||||
|
)?;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -4500,7 +4552,7 @@ async fn run_terminal(
|
|||||||
maybe_send_resize(&socket, addr, &cred, &mut send_seq, &mut last_size).await?;
|
maybe_send_resize(&socket, addr, &cred, &mut send_seq, &mut last_size).await?;
|
||||||
}
|
}
|
||||||
_ = frame_gap_tick.tick() => {
|
_ = frame_gap_tick.tick() => {
|
||||||
if frame_buffer.gap_wait_elapsed(Duration::from_millis(FRAME_GAP_RESYNC_AFTER_MS))
|
if frame_buffer.resync_due()
|
||||||
&& let Some(frame) = reconnect(
|
&& let Some(frame) = reconnect(
|
||||||
&socket,
|
&socket,
|
||||||
&mut cred,
|
&mut cred,
|
||||||
@@ -4512,6 +4564,9 @@ async fn run_terminal(
|
|||||||
.await?
|
.await?
|
||||||
{
|
{
|
||||||
refresh_live_addr(&mut addr, &cred)?;
|
refresh_live_addr(&mut addr, &cred)?;
|
||||||
|
arm_stale_terminal_input_suppression(
|
||||||
|
&mut stale_terminal_input_suppress_until,
|
||||||
|
);
|
||||||
if !forward_only {
|
if !forward_only {
|
||||||
render_frame(&frame)?;
|
render_frame(&frame)?;
|
||||||
predictor.observe_output(&frame.bytes);
|
predictor.observe_output(&frame.bytes);
|
||||||
@@ -4562,6 +4617,9 @@ async fn run_terminal(
|
|||||||
.await?
|
.await?
|
||||||
{
|
{
|
||||||
refresh_live_addr(&mut addr, &cred)?;
|
refresh_live_addr(&mut addr, &cred)?;
|
||||||
|
arm_stale_terminal_input_suppression(
|
||||||
|
&mut stale_terminal_input_suppress_until,
|
||||||
|
);
|
||||||
if !forward_only {
|
if !forward_only {
|
||||||
render_frame(&frame)?;
|
render_frame(&frame)?;
|
||||||
predictor.observe_output(&frame.bytes);
|
predictor.observe_output(&frame.bytes);
|
||||||
@@ -4610,6 +4668,22 @@ async fn run_terminal(
|
|||||||
}
|
}
|
||||||
PacketKind::Pong => {
|
PacketKind::Pong => {
|
||||||
last_packet_at = Instant::now();
|
last_packet_at = Instant::now();
|
||||||
|
if should_flush_terminal_input_after_contact(
|
||||||
|
forward_only,
|
||||||
|
&cred.mode,
|
||||||
|
pending_user_input.is_empty(),
|
||||||
|
) {
|
||||||
|
flush_pending_user_input(
|
||||||
|
&socket,
|
||||||
|
addr,
|
||||||
|
&cred,
|
||||||
|
&mut send_seq,
|
||||||
|
&mut predictor,
|
||||||
|
&mut pending_user_input,
|
||||||
|
&mut pending_user_input_bytes,
|
||||||
|
)
|
||||||
|
.await?;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
PacketKind::Rekey => {
|
PacketKind::Rekey => {
|
||||||
// Server-initiated transport rekey (spec §11). The Rekey is
|
// Server-initiated transport rekey (spec §11). The Rekey is
|
||||||
@@ -4651,7 +4725,7 @@ async fn run_terminal(
|
|||||||
CLIENT_TO_SERVER,
|
CLIENT_TO_SERVER,
|
||||||
b"",
|
b"",
|
||||||
)?;
|
)?;
|
||||||
socket.send_to(&ack, addr).await?;
|
let _ = send_terminal_udp(&socket, &ack, addr).await?;
|
||||||
}
|
}
|
||||||
PacketKind::AttachReject => {
|
PacketKind::AttachReject => {
|
||||||
let reject: AttachReject = protocol::from_body(&packet.body)?;
|
let reject: AttachReject = protocol::from_body(&packet.body)?;
|
||||||
@@ -4667,6 +4741,9 @@ async fn run_terminal(
|
|||||||
.await?
|
.await?
|
||||||
{
|
{
|
||||||
refresh_live_addr(&mut addr, &cred)?;
|
refresh_live_addr(&mut addr, &cred)?;
|
||||||
|
arm_stale_terminal_input_suppression(
|
||||||
|
&mut stale_terminal_input_suppress_until,
|
||||||
|
);
|
||||||
if !forward_only {
|
if !forward_only {
|
||||||
render_frame(&frame)?;
|
render_frame(&frame)?;
|
||||||
predictor.observe_output(&frame.bytes);
|
predictor.observe_output(&frame.bytes);
|
||||||
@@ -5059,6 +5136,9 @@ async fn run_terminal(
|
|||||||
.await?
|
.await?
|
||||||
{
|
{
|
||||||
refresh_live_addr(&mut addr, &cred)?;
|
refresh_live_addr(&mut addr, &cred)?;
|
||||||
|
arm_stale_terminal_input_suppression(
|
||||||
|
&mut stale_terminal_input_suppress_until,
|
||||||
|
);
|
||||||
if !forward_only {
|
if !forward_only {
|
||||||
render_frame(&frame)?;
|
render_frame(&frame)?;
|
||||||
predictor.observe_output(&frame.bytes);
|
predictor.observe_output(&frame.bytes);
|
||||||
@@ -5086,7 +5166,7 @@ async fn run_terminal(
|
|||||||
b"",
|
b"",
|
||||||
)?;
|
)?;
|
||||||
send_seq += 1;
|
send_seq += 1;
|
||||||
socket.send_to(&packet, addr).await?;
|
let _ = send_terminal_udp(&socket, &packet, addr).await?;
|
||||||
}
|
}
|
||||||
// Re-evaluate the prediction display policy on every timer tick so
|
// Re-evaluate the prediction display policy on every timer tick so
|
||||||
// a latency spike (or recovery) flips speculation on/off promptly
|
// a latency spike (or recovery) flips speculation on/off promptly
|
||||||
@@ -5400,6 +5480,23 @@ fn queue_pending_user_input_with_filter(
|
|||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn requeue_pending_user_input_front(
|
||||||
|
pending: &mut VecDeque<PendingUserInput>,
|
||||||
|
pending_bytes: &mut usize,
|
||||||
|
input: PendingUserInput,
|
||||||
|
) -> Result<()> {
|
||||||
|
let next = pending_bytes
|
||||||
|
.checked_add(input.bytes.len())
|
||||||
|
.ok_or_else(|| anyhow!("pending input buffer overflow"))?;
|
||||||
|
anyhow::ensure!(
|
||||||
|
next <= MAX_PENDING_USER_INPUT_BYTES,
|
||||||
|
"pending input buffer full while disconnected"
|
||||||
|
);
|
||||||
|
*pending_bytes = next;
|
||||||
|
pending.push_front(input);
|
||||||
|
Ok(())
|
||||||
|
}
|
||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq, Eq)]
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||||
struct PendingUserInput {
|
struct PendingUserInput {
|
||||||
bytes: Vec<u8>,
|
bytes: Vec<u8>,
|
||||||
@@ -5439,6 +5536,26 @@ fn should_hold_during_startup_gate(
|
|||||||
mode == StartupGateMode::HoldAll || already_queued || should_hold_post_submit_input(bytes)
|
mode == StartupGateMode::HoldAll || already_queued || should_hold_post_submit_input(bytes)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn should_flush_terminal_input_after_contact(
|
||||||
|
forward_only: bool,
|
||||||
|
mode: &str,
|
||||||
|
pending_empty: bool,
|
||||||
|
) -> bool {
|
||||||
|
!forward_only && !pending_empty && mode != "view-only" && mode != "forward-only"
|
||||||
|
}
|
||||||
|
|
||||||
|
fn should_strip_stale_terminal_reports(
|
||||||
|
silent_for: Duration,
|
||||||
|
suppress_until: Option<Instant>,
|
||||||
|
) -> bool {
|
||||||
|
silent_for >= STALE_TERMINAL_INPUT_AFTER
|
||||||
|
|| suppress_until.is_some_and(|deadline| Instant::now() < deadline)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn arm_stale_terminal_input_suppression(suppress_until: &mut Option<Instant>) {
|
||||||
|
*suppress_until = Some(Instant::now() + POST_RECONNECT_STALE_INPUT_GRACE);
|
||||||
|
}
|
||||||
|
|
||||||
async fn flush_pending_user_input(
|
async fn flush_pending_user_input(
|
||||||
socket: &UdpSocket,
|
socket: &UdpSocket,
|
||||||
addr: SocketAddr,
|
addr: SocketAddr,
|
||||||
@@ -5462,8 +5579,19 @@ async fn flush_pending_user_input(
|
|||||||
if bytes.is_empty() {
|
if bytes.is_empty() {
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
predictor.observe_input(&bytes)?;
|
if send_input(socket, addr, cred, send_seq, bytes.clone()).await? {
|
||||||
send_input(socket, addr, cred, send_seq, bytes).await?;
|
predictor.observe_input(&bytes)?;
|
||||||
|
} else {
|
||||||
|
requeue_pending_user_input_front(
|
||||||
|
pending,
|
||||||
|
pending_bytes,
|
||||||
|
PendingUserInput {
|
||||||
|
bytes,
|
||||||
|
strip_mouse_reports: false,
|
||||||
|
},
|
||||||
|
)?;
|
||||||
|
break;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
@@ -5489,6 +5617,7 @@ fn stale_mouse_report_len(bytes: &[u8], offset: usize) -> Option<usize> {
|
|||||||
match bytes.get(offset).copied()? {
|
match bytes.get(offset).copied()? {
|
||||||
0x1b if bytes.get(offset + 1) == Some(&b'[') => match bytes.get(offset + 2).copied() {
|
0x1b if bytes.get(offset + 1) == Some(&b'[') => match bytes.get(offset + 2).copied() {
|
||||||
Some(b'M') if offset + 6 <= bytes.len() => Some(6),
|
Some(b'M') if offset + 6 <= bytes.len() => Some(6),
|
||||||
|
Some(b'I' | b'O') => Some(3),
|
||||||
Some(b'<') => mouse_report_params_len(bytes, offset + 3, 2).map(|len| len + 3),
|
Some(b'<') => mouse_report_params_len(bytes, offset + 3, 2).map(|len| len + 3),
|
||||||
Some(byte) if byte.is_ascii_digit() => {
|
Some(byte) if byte.is_ascii_digit() => {
|
||||||
mouse_report_params_len(bytes, offset + 2, 2).map(|len| len + 2)
|
mouse_report_params_len(bytes, offset + 2, 2).map(|len| len + 2)
|
||||||
@@ -5497,13 +5626,15 @@ fn stale_mouse_report_len(bytes: &[u8], offset: usize) -> Option<usize> {
|
|||||||
},
|
},
|
||||||
0x9b => match bytes.get(offset + 1).copied() {
|
0x9b => match bytes.get(offset + 1).copied() {
|
||||||
Some(b'M') if offset + 5 <= bytes.len() => Some(5),
|
Some(b'M') if offset + 5 <= bytes.len() => Some(5),
|
||||||
|
Some(b'I' | b'O') => Some(2),
|
||||||
Some(b'<') => mouse_report_params_len(bytes, offset + 2, 2).map(|len| len + 2),
|
Some(b'<') => mouse_report_params_len(bytes, offset + 2, 2).map(|len| len + 2),
|
||||||
Some(byte) if byte.is_ascii_digit() => {
|
Some(byte) if byte.is_ascii_digit() => {
|
||||||
mouse_report_params_len(bytes, offset + 1, 2).map(|len| len + 1)
|
mouse_report_params_len(bytes, offset + 1, 2).map(|len| len + 1)
|
||||||
}
|
}
|
||||||
_ => None,
|
_ => None,
|
||||||
},
|
},
|
||||||
byte if byte.is_ascii_digit() => mouse_report_params_len(bytes, offset, 1),
|
byte if byte.is_ascii_digit() => mouse_report_params_len(bytes, offset, 1)
|
||||||
|
.or_else(|| orphan_mouse_suffix_len(bytes, offset)),
|
||||||
_ => None,
|
_ => None,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -5525,6 +5656,21 @@ fn mouse_report_params_len(bytes: &[u8], offset: usize, min_semicolons: usize) -
|
|||||||
None
|
None
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn orphan_mouse_suffix_len(bytes: &[u8], offset: usize) -> Option<usize> {
|
||||||
|
if offset != 0 {
|
||||||
|
return None;
|
||||||
|
}
|
||||||
|
let mut cursor = offset;
|
||||||
|
while let Some(byte) = bytes.get(cursor).copied() {
|
||||||
|
match byte {
|
||||||
|
b'0'..=b'9' => cursor += 1,
|
||||||
|
b'M' | b'm' if cursor > offset => return Some(cursor + 1 - offset),
|
||||||
|
_ => return None,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
None
|
||||||
|
}
|
||||||
|
|
||||||
fn stale_mouse_report_maybe_incomplete(bytes: &[u8], offset: usize) -> bool {
|
fn stale_mouse_report_maybe_incomplete(bytes: &[u8], offset: usize) -> bool {
|
||||||
let Some(rest) = bytes.get(offset..) else {
|
let Some(rest) = bytes.get(offset..) else {
|
||||||
return false;
|
return false;
|
||||||
@@ -5595,7 +5741,7 @@ async fn send_input(
|
|||||||
cred: &CachedCredential,
|
cred: &CachedCredential,
|
||||||
send_seq: &mut u64,
|
send_seq: &mut u64,
|
||||||
bytes: Vec<u8>,
|
bytes: Vec<u8>,
|
||||||
) -> Result<()> {
|
) -> Result<bool> {
|
||||||
let body = protocol::to_body(&Input { bytes })?;
|
let body = protocol::to_body(&Input { bytes })?;
|
||||||
let packet = protocol::encode_encrypted(
|
let packet = protocol::encode_encrypted(
|
||||||
PacketKind::Input,
|
PacketKind::Input,
|
||||||
@@ -5607,8 +5753,7 @@ async fn send_input(
|
|||||||
&body,
|
&body,
|
||||||
)?;
|
)?;
|
||||||
*send_seq += 1;
|
*send_seq += 1;
|
||||||
socket.send_to(&packet, addr).await?;
|
send_terminal_udp(socket, &packet, addr).await
|
||||||
Ok(())
|
|
||||||
}
|
}
|
||||||
|
|
||||||
async fn send_stream_open(
|
async fn send_stream_open(
|
||||||
@@ -5951,7 +6096,7 @@ async fn send_stream_packet(
|
|||||||
body,
|
body,
|
||||||
)?;
|
)?;
|
||||||
*send_seq += 1;
|
*send_seq += 1;
|
||||||
socket.send_to(&packet, addr).await?;
|
let _ = send_terminal_udp(socket, &packet, addr).await?;
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -6592,18 +6737,22 @@ fn contains_bytes(haystack: &[u8], needle: &[u8]) -> bool {
|
|||||||
.any(|window| window == needle)
|
.any(|window| window == needle)
|
||||||
}
|
}
|
||||||
|
|
||||||
const FRAME_GAP_RESYNC_AFTER_MS: u64 = 500;
|
const FRAME_GAP_RESYNC_AFTER_MS: u64 = 2_500;
|
||||||
|
const FRAME_GAP_RESYNC_COOLDOWN_MS: u64 = 5_000;
|
||||||
|
const FRAME_GAP_PENDING_RESYNC_THRESHOLD: usize = 128;
|
||||||
|
|
||||||
#[derive(Default)]
|
#[derive(Default)]
|
||||||
struct FrameBuffer {
|
struct FrameBuffer {
|
||||||
pending: BTreeMap<u64, Frame>,
|
pending: BTreeMap<u64, Frame>,
|
||||||
gap_since: Option<Instant>,
|
gap_since: Option<Instant>,
|
||||||
|
last_resync_at: Option<Instant>,
|
||||||
}
|
}
|
||||||
|
|
||||||
impl FrameBuffer {
|
impl FrameBuffer {
|
||||||
fn clear(&mut self) {
|
fn clear(&mut self) {
|
||||||
self.pending.clear();
|
self.pending.clear();
|
||||||
self.gap_since = None;
|
self.gap_since = None;
|
||||||
|
self.last_resync_at = None;
|
||||||
}
|
}
|
||||||
|
|
||||||
fn accept(&mut self, frame: Frame, last_rendered_seq: &mut u64) -> Vec<Frame> {
|
fn accept(&mut self, frame: Frame, last_rendered_seq: &mut u64) -> Vec<Frame> {
|
||||||
@@ -6613,6 +6762,7 @@ impl FrameBuffer {
|
|||||||
}
|
}
|
||||||
self.pending.clear();
|
self.pending.clear();
|
||||||
self.gap_since = None;
|
self.gap_since = None;
|
||||||
|
self.last_resync_at = None;
|
||||||
*last_rendered_seq = frame.output_seq;
|
*last_rendered_seq = frame.output_seq;
|
||||||
return vec![frame];
|
return vec![frame];
|
||||||
}
|
}
|
||||||
@@ -6639,11 +6789,28 @@ impl FrameBuffer {
|
|||||||
self.gap_since.get_or_insert_with(Instant::now);
|
self.gap_since.get_or_insert_with(Instant::now);
|
||||||
} else {
|
} else {
|
||||||
self.gap_since = None;
|
self.gap_since = None;
|
||||||
|
self.last_resync_at = None;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn gap_wait_elapsed(&self, wait: Duration) -> bool {
|
fn resync_due(&mut self) -> bool {
|
||||||
self.gap_since.is_some_and(|since| since.elapsed() >= wait)
|
let Some(gap_since) = self.gap_since else {
|
||||||
|
return false;
|
||||||
|
};
|
||||||
|
let now = Instant::now();
|
||||||
|
let waited = now.duration_since(gap_since);
|
||||||
|
if waited < Duration::from_millis(FRAME_GAP_RESYNC_AFTER_MS)
|
||||||
|
&& self.pending.len() < FRAME_GAP_PENDING_RESYNC_THRESHOLD
|
||||||
|
{
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
if self.last_resync_at.is_some_and(|last| {
|
||||||
|
now.duration_since(last) < Duration::from_millis(FRAME_GAP_RESYNC_COOLDOWN_MS)
|
||||||
|
}) {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
self.last_resync_at = Some(now);
|
||||||
|
true
|
||||||
}
|
}
|
||||||
|
|
||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
@@ -6693,7 +6860,7 @@ async fn send_resize(
|
|||||||
&body,
|
&body,
|
||||||
)?;
|
)?;
|
||||||
*send_seq += 1;
|
*send_seq += 1;
|
||||||
socket.send_to(&packet, addr).await?;
|
let _ = send_terminal_udp(socket, &packet, addr).await?;
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -6713,7 +6880,7 @@ async fn send_ack(
|
|||||||
b"",
|
b"",
|
||||||
)?;
|
)?;
|
||||||
*send_seq += 1;
|
*send_seq += 1;
|
||||||
socket.send_to(&packet, addr).await?;
|
let _ = send_terminal_udp(socket, &packet, addr).await?;
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -6728,7 +6895,7 @@ async fn detach_once(socket: &UdpSocket, cred: &CachedCredential, seq: u64) -> R
|
|||||||
CLIENT_TO_SERVER,
|
CLIENT_TO_SERVER,
|
||||||
b"",
|
b"",
|
||||||
)?;
|
)?;
|
||||||
socket.send_to(&packet, addr).await?;
|
let _ = send_terminal_udp(socket, &packet, addr).await?;
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -7073,15 +7240,16 @@ mod tests {
|
|||||||
release_tag_download_url, release_tag_from_effective_url, release_version_from_tag,
|
release_tag_download_url, release_tag_from_effective_url, release_version_from_tag,
|
||||||
render_status_clear, render_status_overlay, requested_env, resolved_startup_command,
|
render_status_clear, render_status_overlay, requested_env, resolved_startup_command,
|
||||||
retransmit_stream_opens, rewrite_forward_command, selected_predict_mode, selected_udp_host,
|
retransmit_stream_opens, rewrite_forward_command, selected_predict_mode, selected_udp_host,
|
||||||
server_version_mismatch, should_hold_during_startup_gate, should_hold_post_submit_input,
|
server_version_mismatch, should_flush_terminal_input_after_contact,
|
||||||
split_after_command_submit, ssh_destination_host, ssh_username, ssh_with_user,
|
should_hold_during_startup_gate, should_hold_post_submit_input, split_after_command_submit,
|
||||||
startup_command, status_ssh_target, strip_stale_mouse_reports, toml_bare_key_or_quoted,
|
ssh_destination_host, ssh_username, ssh_with_user, startup_command, status_ssh_target,
|
||||||
update_check_requested, update_version_status, upsert_managed_block, valid_forward_host,
|
strip_stale_mouse_reports, toml_bare_key_or_quoted, update_check_requested,
|
||||||
vscode_safe_alias,
|
update_version_status, upsert_managed_block, valid_forward_host, vscode_safe_alias,
|
||||||
};
|
};
|
||||||
use dosh::config::{ClientConfig, CommandExtension, HostConfig};
|
use dosh::config::{ClientConfig, CommandExtension, HostConfig};
|
||||||
use dosh::native::EnvVar;
|
use dosh::native::EnvVar;
|
||||||
use dosh::protocol::{self, Frame, PacketKind};
|
use dosh::protocol::{self, Frame, PacketKind};
|
||||||
|
use dosh::udp::is_transient_udp_send_error;
|
||||||
use ed25519_dalek::{SigningKey, VerifyingKey};
|
use ed25519_dalek::{SigningKey, VerifyingKey};
|
||||||
use std::collections::{HashMap, VecDeque};
|
use std::collections::{HashMap, VecDeque};
|
||||||
use std::fs;
|
use std::fs;
|
||||||
@@ -7483,14 +7651,12 @@ mod tests {
|
|||||||
|
|
||||||
assert!(buffer.accept(test_frame(12, false), &mut last).is_empty());
|
assert!(buffer.accept(test_frame(12, false), &mut last).is_empty());
|
||||||
assert_eq!(last, 10);
|
assert_eq!(last, 10);
|
||||||
assert!(!buffer.gap_wait_elapsed(Duration::from_secs(60)));
|
|
||||||
|
|
||||||
let ready = buffer.accept(test_frame(11, false), &mut last);
|
let ready = buffer.accept(test_frame(11, false), &mut last);
|
||||||
assert_eq!(ready.len(), 2);
|
assert_eq!(ready.len(), 2);
|
||||||
assert_eq!(ready[0].output_seq, 11);
|
assert_eq!(ready[0].output_seq, 11);
|
||||||
assert_eq!(ready[1].output_seq, 12);
|
assert_eq!(ready[1].output_seq, 12);
|
||||||
assert_eq!(last, 12);
|
assert_eq!(last, 12);
|
||||||
assert!(!buffer.gap_wait_elapsed(Duration::from_secs(0)));
|
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
@@ -7509,28 +7675,60 @@ mod tests {
|
|||||||
let mut last = 10;
|
let mut last = 10;
|
||||||
|
|
||||||
assert!(buffer.accept(test_frame(12, false), &mut last).is_empty());
|
assert!(buffer.accept(test_frame(12, false), &mut last).is_empty());
|
||||||
buffer.backdate_gap_for_test(Duration::from_secs(10));
|
|
||||||
assert!(buffer.gap_wait_elapsed(Duration::from_millis(1)));
|
|
||||||
let ready = buffer.accept(test_frame(20, true), &mut last);
|
let ready = buffer.accept(test_frame(20, true), &mut last);
|
||||||
|
|
||||||
assert_eq!(ready.len(), 1);
|
assert_eq!(ready.len(), 1);
|
||||||
assert_eq!(ready[0].output_seq, 20);
|
assert_eq!(ready[0].output_seq, 20);
|
||||||
assert_eq!(last, 20);
|
assert_eq!(last, 20);
|
||||||
assert!(!buffer.gap_wait_elapsed(Duration::from_millis(1)));
|
|
||||||
assert!(buffer.accept(test_frame(12, false), &mut last).is_empty());
|
assert!(buffer.accept(test_frame(12, false), &mut last).is_empty());
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn frame_buffer_marks_gap_ready_for_resync_after_wait() {
|
fn frame_buffer_keeps_gap_buffered_without_snapshot_resync() {
|
||||||
let mut buffer = FrameBuffer::default();
|
let mut buffer = FrameBuffer::default();
|
||||||
let mut last = 10;
|
let mut last = 10;
|
||||||
|
|
||||||
assert!(buffer.accept(test_frame(13, false), &mut last).is_empty());
|
assert!(buffer.accept(test_frame(13, false), &mut last).is_empty());
|
||||||
assert_eq!(last, 10);
|
assert_eq!(last, 10);
|
||||||
assert!(!buffer.gap_wait_elapsed(Duration::from_secs(60)));
|
assert!(buffer.accept(test_frame(14, false), &mut last).is_empty());
|
||||||
|
assert_eq!(last, 10);
|
||||||
|
assert!(!buffer.resync_due());
|
||||||
|
|
||||||
buffer.backdate_gap_for_test(Duration::from_secs(1));
|
let ready = buffer.accept(test_frame(11, false), &mut last);
|
||||||
assert!(buffer.gap_wait_elapsed(Duration::from_millis(FRAME_GAP_RESYNC_AFTER_MS)));
|
assert_eq!(ready.len(), 1);
|
||||||
|
assert_eq!(ready[0].output_seq, 11);
|
||||||
|
assert_eq!(last, 11);
|
||||||
|
|
||||||
|
let ready = buffer.accept(test_frame(12, false), &mut last);
|
||||||
|
assert_eq!(ready.len(), 3);
|
||||||
|
assert_eq!(
|
||||||
|
ready
|
||||||
|
.iter()
|
||||||
|
.map(|frame| frame.output_seq)
|
||||||
|
.collect::<Vec<_>>(),
|
||||||
|
vec![12, 13, 14]
|
||||||
|
);
|
||||||
|
assert_eq!(last, 14);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn frame_buffer_resyncs_old_gap_with_cooldown() {
|
||||||
|
let mut buffer = FrameBuffer::default();
|
||||||
|
let mut last = 10;
|
||||||
|
|
||||||
|
assert!(buffer.accept(test_frame(13, false), &mut last).is_empty());
|
||||||
|
buffer.backdate_gap_for_test(Duration::from_millis(FRAME_GAP_RESYNC_AFTER_MS + 10));
|
||||||
|
assert!(buffer.resync_due());
|
||||||
|
assert!(
|
||||||
|
!buffer.resync_due(),
|
||||||
|
"resync must be rate-limited so snapshots cannot churn the TUI"
|
||||||
|
);
|
||||||
|
|
||||||
|
let ready = buffer.accept(test_frame(20, true), &mut last);
|
||||||
|
assert_eq!(ready.len(), 1);
|
||||||
|
assert_eq!(ready[0].output_seq, 20);
|
||||||
|
assert_eq!(last, 20);
|
||||||
|
assert!(!buffer.resync_due());
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
@@ -7827,6 +8025,34 @@ mod tests {
|
|||||||
assert_eq!(post_submit_hold_duration(b"x"), POST_SUBMIT_ALL_INPUT_HOLD);
|
assert_eq!(post_submit_hold_duration(b"x"), POST_SUBMIT_ALL_INPUT_HOLD);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn contact_flushes_pending_terminal_input_for_interactive_sessions() {
|
||||||
|
assert!(should_flush_terminal_input_after_contact(
|
||||||
|
false, "normal", false
|
||||||
|
));
|
||||||
|
assert!(should_flush_terminal_input_after_contact(
|
||||||
|
false,
|
||||||
|
"read-write",
|
||||||
|
false
|
||||||
|
));
|
||||||
|
assert!(!should_flush_terminal_input_after_contact(
|
||||||
|
false, "normal", true
|
||||||
|
));
|
||||||
|
assert!(!should_flush_terminal_input_after_contact(
|
||||||
|
true, "normal", false
|
||||||
|
));
|
||||||
|
assert!(!should_flush_terminal_input_after_contact(
|
||||||
|
false,
|
||||||
|
"view-only",
|
||||||
|
false
|
||||||
|
));
|
||||||
|
assert!(!should_flush_terminal_input_after_contact(
|
||||||
|
false,
|
||||||
|
"forward-only",
|
||||||
|
false
|
||||||
|
));
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn reconnect_refreshes_live_send_address_from_credentials() {
|
fn reconnect_refreshes_live_send_address_from_credentials() {
|
||||||
let mut addr = "127.0.0.1:50000".parse().unwrap();
|
let mut addr = "127.0.0.1:50000".parse().unwrap();
|
||||||
@@ -8249,6 +8475,41 @@ mod tests {
|
|||||||
assert_eq!(pending_bytes, MAX_PENDING_USER_INPUT_BYTES);
|
assert_eq!(pending_bytes, MAX_PENDING_USER_INPUT_BYTES);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn transient_udp_send_errors_are_not_terminal_fatal() {
|
||||||
|
#[cfg(unix)]
|
||||||
|
{
|
||||||
|
assert!(is_transient_udp_send_error(
|
||||||
|
&std::io::Error::from_raw_os_error(libc::ENETUNREACH)
|
||||||
|
));
|
||||||
|
assert!(is_transient_udp_send_error(
|
||||||
|
&std::io::Error::from_raw_os_error(libc::EHOSTUNREACH)
|
||||||
|
));
|
||||||
|
assert!(is_transient_udp_send_error(
|
||||||
|
&std::io::Error::from_raw_os_error(libc::EADDRNOTAVAIL)
|
||||||
|
));
|
||||||
|
assert!(!is_transient_udp_send_error(
|
||||||
|
&std::io::Error::from_raw_os_error(libc::EINVAL)
|
||||||
|
));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(windows)]
|
||||||
|
{
|
||||||
|
assert!(is_transient_udp_send_error(
|
||||||
|
&std::io::Error::from_raw_os_error(10051)
|
||||||
|
)); // WSAENETUNREACH
|
||||||
|
assert!(is_transient_udp_send_error(
|
||||||
|
&std::io::Error::from_raw_os_error(10065)
|
||||||
|
)); // WSAEHOSTUNREACH
|
||||||
|
assert!(is_transient_udp_send_error(
|
||||||
|
&std::io::Error::from_raw_os_error(10049)
|
||||||
|
)); // WSAEADDRNOTAVAIL
|
||||||
|
assert!(!is_transient_udp_send_error(
|
||||||
|
&std::io::Error::from_raw_os_error(10022)
|
||||||
|
)); // WSAEINVAL
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn stale_mouse_reports_are_stripped_from_pending_input() {
|
fn stale_mouse_reports_are_stripped_from_pending_input() {
|
||||||
let input = b"\x1b[<35;152;1Mhello\x1b[<0;107;10m";
|
let input = b"\x1b[<35;152;1Mhello\x1b[<0;107;10m";
|
||||||
@@ -8262,6 +8523,18 @@ mod tests {
|
|||||||
assert_eq!(strip_stale_mouse_reports(b"152;1Mls\r"), b"ls\r");
|
assert_eq!(strip_stale_mouse_reports(b"152;1Mls\r"), b"ls\r");
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn split_stale_mouse_suffixes_are_stripped_from_pending_input() {
|
||||||
|
assert_eq!(strip_stale_mouse_reports(b"1M35;149;1Mls\r"), b"ls\r");
|
||||||
|
assert_eq!(strip_stale_mouse_reports(b"10m"), b"");
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn stale_focus_reports_are_stripped_from_pending_input() {
|
||||||
|
assert_eq!(strip_stale_mouse_reports(b"\x1b[Ihello\x1b[O"), b"hello");
|
||||||
|
assert_eq!(strip_stale_mouse_reports(b"\x9bIhello\x9bO"), b"hello");
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn non_mouse_escape_input_survives_stale_filter() {
|
fn non_mouse_escape_input_survives_stale_filter() {
|
||||||
assert_eq!(strip_stale_mouse_reports(b"\x1b[A"), b"\x1b[A");
|
assert_eq!(strip_stale_mouse_reports(b"\x1b[A"), b"\x1b[A");
|
||||||
|
|||||||
+113
-32
@@ -28,6 +28,7 @@ use dosh::protocol::{
|
|||||||
TicketAttachBody, TicketAttachEnvelope, TicketAttachOkEnvelope,
|
TicketAttachBody, TicketAttachEnvelope, TicketAttachOkEnvelope,
|
||||||
};
|
};
|
||||||
use dosh::pty::{PtyHandle, PtyOutput, adopt_pty_from_fd, spawn_pty_session};
|
use dosh::pty::{PtyHandle, PtyOutput, adopt_pty_from_fd, spawn_pty_session};
|
||||||
|
use dosh::udp::is_transient_udp_send_error;
|
||||||
use sha2::{Digest, Sha256};
|
use sha2::{Digest, Sha256};
|
||||||
use std::collections::{BTreeMap, HashMap, HashSet, VecDeque};
|
use std::collections::{BTreeMap, HashMap, HashSet, VecDeque};
|
||||||
use std::fs;
|
use std::fs;
|
||||||
@@ -432,6 +433,7 @@ struct PendingStreamOpen {
|
|||||||
attempts: u32,
|
attempts: u32,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[derive(Clone)]
|
||||||
struct PendingNativeAuth {
|
struct PendingNativeAuth {
|
||||||
client: dosh::native::NativeClientHello,
|
client: dosh::native::NativeClientHello,
|
||||||
server: NativeServerHello,
|
server: NativeServerHello,
|
||||||
@@ -512,12 +514,13 @@ impl ServerState {
|
|||||||
|
|
||||||
/// Whether a session named `name` should be backed by a persistent holder.
|
/// Whether a session named `name` should be backed by a persistent holder.
|
||||||
///
|
///
|
||||||
/// With persistence enabled, every PTY session gets a detached holder. That
|
/// With persistence enabled, explicitly named sessions get a detached
|
||||||
/// includes implicit `term-<millis>-<pid>` sessions: a reconnecting client has
|
/// holder. Implicit `term-<millis>-<pid>` sessions are one-off terminals
|
||||||
/// the exact session name in its ticket cache, so it can reattach after a
|
/// created by `dosh host`; users cannot intentionally reattach to them by
|
||||||
/// quick server restart without forcing users to name sessions manually.
|
/// name, so persisting them only leaves stale holders that can be
|
||||||
fn should_persist_session(&self, _name: &str) -> bool {
|
/// accidentally re-adopted after restarts.
|
||||||
self.config.persist_sessions
|
fn should_persist_session(&self, name: &str) -> bool {
|
||||||
|
self.config.persist_sessions && !protocol::is_implicit_session_name(name)
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Spawn (or, in the persistent case, spawn-and-adopt) a PTY for a session.
|
/// Spawn (or, in the persistent case, spawn-and-adopt) a PTY for a session.
|
||||||
@@ -605,6 +608,20 @@ impl ServerState {
|
|||||||
if self.sessions.contains_key(&name) {
|
if self.sessions.contains_key(&name) {
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
if !self.should_persist_session(&name) {
|
||||||
|
eprintln!(
|
||||||
|
"discarding stale implicit persistent session {name} (shell pid {})",
|
||||||
|
meta.shell_pid
|
||||||
|
);
|
||||||
|
persist::request_shutdown(&sessions_dir, &name, None);
|
||||||
|
if meta.shell_pid > 0 {
|
||||||
|
let _ = unsafe { libc::kill(meta.shell_pid, libc::SIGHUP) };
|
||||||
|
let _ = unsafe { libc::kill(meta.shell_pid, libc::SIGTERM) };
|
||||||
|
std::thread::sleep(Duration::from_millis(50));
|
||||||
|
let _ = unsafe { libc::kill(meta.shell_pid, libc::SIGKILL) };
|
||||||
|
}
|
||||||
|
continue;
|
||||||
|
}
|
||||||
let (pty, control) = match self.adopt_persistent_pty(&name) {
|
let (pty, control) = match self.adopt_persistent_pty(&name) {
|
||||||
Ok(pair) => pair,
|
Ok(pair) => pair,
|
||||||
Err(err) => {
|
Err(err) => {
|
||||||
@@ -965,7 +982,7 @@ async fn handle_native_client_hello(
|
|||||||
};
|
};
|
||||||
let body = protocol::to_body(&NativeServerHelloBody { hello })?;
|
let body = protocol::to_body(&NativeServerHelloBody { hello })?;
|
||||||
let out = protocol::encode_plain(PacketKind::NativeServerHello, pending_id, 1, 0, &body)?;
|
let out = protocol::encode_plain(PacketKind::NativeServerHello, pending_id, 1, 0, &body)?;
|
||||||
socket.send_to(&out, peer).await?;
|
let _ = send_udp(socket, &out, peer).await?;
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -976,8 +993,8 @@ async fn handle_native_user_auth(
|
|||||||
packet: &protocol::Packet,
|
packet: &protocol::Packet,
|
||||||
) -> Result<()> {
|
) -> Result<()> {
|
||||||
let pending = {
|
let pending = {
|
||||||
let mut locked = state.lock().expect("server state poisoned");
|
let locked = state.lock().expect("server state poisoned");
|
||||||
locked.pending_native.remove(&packet.header.conn_id)
|
locked.pending_native.get(&packet.header.conn_id).cloned()
|
||||||
};
|
};
|
||||||
let Some(pending) = pending else {
|
let Some(pending) = pending else {
|
||||||
return send_reject_to_client(socket, peer, packet.header.conn_id, "unknown native auth")
|
return send_reject_to_client(socket, peer, packet.header.conn_id, "unknown native auth")
|
||||||
@@ -993,11 +1010,38 @@ async fn handle_native_user_auth(
|
|||||||
.await;
|
.await;
|
||||||
}
|
}
|
||||||
if pending.created_at.elapsed() > Duration::from_secs(30) {
|
if pending.created_at.elapsed() > Duration::from_secs(30) {
|
||||||
|
state
|
||||||
|
.lock()
|
||||||
|
.expect("server state poisoned")
|
||||||
|
.pending_native
|
||||||
|
.remove(&packet.header.conn_id);
|
||||||
return send_reject_to_client(socket, peer, packet.header.conn_id, "native auth expired")
|
return send_reject_to_client(socket, peer, packet.header.conn_id, "native auth expired")
|
||||||
.await;
|
.await;
|
||||||
}
|
}
|
||||||
let body = protocol::decrypt_body(packet, &pending.session_key, CLIENT_TO_SERVER)?;
|
let body = match protocol::decrypt_body(packet, &pending.session_key, CLIENT_TO_SERVER) {
|
||||||
let req: NativeUserAuthBody = protocol::from_body(&body)?;
|
Ok(body) => body,
|
||||||
|
Err(_) => {
|
||||||
|
return send_reject_to_client(
|
||||||
|
socket,
|
||||||
|
peer,
|
||||||
|
packet.header.conn_id,
|
||||||
|
"native auth decrypt failed",
|
||||||
|
)
|
||||||
|
.await;
|
||||||
|
}
|
||||||
|
};
|
||||||
|
let req: NativeUserAuthBody = match protocol::from_body(&body) {
|
||||||
|
Ok(req) => req,
|
||||||
|
Err(_) => {
|
||||||
|
return send_reject_to_client(
|
||||||
|
socket,
|
||||||
|
peer,
|
||||||
|
packet.header.conn_id,
|
||||||
|
"invalid native auth body",
|
||||||
|
)
|
||||||
|
.await;
|
||||||
|
}
|
||||||
|
};
|
||||||
if pending.client.requested_mode == "doctor" {
|
if pending.client.requested_mode == "doctor" {
|
||||||
let check_result = {
|
let check_result = {
|
||||||
let locked = state.lock().expect("server state poisoned");
|
let locked = state.lock().expect("server state poisoned");
|
||||||
@@ -1033,6 +1077,11 @@ async fn handle_native_user_auth(
|
|||||||
.await;
|
.await;
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
state
|
||||||
|
.lock()
|
||||||
|
.expect("server state poisoned")
|
||||||
|
.pending_native
|
||||||
|
.remove(&packet.header.conn_id);
|
||||||
let body = protocol::to_body(&check)?;
|
let body = protocol::to_body(&check)?;
|
||||||
let out = protocol::encode_encrypted(
|
let out = protocol::encode_encrypted(
|
||||||
PacketKind::NativeAuthCheckOk,
|
PacketKind::NativeAuthCheckOk,
|
||||||
@@ -1043,7 +1092,7 @@ async fn handle_native_user_auth(
|
|||||||
SERVER_TO_CLIENT,
|
SERVER_TO_CLIENT,
|
||||||
&body,
|
&body,
|
||||||
)?;
|
)?;
|
||||||
socket.send_to(&out, peer).await?;
|
let _ = send_udp(socket, &out, peer).await?;
|
||||||
return Ok(());
|
return Ok(());
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1213,6 +1262,11 @@ async fn handle_native_user_auth(
|
|||||||
if let Some((listener, path)) = agent_listener {
|
if let Some((listener, path)) = agent_listener {
|
||||||
spawn_agent_forward(state, socket, client_id, listener, path);
|
spawn_agent_forward(state, socket, client_id, listener, path);
|
||||||
}
|
}
|
||||||
|
state
|
||||||
|
.lock()
|
||||||
|
.expect("server state poisoned")
|
||||||
|
.pending_native
|
||||||
|
.remove(&packet.header.conn_id);
|
||||||
|
|
||||||
let ok = NativeAuthOk {
|
let ok = NativeAuthOk {
|
||||||
client_id,
|
client_id,
|
||||||
@@ -1236,7 +1290,7 @@ async fn handle_native_user_auth(
|
|||||||
SERVER_TO_CLIENT,
|
SERVER_TO_CLIENT,
|
||||||
&body,
|
&body,
|
||||||
)?;
|
)?;
|
||||||
socket.send_to(&out, peer).await?;
|
let _ = send_udp(socket, &out, peer).await?;
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1344,7 +1398,7 @@ async fn handle_bootstrap_attach(
|
|||||||
SERVER_TO_CLIENT,
|
SERVER_TO_CLIENT,
|
||||||
&body,
|
&body,
|
||||||
)?;
|
)?;
|
||||||
socket.send_to(&out, peer).await?;
|
let _ = send_udp(socket, &out, peer).await?;
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1479,7 +1533,7 @@ async fn handle_ticket_attach(
|
|||||||
};
|
};
|
||||||
let body = protocol::to_body(&envelope)?;
|
let body = protocol::to_body(&envelope)?;
|
||||||
let out = protocol::encode_plain(PacketKind::AttachOk, client_id, 1, 0, &body)?;
|
let out = protocol::encode_plain(PacketKind::AttachOk, client_id, 1, 0, &body)?;
|
||||||
socket.send_to(&out, peer).await?;
|
let _ = send_udp(socket, &out, peer).await?;
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1497,7 +1551,7 @@ async fn send_reject_to_client(
|
|||||||
reason: reason.to_string(),
|
reason: reason.to_string(),
|
||||||
})?;
|
})?;
|
||||||
let out = protocol::encode_plain(PacketKind::AttachReject, client_id, 0, 0, &body)?;
|
let out = protocol::encode_plain(PacketKind::AttachReject, client_id, 0, 0, &body)?;
|
||||||
socket.send_to(&out, peer).await?;
|
let _ = send_udp(socket, &out, peer).await?;
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1563,7 +1617,7 @@ async fn handle_resume(
|
|||||||
SERVER_TO_CLIENT,
|
SERVER_TO_CLIENT,
|
||||||
&body,
|
&body,
|
||||||
)?;
|
)?;
|
||||||
socket.send_to(&out, peer).await?;
|
let _ = send_udp(socket, &out, peer).await?;
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1675,7 +1729,7 @@ async fn handle_ping(
|
|||||||
SERVER_TO_CLIENT,
|
SERVER_TO_CLIENT,
|
||||||
b"",
|
b"",
|
||||||
)?;
|
)?;
|
||||||
socket.send_to(&out, peer).await?;
|
let _ = send_udp(socket, &out, peer).await?;
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1690,6 +1744,14 @@ fn remove_client(state: &Arc<Mutex<ServerState>>, client_id: [u8; 16]) {
|
|||||||
locked.remove_client_everywhere(&client_id);
|
locked.remove_client_everywhere(&client_id);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
async fn send_udp(socket: &UdpSocket, packet: &[u8], peer: SocketAddr) -> Result<bool> {
|
||||||
|
match socket.send_to(packet, peer).await {
|
||||||
|
Ok(_) => Ok(true),
|
||||||
|
Err(err) if is_transient_udp_send_error(&err) => Ok(false),
|
||||||
|
Err(err) => Err(err).with_context(|| format!("send UDP packet to {peer}")),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
async fn handle_ack(
|
async fn handle_ack(
|
||||||
state: &Arc<Mutex<ServerState>>,
|
state: &Arc<Mutex<ServerState>>,
|
||||||
peer: SocketAddr,
|
peer: SocketAddr,
|
||||||
@@ -3005,7 +3067,7 @@ async fn send_stream_open_to_client(
|
|||||||
found
|
found
|
||||||
};
|
};
|
||||||
if let Some((endpoint, packet)) = send {
|
if let Some((endpoint, packet)) = send {
|
||||||
socket.send_to(&packet, endpoint).await?;
|
let _ = send_udp(socket, &packet, endpoint).await?;
|
||||||
}
|
}
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
@@ -3099,7 +3161,7 @@ async fn queue_or_send_stream_data_to_client(
|
|||||||
send
|
send
|
||||||
};
|
};
|
||||||
if let Some((endpoint, packet)) = send {
|
if let Some((endpoint, packet)) = send {
|
||||||
socket.send_to(&packet, endpoint).await?;
|
let _ = send_udp(socket, &packet, endpoint).await?;
|
||||||
}
|
}
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
@@ -3174,7 +3236,7 @@ async fn flush_stream_pending_data_to_client(
|
|||||||
let Some((endpoint, packet)) = send else {
|
let Some((endpoint, packet)) = send else {
|
||||||
return Ok(());
|
return Ok(());
|
||||||
};
|
};
|
||||||
socket.send_to(&packet, endpoint).await?;
|
let _ = send_udp(socket, &packet, endpoint).await?;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -3318,7 +3380,7 @@ async fn send_stream_packet_to_client(
|
|||||||
found
|
found
|
||||||
};
|
};
|
||||||
if let Some((endpoint, packet)) = send {
|
if let Some((endpoint, packet)) = send {
|
||||||
socket.send_to(&packet, endpoint).await?;
|
let _ = send_udp(socket, &packet, endpoint).await?;
|
||||||
}
|
}
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
@@ -3420,7 +3482,7 @@ async fn broadcast_output(
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
for (endpoint, packet) in sends {
|
for (endpoint, packet) in sends {
|
||||||
socket.send_to(&packet, endpoint).await?;
|
let _ = send_udp(socket, &packet, endpoint).await?;
|
||||||
}
|
}
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
@@ -3473,7 +3535,7 @@ async fn broadcast_session_exit(
|
|||||||
persist::remove_runtime_dir(&sessions_dir, &session_name);
|
persist::remove_runtime_dir(&sessions_dir, &session_name);
|
||||||
}
|
}
|
||||||
for (endpoint, packet) in sends {
|
for (endpoint, packet) in sends {
|
||||||
socket.send_to(&packet, endpoint).await?;
|
let _ = send_udp(socket, &packet, endpoint).await?;
|
||||||
}
|
}
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
@@ -3504,11 +3566,9 @@ async fn retransmit_pending(
|
|||||||
if pending.output_seq <= client.last_acked {
|
if pending.output_seq <= client.last_acked {
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
if now.duration_since(pending.last_sent) >= Duration::from_millis(200)
|
if now.duration_since(pending.last_sent) >= Duration::from_millis(200) {
|
||||||
&& pending.attempts < 8
|
|
||||||
{
|
|
||||||
pending.last_sent = now;
|
pending.last_sent = now;
|
||||||
pending.attempts += 1;
|
pending.attempts = pending.attempts.saturating_add(1);
|
||||||
sends.push((client.endpoint, pending.packet.clone()));
|
sends.push((client.endpoint, pending.packet.clone()));
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -3582,7 +3642,7 @@ async fn retransmit_pending(
|
|||||||
sends
|
sends
|
||||||
};
|
};
|
||||||
for (endpoint, packet) in sends {
|
for (endpoint, packet) in sends {
|
||||||
socket.send_to(&packet, endpoint).await?;
|
let _ = send_udp(socket, &packet, endpoint).await?;
|
||||||
}
|
}
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
@@ -3678,7 +3738,7 @@ async fn maybe_rekey_clients(
|
|||||||
sends
|
sends
|
||||||
};
|
};
|
||||||
for (endpoint, packet) in sends {
|
for (endpoint, packet) in sends {
|
||||||
socket.send_to(&packet, endpoint).await?;
|
let _ = send_udp(socket, &packet, endpoint).await?;
|
||||||
}
|
}
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
@@ -3841,7 +3901,7 @@ mod tests {
|
|||||||
use super::*;
|
use super::*;
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn persists_all_sessions_when_enabled() {
|
fn persists_named_sessions_when_enabled() {
|
||||||
let (pty_tx, _rx) = mpsc::unbounded_channel();
|
let (pty_tx, _rx) = mpsc::unbounded_channel();
|
||||||
let config = ServerConfig {
|
let config = ServerConfig {
|
||||||
persist_sessions: true,
|
persist_sessions: true,
|
||||||
@@ -3851,7 +3911,7 @@ mod tests {
|
|||||||
let state = ServerState::new(config, [0u8; 32], pty_tx);
|
let state = ServerState::new(config, [0u8; 32], pty_tx);
|
||||||
assert!(state.should_persist_session("default")); // prewarmed
|
assert!(state.should_persist_session("default")); // prewarmed
|
||||||
assert!(state.should_persist_session("work")); // explicitly named
|
assert!(state.should_persist_session("work")); // explicitly named
|
||||||
assert!(state.should_persist_session("term-1781470634216-76685")); // implicit reconnect
|
assert!(!state.should_persist_session("term-1781470634216-76685")); // one-off terminal
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
@@ -4523,4 +4583,25 @@ mod tests {
|
|||||||
};
|
};
|
||||||
remote_bind_allowed(&config, "0.0.0.0").unwrap();
|
remote_bind_allowed(&config, "0.0.0.0").unwrap();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[cfg(unix)]
|
||||||
|
#[test]
|
||||||
|
fn server_udp_send_classifier_treats_network_roaming_errors_as_transient() {
|
||||||
|
for code in [
|
||||||
|
libc::EADDRNOTAVAIL,
|
||||||
|
libc::ECONNREFUSED,
|
||||||
|
libc::ECONNRESET,
|
||||||
|
libc::EHOSTDOWN,
|
||||||
|
libc::EHOSTUNREACH,
|
||||||
|
libc::ENETDOWN,
|
||||||
|
libc::ENETRESET,
|
||||||
|
libc::ENETUNREACH,
|
||||||
|
libc::ETIMEDOUT,
|
||||||
|
] {
|
||||||
|
assert!(
|
||||||
|
is_transient_udp_send_error(&std::io::Error::from_raw_os_error(code)),
|
||||||
|
"expected errno {code} to be transient"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -23,3 +23,4 @@ pub mod pty;
|
|||||||
pub mod server;
|
pub mod server;
|
||||||
pub mod ssh_agent;
|
pub mod ssh_agent;
|
||||||
pub mod transport;
|
pub mod transport;
|
||||||
|
pub mod udp;
|
||||||
|
|||||||
@@ -435,6 +435,10 @@ pub fn run_holder(
|
|||||||
let mut cmd = [0u8; 1];
|
let mut cmd = [0u8; 1];
|
||||||
match stream.read(&mut cmd) {
|
match stream.read(&mut cmd) {
|
||||||
Ok(1) if cmd[0] == HOLDER_CMD_SHUTDOWN => {
|
Ok(1) if cmd[0] == HOLDER_CMD_SHUTDOWN => {
|
||||||
|
if shell_pid > 0 {
|
||||||
|
let _ = unsafe { libc::kill(shell_pid, libc::SIGHUP) };
|
||||||
|
let _ = unsafe { libc::kill(shell_pid, libc::SIGTERM) };
|
||||||
|
}
|
||||||
let _ = std::fs::remove_dir_all(runtime_dir);
|
let _ = std::fs::remove_dir_all(runtime_dir);
|
||||||
std::process::exit(0);
|
std::process::exit(0);
|
||||||
}
|
}
|
||||||
|
|||||||
+120
-6
@@ -13,6 +13,7 @@ use crate::transport::{
|
|||||||
DoshTransport, SessionEvent, SessionRole, SessionTransportConfig, TransportConfig,
|
DoshTransport, SessionEvent, SessionRole, SessionTransportConfig, TransportConfig,
|
||||||
service_name_from_target,
|
service_name_from_target,
|
||||||
};
|
};
|
||||||
|
use crate::udp::is_transient_udp_send_error;
|
||||||
use anyhow::{Context, Result, anyhow, bail};
|
use anyhow::{Context, Result, anyhow, bail};
|
||||||
use ed25519_dalek::SigningKey;
|
use ed25519_dalek::SigningKey;
|
||||||
use std::collections::{HashMap, HashSet};
|
use std::collections::{HashMap, HashSet};
|
||||||
@@ -97,6 +98,7 @@ pub enum DoshServerEvent {
|
|||||||
Ignored,
|
Ignored,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone)]
|
||||||
struct PendingServerAuth {
|
struct PendingServerAuth {
|
||||||
client: native::NativeClientHello,
|
client: native::NativeClientHello,
|
||||||
server: NativeServerHello,
|
server: NativeServerHello,
|
||||||
@@ -255,7 +257,7 @@ impl DoshServer {
|
|||||||
};
|
};
|
||||||
let body = protocol::to_body(&NativeServerHelloBody { hello })?;
|
let body = protocol::to_body(&NativeServerHelloBody { hello })?;
|
||||||
let out = protocol::encode_plain(PacketKind::NativeServerHello, pending_id, 1, 0, &body)?;
|
let out = protocol::encode_plain(PacketKind::NativeServerHello, pending_id, 1, 0, &body)?;
|
||||||
self.socket.send_to(&out, peer).await?;
|
let _ = send_udp(&self.socket, &out, peer).await?;
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -327,7 +329,7 @@ impl DoshServer {
|
|||||||
peer: SocketAddr,
|
peer: SocketAddr,
|
||||||
packet: &protocol::Packet,
|
packet: &protocol::Packet,
|
||||||
) -> Result<DoshServerEvent> {
|
) -> Result<DoshServerEvent> {
|
||||||
let Some(pending) = self.pending.remove(&packet.header.conn_id) else {
|
let Some(pending) = self.pending.get(&packet.header.conn_id).cloned() else {
|
||||||
self.send_reject(peer, packet.header.conn_id, "unknown native auth")
|
self.send_reject(peer, packet.header.conn_id, "unknown native auth")
|
||||||
.await?;
|
.await?;
|
||||||
return Ok(DoshServerEvent::Ignored);
|
return Ok(DoshServerEvent::Ignored);
|
||||||
@@ -338,13 +340,28 @@ impl DoshServer {
|
|||||||
return Ok(DoshServerEvent::Ignored);
|
return Ok(DoshServerEvent::Ignored);
|
||||||
}
|
}
|
||||||
if pending.created_at.elapsed() > self.config.auth_timeout {
|
if pending.created_at.elapsed() > self.config.auth_timeout {
|
||||||
|
self.pending.remove(&packet.header.conn_id);
|
||||||
self.send_reject(peer, packet.header.conn_id, "native auth expired")
|
self.send_reject(peer, packet.header.conn_id, "native auth expired")
|
||||||
.await?;
|
.await?;
|
||||||
return Ok(DoshServerEvent::Ignored);
|
return Ok(DoshServerEvent::Ignored);
|
||||||
}
|
}
|
||||||
|
|
||||||
let body = protocol::decrypt_body(packet, &pending.session_key, CLIENT_TO_SERVER)?;
|
let body = match protocol::decrypt_body(packet, &pending.session_key, CLIENT_TO_SERVER) {
|
||||||
let req: NativeUserAuthBody = protocol::from_body(&body)?;
|
Ok(body) => body,
|
||||||
|
Err(_) => {
|
||||||
|
self.send_reject(peer, packet.header.conn_id, "native auth decrypt failed")
|
||||||
|
.await?;
|
||||||
|
return Ok(DoshServerEvent::Ignored);
|
||||||
|
}
|
||||||
|
};
|
||||||
|
let req: NativeUserAuthBody = match protocol::from_body(&body) {
|
||||||
|
Ok(req) => req,
|
||||||
|
Err(_) => {
|
||||||
|
self.send_reject(peer, packet.header.conn_id, "invalid native auth body")
|
||||||
|
.await?;
|
||||||
|
return Ok(DoshServerEvent::Ignored);
|
||||||
|
}
|
||||||
|
};
|
||||||
let services = match self.verify_auth_and_services(&pending, &req.auth) {
|
let services = match self.verify_auth_and_services(&pending, &req.auth) {
|
||||||
Ok(services) => services,
|
Ok(services) => services,
|
||||||
Err(err) => {
|
Err(err) => {
|
||||||
@@ -353,6 +370,7 @@ impl DoshServer {
|
|||||||
return Ok(DoshServerEvent::Ignored);
|
return Ok(DoshServerEvent::Ignored);
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
self.pending.remove(&packet.header.conn_id);
|
||||||
|
|
||||||
let conn_id = crypto::random_16();
|
let conn_id = crypto::random_16();
|
||||||
let key_id = protocol::session_key_id(&pending.session_key);
|
let key_id = protocol::session_key_id(&pending.session_key);
|
||||||
@@ -381,7 +399,7 @@ impl DoshServer {
|
|||||||
SERVER_TO_CLIENT,
|
SERVER_TO_CLIENT,
|
||||||
&body,
|
&body,
|
||||||
)?;
|
)?;
|
||||||
self.socket.send_to(&out, peer).await?;
|
let _ = send_udp(&self.socket, &out, peer).await?;
|
||||||
|
|
||||||
let transport = DoshTransport::new(
|
let transport = DoshTransport::new(
|
||||||
Arc::clone(&self.socket),
|
Arc::clone(&self.socket),
|
||||||
@@ -428,7 +446,7 @@ impl DoshServer {
|
|||||||
reason: reason.to_string(),
|
reason: reason.to_string(),
|
||||||
})?;
|
})?;
|
||||||
let out = protocol::encode_plain(PacketKind::AttachReject, conn_id, 0, 0, &body)?;
|
let out = protocol::encode_plain(PacketKind::AttachReject, conn_id, 0, 0, &body)?;
|
||||||
self.socket.send_to(&out, peer).await?;
|
let _ = send_udp(&self.socket, &out, peer).await?;
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -439,6 +457,14 @@ impl DoshServer {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
async fn send_udp(socket: &UdpSocket, packet: &[u8], peer: SocketAddr) -> Result<bool> {
|
||||||
|
match socket.send_to(packet, peer).await {
|
||||||
|
Ok(_) => Ok(true),
|
||||||
|
Err(err) if is_transient_udp_send_error(&err) => Ok(false),
|
||||||
|
Err(err) => Err(err).with_context(|| format!("send UDP packet to {peer}")),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
fn validate_requested_services(
|
fn validate_requested_services(
|
||||||
allowed_services: &HashSet<String>,
|
allowed_services: &HashSet<String>,
|
||||||
requests: &[ForwardingRequest],
|
requests: &[ForwardingRequest],
|
||||||
@@ -477,6 +503,7 @@ mod tests {
|
|||||||
use super::*;
|
use super::*;
|
||||||
use crate::client::DoshClient;
|
use crate::client::DoshClient;
|
||||||
use crate::config::{ClientConfig, HostsConfig};
|
use crate::config::{ClientConfig, HostsConfig};
|
||||||
|
use crate::protocol::{CLIENT_TO_SERVER, NativeUserAuthBody};
|
||||||
use crate::transport::TransportEvent;
|
use crate::transport::TransportEvent;
|
||||||
use ed25519_dalek::SigningKey;
|
use ed25519_dalek::SigningKey;
|
||||||
|
|
||||||
@@ -588,4 +615,91 @@ mod tests {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[tokio::test]
|
||||||
|
async fn bad_native_auth_does_not_consume_pending_challenge() {
|
||||||
|
let dir = tempfile::tempdir().unwrap();
|
||||||
|
let host_key = dir.path().join("host_key");
|
||||||
|
let authorized_keys = dir.path().join("authorized_keys");
|
||||||
|
let signing = SigningKey::from_bytes(&[93u8; 32]);
|
||||||
|
let keypair = ssh_key::private::Ed25519Keypair::from(&signing);
|
||||||
|
let private =
|
||||||
|
ssh_key::PrivateKey::new(ssh_key::private::KeypairData::from(keypair), "").unwrap();
|
||||||
|
std::fs::write(
|
||||||
|
&authorized_keys,
|
||||||
|
format!("{}\n", private.public_key().to_openssh().unwrap()),
|
||||||
|
)
|
||||||
|
.unwrap();
|
||||||
|
|
||||||
|
let server_config = ServerConfig {
|
||||||
|
host_key: host_key.to_string_lossy().to_string(),
|
||||||
|
authorized_keys: vec![authorized_keys.to_string_lossy().to_string()],
|
||||||
|
..ServerConfig::default()
|
||||||
|
};
|
||||||
|
let server_config = DoshServerConfig::new(server_config)
|
||||||
|
.bind_addr("127.0.0.1:0".parse().unwrap())
|
||||||
|
.require_current_user(false);
|
||||||
|
let mut server = DoshServer::bind(server_config).await.unwrap();
|
||||||
|
let peer: SocketAddr = "127.0.0.1:9".parse().unwrap();
|
||||||
|
let (client_secret, client_public) = native::generate_native_ephemeral();
|
||||||
|
let hello = native::NativeClientHello {
|
||||||
|
protocol_version: native::NATIVE_PROTOCOL_VERSION,
|
||||||
|
client_random: crypto::random_32(),
|
||||||
|
client_ephemeral_public: client_public,
|
||||||
|
requested_host: "127.0.0.1".to_string(),
|
||||||
|
requested_user: "sdk-user".to_string(),
|
||||||
|
requested_session: "test".to_string(),
|
||||||
|
requested_mode: "forward-only".to_string(),
|
||||||
|
terminal_size: (80, 24),
|
||||||
|
supported_aead: vec!["chacha20poly1305".to_string()],
|
||||||
|
supported_user_key_algorithms: vec!["ssh-ed25519".to_string()],
|
||||||
|
cached_host_key_fingerprint: None,
|
||||||
|
attach_ticket_envelope: None,
|
||||||
|
requested_env: Vec::new(),
|
||||||
|
};
|
||||||
|
let (pending_id, server_hello) = server.build_server_hello(hello.clone(), peer).unwrap();
|
||||||
|
let session_key = native::derive_native_session_key(
|
||||||
|
&client_secret,
|
||||||
|
server_hello.server_ephemeral_public,
|
||||||
|
&hello,
|
||||||
|
&server_hello,
|
||||||
|
)
|
||||||
|
.unwrap();
|
||||||
|
let auth = native::sign_user_auth(&signing, &hello, &server_hello, Vec::new()).unwrap();
|
||||||
|
let body = protocol::to_body(&NativeUserAuthBody { auth }).unwrap();
|
||||||
|
let bad = protocol::encode_encrypted(
|
||||||
|
PacketKind::NativeUserAuth,
|
||||||
|
pending_id,
|
||||||
|
2,
|
||||||
|
1,
|
||||||
|
&[7u8; 32],
|
||||||
|
CLIENT_TO_SERVER,
|
||||||
|
&body,
|
||||||
|
)
|
||||||
|
.unwrap();
|
||||||
|
let bad = protocol::decode(&bad).unwrap();
|
||||||
|
|
||||||
|
assert!(matches!(
|
||||||
|
server.handle_user_auth(peer, &bad).await.unwrap(),
|
||||||
|
DoshServerEvent::Ignored
|
||||||
|
));
|
||||||
|
assert!(server.pending.contains_key(&pending_id));
|
||||||
|
|
||||||
|
let valid = protocol::encode_encrypted(
|
||||||
|
PacketKind::NativeUserAuth,
|
||||||
|
pending_id,
|
||||||
|
2,
|
||||||
|
1,
|
||||||
|
&session_key,
|
||||||
|
CLIENT_TO_SERVER,
|
||||||
|
&body,
|
||||||
|
)
|
||||||
|
.unwrap();
|
||||||
|
let valid = protocol::decode(&valid).unwrap();
|
||||||
|
assert!(matches!(
|
||||||
|
server.handle_user_auth(peer, &valid).await.unwrap(),
|
||||||
|
DoshServerEvent::Accepted(_)
|
||||||
|
));
|
||||||
|
assert!(!server.pending.contains_key(&pending_id));
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
+114
-10
@@ -19,6 +19,7 @@ use crate::protocol::{
|
|||||||
self, CLIENT_TO_SERVER, PacketKind, ReplayWindow, SERVER_TO_CLIENT, StreamClose, StreamData,
|
self, CLIENT_TO_SERVER, PacketKind, ReplayWindow, SERVER_TO_CLIENT, StreamClose, StreamData,
|
||||||
StreamOpen, StreamOpenOk, StreamOpenReject, StreamWindowAdjust,
|
StreamOpen, StreamOpenOk, StreamOpenReject, StreamWindowAdjust,
|
||||||
};
|
};
|
||||||
|
use crate::udp::is_transient_udp_send_error;
|
||||||
use anyhow::{Result, anyhow, bail};
|
use anyhow::{Result, anyhow, bail};
|
||||||
use std::collections::{BTreeMap, HashMap, HashSet, VecDeque};
|
use std::collections::{BTreeMap, HashMap, HashSet, VecDeque};
|
||||||
use std::net::SocketAddr;
|
use std::net::SocketAddr;
|
||||||
@@ -348,8 +349,8 @@ impl StreamMux {
|
|||||||
&mut self,
|
&mut self,
|
||||||
adjust: StreamWindowAdjust,
|
adjust: StreamWindowAdjust,
|
||||||
) -> Result<Vec<OutgoingStreamPacket>> {
|
) -> Result<Vec<OutgoingStreamPacket>> {
|
||||||
self.ack_data(adjust.stream_id, adjust.received_offset);
|
let acked_bytes = self.ack_data(adjust.stream_id, adjust.received_offset);
|
||||||
self.add_credit(adjust.stream_id, adjust.bytes as usize);
|
self.add_credit(adjust.stream_id, acked_bytes);
|
||||||
self.flush_pending_data(adjust.stream_id)
|
self.flush_pending_data(adjust.stream_id)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -556,9 +557,9 @@ impl StreamMux {
|
|||||||
(chunks, consumed, *expected)
|
(chunks, consumed, *expected)
|
||||||
}
|
}
|
||||||
|
|
||||||
fn ack_data(&mut self, stream_id: u64, received_offset: u64) {
|
fn ack_data(&mut self, stream_id: u64, received_offset: u64) -> usize {
|
||||||
let Some(sent) = self.sent_data.get_mut(&stream_id) else {
|
let Some(sent) = self.sent_data.get_mut(&stream_id) else {
|
||||||
return;
|
return 0;
|
||||||
};
|
};
|
||||||
let acked_offsets = sent
|
let acked_offsets = sent
|
||||||
.iter()
|
.iter()
|
||||||
@@ -567,12 +568,16 @@ impl StreamMux {
|
|||||||
(end <= received_offset).then_some(*offset)
|
(end <= received_offset).then_some(*offset)
|
||||||
})
|
})
|
||||||
.collect::<Vec<_>>();
|
.collect::<Vec<_>>();
|
||||||
|
let mut acked_bytes = 0usize;
|
||||||
for offset in acked_offsets {
|
for offset in acked_offsets {
|
||||||
sent.remove(&offset);
|
if let Some(chunk) = sent.remove(&offset) {
|
||||||
|
acked_bytes = acked_bytes.saturating_add(chunk.bytes.len());
|
||||||
|
}
|
||||||
}
|
}
|
||||||
if sent.is_empty() {
|
if sent.is_empty() {
|
||||||
self.sent_data.remove(&stream_id);
|
self.sent_data.remove(&stream_id);
|
||||||
}
|
}
|
||||||
|
acked_bytes
|
||||||
}
|
}
|
||||||
|
|
||||||
fn add_credit(&mut self, stream_id: u64, bytes: usize) {
|
fn add_credit(&mut self, stream_id: u64, bytes: usize) {
|
||||||
@@ -732,11 +737,17 @@ impl DoshTransport {
|
|||||||
if packet.header.conn_id != self.conn_id {
|
if packet.header.conn_id != self.conn_id {
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
let plain = match protocol::decrypt_body(
|
||||||
|
&packet,
|
||||||
|
&self.session_key,
|
||||||
|
self.role.recv_direction(),
|
||||||
|
) {
|
||||||
|
Ok(plain) => plain,
|
||||||
|
Err(_) => continue,
|
||||||
|
};
|
||||||
if !self.replay.accept(packet.header.seq) {
|
if !self.replay.accept(packet.header.seq) {
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
let plain =
|
|
||||||
protocol::decrypt_body(&packet, &self.session_key, self.role.recv_direction())?;
|
|
||||||
self.peer_addr = peer;
|
self.peer_addr = peer;
|
||||||
self.ack_seq = self.ack_seq.max(packet.header.seq);
|
self.ack_seq = self.ack_seq.max(packet.header.seq);
|
||||||
self.last_contact = Instant::now();
|
self.last_contact = Instant::now();
|
||||||
@@ -751,14 +762,21 @@ impl DoshTransport {
|
|||||||
datagram: &[u8],
|
datagram: &[u8],
|
||||||
peer: SocketAddr,
|
peer: SocketAddr,
|
||||||
) -> Result<SessionEvent> {
|
) -> Result<SessionEvent> {
|
||||||
let packet = protocol::decode(datagram)?;
|
let packet = match protocol::decode(datagram) {
|
||||||
|
Ok(packet) => packet,
|
||||||
|
Err(_) => return Ok(SessionEvent::Ignored),
|
||||||
|
};
|
||||||
if packet.header.conn_id != self.conn_id {
|
if packet.header.conn_id != self.conn_id {
|
||||||
return Ok(SessionEvent::Ignored);
|
return Ok(SessionEvent::Ignored);
|
||||||
}
|
}
|
||||||
|
let plain =
|
||||||
|
match protocol::decrypt_body(&packet, &self.session_key, self.role.recv_direction()) {
|
||||||
|
Ok(plain) => plain,
|
||||||
|
Err(_) => return Ok(SessionEvent::Ignored),
|
||||||
|
};
|
||||||
if !self.replay.accept(packet.header.seq) {
|
if !self.replay.accept(packet.header.seq) {
|
||||||
return Ok(SessionEvent::Ignored);
|
return Ok(SessionEvent::Ignored);
|
||||||
}
|
}
|
||||||
let plain = protocol::decrypt_body(&packet, &self.session_key, self.role.recv_direction())?;
|
|
||||||
self.peer_addr = peer;
|
self.peer_addr = peer;
|
||||||
self.ack_seq = self.ack_seq.max(packet.header.seq);
|
self.ack_seq = self.ack_seq.max(packet.header.seq);
|
||||||
self.last_contact = Instant::now();
|
self.last_contact = Instant::now();
|
||||||
@@ -815,7 +833,12 @@ impl DoshTransport {
|
|||||||
|
|
||||||
async fn send_kind(&mut self, kind: PacketKind, body: &[u8]) -> Result<()> {
|
async fn send_kind(&mut self, kind: PacketKind, body: &[u8]) -> Result<()> {
|
||||||
let encoded = self.encode_kind(kind, body)?;
|
let encoded = self.encode_kind(kind, body)?;
|
||||||
self.socket.send_to(&encoded, self.peer_addr).await?;
|
if let Err(err) = self.socket.send_to(&encoded, self.peer_addr).await {
|
||||||
|
if is_transient_udp_send_error(&err) {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
|
return Err(err.into());
|
||||||
|
}
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -980,6 +1003,30 @@ mod tests {
|
|||||||
assert_eq!(data.bytes, b"!");
|
assert_eq!(data.bytes, b"!");
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn cumulative_window_adjust_restores_credit_even_if_delta_was_lost() {
|
||||||
|
let mut mux = StreamMux::new(TransportConfig {
|
||||||
|
initial_window: 5,
|
||||||
|
retransmit_after: Duration::from_secs(1),
|
||||||
|
..TransportConfig::default()
|
||||||
|
});
|
||||||
|
mux.open_stream(1, "@dosh-test", 0).unwrap();
|
||||||
|
mux.handle_open_ok(StreamOpenOk { stream_id: 1 }).unwrap();
|
||||||
|
assert_eq!(mux.send_data(1, b"hello".to_vec()).unwrap().len(), 1);
|
||||||
|
assert_eq!(mux.send_credit[&1], 0);
|
||||||
|
|
||||||
|
let flushed = mux
|
||||||
|
.handle_window_adjust(StreamWindowAdjust {
|
||||||
|
stream_id: 1,
|
||||||
|
received_offset: 5,
|
||||||
|
bytes: 0,
|
||||||
|
})
|
||||||
|
.unwrap();
|
||||||
|
assert!(flushed.is_empty());
|
||||||
|
assert_eq!(mux.send_credit[&1], 5);
|
||||||
|
assert_eq!(mux.send_data(1, b"!".to_vec()).unwrap().len(), 1);
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn handle_packet_decodes_and_dispatches_stream_packets() {
|
fn handle_packet_decodes_and_dispatches_stream_packets() {
|
||||||
let mut mux = StreamMux::new(TransportConfig::default());
|
let mut mux = StreamMux::new(TransportConfig::default());
|
||||||
@@ -1096,4 +1143,61 @@ mod tests {
|
|||||||
assert!(matches!(server.recv().await.unwrap(), SessionEvent::Ping));
|
assert!(matches!(server.recv().await.unwrap(), SessionEvent::Ping));
|
||||||
assert_eq!(server.peer_addr(), roaming_addr);
|
assert_eq!(server.peer_addr(), roaming_addr);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[tokio::test]
|
||||||
|
async fn unauthenticated_datagram_does_not_poison_replay_window() {
|
||||||
|
let socket = UdpSocket::bind("127.0.0.1:0").await.unwrap();
|
||||||
|
let peer: SocketAddr = "127.0.0.1:9".parse().unwrap();
|
||||||
|
let key = [11u8; 32];
|
||||||
|
let wrong_key = [12u8; 32];
|
||||||
|
let conn_id = [4u8; 16];
|
||||||
|
let mut transport = DoshTransport::new_owned(
|
||||||
|
socket,
|
||||||
|
SessionTransportConfig {
|
||||||
|
role: SessionRole::Client,
|
||||||
|
conn_id,
|
||||||
|
session_key: key,
|
||||||
|
peer_addr: peer,
|
||||||
|
initial_send_seq: 1,
|
||||||
|
initial_ack: 0,
|
||||||
|
stream: TransportConfig::default(),
|
||||||
|
},
|
||||||
|
);
|
||||||
|
let bad = protocol::encode_encrypted(
|
||||||
|
PacketKind::Pong,
|
||||||
|
conn_id,
|
||||||
|
9,
|
||||||
|
0,
|
||||||
|
&wrong_key,
|
||||||
|
SERVER_TO_CLIENT,
|
||||||
|
b"",
|
||||||
|
)
|
||||||
|
.unwrap();
|
||||||
|
let valid = protocol::encode_encrypted(
|
||||||
|
PacketKind::Pong,
|
||||||
|
conn_id,
|
||||||
|
9,
|
||||||
|
0,
|
||||||
|
&key,
|
||||||
|
SERVER_TO_CLIENT,
|
||||||
|
b"",
|
||||||
|
)
|
||||||
|
.unwrap();
|
||||||
|
|
||||||
|
assert!(matches!(
|
||||||
|
transport
|
||||||
|
.handle_datagram(b"not a dosh packet", peer)
|
||||||
|
.await
|
||||||
|
.unwrap(),
|
||||||
|
SessionEvent::Ignored
|
||||||
|
));
|
||||||
|
assert!(matches!(
|
||||||
|
transport.handle_datagram(&bad, peer).await.unwrap(),
|
||||||
|
SessionEvent::Ignored
|
||||||
|
));
|
||||||
|
assert!(matches!(
|
||||||
|
transport.handle_datagram(&valid, peer).await.unwrap(),
|
||||||
|
SessionEvent::Pong
|
||||||
|
));
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
+98
@@ -0,0 +1,98 @@
|
|||||||
|
//! UDP error classification shared by Dosh clients, servers, and embedders.
|
||||||
|
|
||||||
|
pub fn is_transient_udp_send_error(err: &std::io::Error) -> bool {
|
||||||
|
matches!(
|
||||||
|
err.kind(),
|
||||||
|
std::io::ErrorKind::Interrupted
|
||||||
|
| std::io::ErrorKind::TimedOut
|
||||||
|
| std::io::ErrorKind::WouldBlock
|
||||||
|
) || err.raw_os_error().is_some_and(is_transient_udp_os_error)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(unix)]
|
||||||
|
fn is_transient_udp_os_error(code: i32) -> bool {
|
||||||
|
matches!(
|
||||||
|
code,
|
||||||
|
libc::EADDRNOTAVAIL
|
||||||
|
| libc::ECONNREFUSED
|
||||||
|
| libc::ECONNRESET
|
||||||
|
| libc::EHOSTDOWN
|
||||||
|
| libc::EHOSTUNREACH
|
||||||
|
| libc::ENETDOWN
|
||||||
|
| libc::ENETRESET
|
||||||
|
| libc::ENETUNREACH
|
||||||
|
| libc::ETIMEDOUT
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(windows)]
|
||||||
|
fn is_transient_udp_os_error(code: i32) -> bool {
|
||||||
|
matches!(
|
||||||
|
code,
|
||||||
|
10049 // WSAEADDRNOTAVAIL
|
||||||
|
| 10050 // WSAENETDOWN
|
||||||
|
| 10051 // WSAENETUNREACH
|
||||||
|
| 10052 // WSAENETRESET
|
||||||
|
| 10054 // WSAECONNRESET
|
||||||
|
| 10060 // WSAETIMEDOUT
|
||||||
|
| 10061 // WSAECONNREFUSED
|
||||||
|
| 10064 // WSAEHOSTDOWN
|
||||||
|
| 10065 // WSAEHOSTUNREACH
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(not(any(unix, windows)))]
|
||||||
|
fn is_transient_udp_os_error(_code: i32) -> bool {
|
||||||
|
false
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(test)]
|
||||||
|
mod tests {
|
||||||
|
use super::is_transient_udp_send_error;
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn classifies_portable_transient_send_errors() {
|
||||||
|
for kind in [
|
||||||
|
std::io::ErrorKind::Interrupted,
|
||||||
|
std::io::ErrorKind::TimedOut,
|
||||||
|
std::io::ErrorKind::WouldBlock,
|
||||||
|
] {
|
||||||
|
assert!(is_transient_udp_send_error(&std::io::Error::from(kind)));
|
||||||
|
}
|
||||||
|
assert!(!is_transient_udp_send_error(&std::io::Error::from(
|
||||||
|
std::io::ErrorKind::PermissionDenied,
|
||||||
|
)));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(unix)]
|
||||||
|
#[test]
|
||||||
|
fn classifies_unix_network_churn_as_transient() {
|
||||||
|
for code in [
|
||||||
|
libc::EADDRNOTAVAIL,
|
||||||
|
libc::ECONNREFUSED,
|
||||||
|
libc::ECONNRESET,
|
||||||
|
libc::EHOSTDOWN,
|
||||||
|
libc::EHOSTUNREACH,
|
||||||
|
libc::ENETDOWN,
|
||||||
|
libc::ENETRESET,
|
||||||
|
libc::ENETUNREACH,
|
||||||
|
libc::ETIMEDOUT,
|
||||||
|
] {
|
||||||
|
assert!(is_transient_udp_send_error(
|
||||||
|
&std::io::Error::from_raw_os_error(code)
|
||||||
|
));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(windows)]
|
||||||
|
#[test]
|
||||||
|
fn classifies_windows_network_churn_as_transient() {
|
||||||
|
for code in [
|
||||||
|
10049, 10050, 10051, 10052, 10054, 10060, 10061, 10064, 10065,
|
||||||
|
] {
|
||||||
|
assert!(is_transient_udp_send_error(
|
||||||
|
&std::io::Error::from_raw_os_error(code)
|
||||||
|
));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
+141
-9
@@ -258,7 +258,8 @@ fn relay_loop(
|
|||||||
let mut upstream = new_upstream();
|
let mut upstream = new_upstream();
|
||||||
let mut client_addr: Option<SocketAddr> = None;
|
let mut client_addr: Option<SocketAddr> = None;
|
||||||
let mut rng = StdRng::seed_from_u64(seed);
|
let mut rng = StdRng::seed_from_u64(seed);
|
||||||
let mut held: Option<(Vec<u8>, bool)> = None; // (packet, is_c2s) held for reorder
|
let mut held_c2s: Option<Vec<u8>> = None;
|
||||||
|
let mut held_s2c: Option<Vec<u8>> = None;
|
||||||
let mut buf = [0u8; 65535];
|
let mut buf = [0u8; 65535];
|
||||||
|
|
||||||
loop {
|
loop {
|
||||||
@@ -288,10 +289,9 @@ fn relay_loop(
|
|||||||
&upstream,
|
&upstream,
|
||||||
server_addr,
|
server_addr,
|
||||||
packet,
|
packet,
|
||||||
true,
|
|
||||||
&controls,
|
&controls,
|
||||||
&mut rng,
|
&mut rng,
|
||||||
&mut held,
|
&mut held_c2s,
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -310,7 +310,12 @@ fn relay_loop(
|
|||||||
let drop_pct = controls.drop_s2c_percent.load(Ordering::SeqCst);
|
let drop_pct = controls.drop_s2c_percent.load(Ordering::SeqCst);
|
||||||
if drop_pct == 0 || rng.gen_range(0..100) >= drop_pct {
|
if drop_pct == 0 || rng.gen_range(0..100) >= drop_pct {
|
||||||
forward_with_effects(
|
forward_with_effects(
|
||||||
&front, dst, packet, false, &controls, &mut rng, &mut held,
|
&front,
|
||||||
|
dst,
|
||||||
|
packet,
|
||||||
|
&controls,
|
||||||
|
&mut rng,
|
||||||
|
&mut held_s2c,
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -336,23 +341,22 @@ fn forward_with_effects(
|
|||||||
out: &UdpSocket,
|
out: &UdpSocket,
|
||||||
dst: SocketAddr,
|
dst: SocketAddr,
|
||||||
packet: Vec<u8>,
|
packet: Vec<u8>,
|
||||||
is_c2s: bool,
|
|
||||||
controls: &RelayControls,
|
controls: &RelayControls,
|
||||||
rng: &mut StdRng,
|
rng: &mut StdRng,
|
||||||
held: &mut Option<(Vec<u8>, bool)>,
|
held: &mut Option<Vec<u8>>,
|
||||||
) {
|
) {
|
||||||
// Reorder: if armed, hold this packet and release the previously held one
|
// Reorder: if armed, hold this packet and release the previously held one
|
||||||
// afterward (so two consecutive packets swap order).
|
// afterward (so two consecutive packets swap order).
|
||||||
if controls.reorder_next.swap(false, Ordering::SeqCst) {
|
if controls.reorder_next.swap(false, Ordering::SeqCst) {
|
||||||
if let Some((prev, _)) = held.take() {
|
if let Some(prev) = held.take() {
|
||||||
let _ = out.send_to(&packet, dst);
|
let _ = out.send_to(&packet, dst);
|
||||||
let _ = out.send_to(&prev, dst);
|
let _ = out.send_to(&prev, dst);
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
*held = Some((packet, is_c2s));
|
*held = Some(packet);
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
if let Some((prev, _)) = held.take() {
|
if let Some(prev) = held.take() {
|
||||||
let _ = out.send_to(&prev, dst);
|
let _ = out.send_to(&prev, dst);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -767,6 +771,46 @@ fn wait_for_text(socket: &UdpSocket, key: &[u8; 32], needle: &str, millis: u64)
|
|||||||
acc.contains(needle)
|
acc.contains(needle)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn wait_for_text_with_ack(
|
||||||
|
socket: &UdpSocket,
|
||||||
|
relay: &Relay,
|
||||||
|
client_id: [u8; 16],
|
||||||
|
seq: &mut u64,
|
||||||
|
key: &[u8; 32],
|
||||||
|
needle: &str,
|
||||||
|
millis: u64,
|
||||||
|
) -> bool {
|
||||||
|
let prev = socket.read_timeout().unwrap();
|
||||||
|
socket
|
||||||
|
.set_read_timeout(Some(Duration::from_millis(100)))
|
||||||
|
.unwrap();
|
||||||
|
let deadline = Instant::now() + Duration::from_millis(millis);
|
||||||
|
let mut acc = String::new();
|
||||||
|
while Instant::now() < deadline {
|
||||||
|
if let Some((_header, frame)) = recv_frame(socket, key) {
|
||||||
|
acc.push_str(&String::from_utf8_lossy(&frame.bytes));
|
||||||
|
let ack = protocol::encode_encrypted(
|
||||||
|
PacketKind::Ack,
|
||||||
|
client_id,
|
||||||
|
*seq,
|
||||||
|
frame.output_seq,
|
||||||
|
key,
|
||||||
|
CLIENT_TO_SERVER,
|
||||||
|
b"",
|
||||||
|
)
|
||||||
|
.unwrap();
|
||||||
|
*seq += 1;
|
||||||
|
socket.send_to(&ack, relay.front_addr()).unwrap();
|
||||||
|
if acc.contains(needle) {
|
||||||
|
socket.set_read_timeout(prev).unwrap();
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
socket.set_read_timeout(prev).unwrap();
|
||||||
|
acc.contains(needle)
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn session_survives_packet_loss_and_reorder() {
|
fn session_survives_packet_loss_and_reorder() {
|
||||||
let dir = tempfile::tempdir().unwrap();
|
let dir = tempfile::tempdir().unwrap();
|
||||||
@@ -820,6 +864,94 @@ fn session_survives_packet_loss_and_reorder() {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
#[ignore = "30-minute hostile-network TUI soak; run with `DOSH_BADNET_SOAK_SECONDS=1800 cargo test --test hostile_network bad_network_tui_work_soak_30m -- --ignored --nocapture`"]
|
||||||
|
fn bad_network_tui_work_soak_30m() {
|
||||||
|
let soak_secs = std::env::var("DOSH_BADNET_SOAK_SECONDS")
|
||||||
|
.ok()
|
||||||
|
.and_then(|value| value.parse::<u64>().ok())
|
||||||
|
.unwrap_or(30 * 60);
|
||||||
|
let dir = tempfile::tempdir().unwrap();
|
||||||
|
let port = free_udp_port();
|
||||||
|
let config = write_server_config(&dir, port);
|
||||||
|
let mut server = start_server(&dir, &config);
|
||||||
|
let relay = Relay::spawn(port, 0xBADC0DEu64);
|
||||||
|
let (socket, bootstrap, ok) = attach_through_relay(&config, &relay);
|
||||||
|
|
||||||
|
relay.set_drop_c2s(15);
|
||||||
|
relay.set_drop_s2c(20);
|
||||||
|
relay.set_dup(10);
|
||||||
|
|
||||||
|
let deadline = Instant::now() + Duration::from_secs(soak_secs);
|
||||||
|
let mut seq = 2u64;
|
||||||
|
let mut iteration = 0u64;
|
||||||
|
while Instant::now() < deadline {
|
||||||
|
if iteration.is_multiple_of(2) {
|
||||||
|
relay.arm_reorder();
|
||||||
|
}
|
||||||
|
if iteration > 0 && iteration.is_multiple_of(7) {
|
||||||
|
let _ = relay.rebind_upstream();
|
||||||
|
}
|
||||||
|
if iteration > 0 && iteration.is_multiple_of(11) {
|
||||||
|
relay.set_drop_s2c(100);
|
||||||
|
thread::sleep(Duration::from_millis(750));
|
||||||
|
relay.set_drop_s2c(20);
|
||||||
|
}
|
||||||
|
|
||||||
|
let marker = format!("DOSH_BADNET_TUI_{iteration}");
|
||||||
|
let command = format!(
|
||||||
|
"stty -echo; \
|
||||||
|
printf '\\033[?1049h\\033[?2026h\\033[?25l'; \
|
||||||
|
for i in 1 2 3 4 5 6; do \
|
||||||
|
printf '\\033[%s;4H{} ⠀⠁⠃⠇⡇⣇⣧⣷⣿ █▇▆▅▄▃▂▁ %s\\033[0m' \"$i\" \"$i\"; \
|
||||||
|
done; \
|
||||||
|
printf '\\033[?25h\\033[?2026l\\033[?1049l'\n",
|
||||||
|
marker
|
||||||
|
);
|
||||||
|
|
||||||
|
let step_deadline = Instant::now() + Duration::from_secs(8);
|
||||||
|
let mut seen = false;
|
||||||
|
let mut attempts = 0;
|
||||||
|
while Instant::now() < step_deadline && attempts < 12 {
|
||||||
|
send_input(
|
||||||
|
&socket,
|
||||||
|
&relay,
|
||||||
|
ok.client_id,
|
||||||
|
seq,
|
||||||
|
0,
|
||||||
|
&bootstrap.session_key,
|
||||||
|
command.as_bytes(),
|
||||||
|
);
|
||||||
|
seq += 1;
|
||||||
|
attempts += 1;
|
||||||
|
if wait_for_text_with_ack(
|
||||||
|
&socket,
|
||||||
|
&relay,
|
||||||
|
ok.client_id,
|
||||||
|
&mut seq,
|
||||||
|
&bootstrap.session_key,
|
||||||
|
&marker,
|
||||||
|
500,
|
||||||
|
) {
|
||||||
|
seen = true;
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
assert!(
|
||||||
|
seen,
|
||||||
|
"TUI marker {marker} did not arrive during hostile-network soak"
|
||||||
|
);
|
||||||
|
|
||||||
|
iteration += 1;
|
||||||
|
thread::sleep(Duration::from_millis(500));
|
||||||
|
}
|
||||||
|
|
||||||
|
relay.clear_impairments();
|
||||||
|
drop(relay);
|
||||||
|
let _ = server.kill();
|
||||||
|
let _ = server.wait();
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn duplicated_and_replayed_input_is_applied_at_most_once() {
|
fn duplicated_and_replayed_input_is_applied_at_most_once() {
|
||||||
let dir = tempfile::tempdir().unwrap();
|
let dir = tempfile::tempdir().unwrap();
|
||||||
|
|||||||
+92
-26
@@ -1392,18 +1392,10 @@ fn server_retransmits_unacked_output_frames() {
|
|||||||
);
|
);
|
||||||
|
|
||||||
let mut seen = Vec::new();
|
let mut seen = Vec::new();
|
||||||
let mut duplicate = None;
|
let deadline = std::time::Instant::now() + Duration::from_secs(4);
|
||||||
let deadline = std::time::Instant::now() + Duration::from_secs(3);
|
|
||||||
while std::time::Instant::now() < deadline {
|
while std::time::Instant::now() < deadline {
|
||||||
if let Some((header, frame)) = recv_frame(&socket, &bootstrap.session_key) {
|
if let Some((header, frame)) = recv_frame(&socket, &bootstrap.session_key) {
|
||||||
if String::from_utf8_lossy(&frame.bytes).contains("DOSH_RETRANSMIT") {
|
if String::from_utf8_lossy(&frame.bytes).contains("DOSH_RETRANSMIT") {
|
||||||
if seen
|
|
||||||
.iter()
|
|
||||||
.any(|(_, output_seq)| *output_seq == frame.output_seq)
|
|
||||||
{
|
|
||||||
duplicate = Some((header.seq, frame.output_seq));
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
seen.push((header.seq, frame.output_seq));
|
seen.push((header.seq, frame.output_seq));
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -1412,9 +1404,18 @@ fn server_retransmits_unacked_output_frames() {
|
|||||||
let _ = server.kill();
|
let _ = server.kill();
|
||||||
let _ = server.wait();
|
let _ = server.wait();
|
||||||
|
|
||||||
|
let max_same_output_seq = seen
|
||||||
|
.iter()
|
||||||
|
.map(|(_, output_seq)| {
|
||||||
|
seen.iter()
|
||||||
|
.filter(|(_, candidate)| candidate == output_seq)
|
||||||
|
.count()
|
||||||
|
})
|
||||||
|
.max()
|
||||||
|
.unwrap_or(0);
|
||||||
assert!(
|
assert!(
|
||||||
duplicate.is_some(),
|
max_same_output_seq >= 10,
|
||||||
"expected retransmitted same output seq, seen={seen:?}"
|
"expected retransmission to continue past the old 8-attempt ceiling, seen={seen:?}"
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -2518,6 +2519,9 @@ fn write_persistent_server_config(dir: &tempfile::TempDir, port: u16) -> std::pa
|
|||||||
let mut raw = fs::read_to_string(&config).unwrap();
|
let mut raw = fs::read_to_string(&config).unwrap();
|
||||||
// The base writer hardcodes `persist_sessions = false`; flip it on.
|
// The base writer hardcodes `persist_sessions = false`; flip it on.
|
||||||
raw = raw.replace("persist_sessions = false", "persist_sessions = true");
|
raw = raw.replace("persist_sessions = false", "persist_sessions = true");
|
||||||
|
// Persistence tests attach the sessions they need explicitly. Leaving the
|
||||||
|
// base prewarm on here creates a detached default holder in every test.
|
||||||
|
raw = raw.replace("prewarm_sessions = [\"default\"]", "prewarm_sessions = []");
|
||||||
fs::write(&config, raw).unwrap();
|
fs::write(&config, raw).unwrap();
|
||||||
config
|
config
|
||||||
}
|
}
|
||||||
@@ -2553,6 +2557,45 @@ fn kill_holder(sessions_dir: &Path, session: &str) {
|
|||||||
.status();
|
.status();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Create a holder the way older Dosh builds did for implicit sessions, so
|
||||||
|
/// startup migration can be tested without depending on the new spawn policy.
|
||||||
|
fn spawn_legacy_holder(sessions_dir: &Path, session: &str) {
|
||||||
|
let server = env!("CARGO_BIN_EXE_dosh-server");
|
||||||
|
let runtime_dir = dosh::persist::ensure_runtime_dir(sessions_dir, session).unwrap();
|
||||||
|
let mut launcher = Command::new(server)
|
||||||
|
.arg("hold")
|
||||||
|
.arg("--runtime-dir")
|
||||||
|
.arg(&runtime_dir)
|
||||||
|
.arg("--session")
|
||||||
|
.arg(session)
|
||||||
|
.arg("--shell")
|
||||||
|
.arg("/bin/sh")
|
||||||
|
.arg("--cols")
|
||||||
|
.arg("80")
|
||||||
|
.arg("--rows")
|
||||||
|
.arg("24")
|
||||||
|
.stdout(Stdio::null())
|
||||||
|
.stderr(Stdio::null())
|
||||||
|
.spawn()
|
||||||
|
.unwrap();
|
||||||
|
let deadline = std::time::Instant::now() + Duration::from_secs(5);
|
||||||
|
while std::time::Instant::now() < deadline {
|
||||||
|
if holder_shell_pid(sessions_dir, session).is_some()
|
||||||
|
&& runtime_dir.join("holder.sock").exists()
|
||||||
|
{
|
||||||
|
let _ = launcher.wait();
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
if let Some(status) = launcher.try_wait().unwrap() {
|
||||||
|
panic!("legacy holder launcher exited before ready: {status}");
|
||||||
|
}
|
||||||
|
thread::sleep(Duration::from_millis(20));
|
||||||
|
}
|
||||||
|
let _ = launcher.kill();
|
||||||
|
let _ = launcher.wait();
|
||||||
|
panic!("legacy holder did not become ready");
|
||||||
|
}
|
||||||
|
|
||||||
/// Send one encrypted Input line and give the shell a moment to act.
|
/// Send one encrypted Input line and give the shell a moment to act.
|
||||||
fn type_line(socket: &UdpSocket, port: u16, ok: &AttachOk, key: &[u8; 32], seq: u64, line: &str) {
|
fn type_line(socket: &UdpSocket, port: u16, ok: &AttachOk, key: &[u8; 32], seq: u64, line: &str) {
|
||||||
let input = Input {
|
let input = Input {
|
||||||
@@ -2690,7 +2733,7 @@ fn session_survives_server_restart_same_shell_and_screen() {
|
|||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn implicit_session_survives_server_restart_for_same_ticket_holder() {
|
fn implicit_session_does_not_create_restart_holder() {
|
||||||
let dir = tempfile::tempdir().unwrap();
|
let dir = tempfile::tempdir().unwrap();
|
||||||
let sessions_dir = dir.path().join("sessions");
|
let sessions_dir = dir.path().join("sessions");
|
||||||
let port = free_udp_port();
|
let port = free_udp_port();
|
||||||
@@ -2713,20 +2756,14 @@ fn implicit_session_survives_server_restart_for_same_ticket_holder() {
|
|||||||
|
|
||||||
let shell_pid_before = holder_shell_pid(&sessions_dir, &session);
|
let shell_pid_before = holder_shell_pid(&sessions_dir, &session);
|
||||||
assert!(
|
assert!(
|
||||||
shell_pid_before.is_some(),
|
shell_pid_before.is_none(),
|
||||||
"implicit sessions should get a persistent holder when persistence is enabled"
|
"implicit sessions must not get persistent holders when persistence is enabled"
|
||||||
);
|
);
|
||||||
|
|
||||||
let _ = server.kill();
|
let _ = server.kill();
|
||||||
let _ = server.wait();
|
let _ = server.wait();
|
||||||
thread::sleep(Duration::from_millis(300));
|
thread::sleep(Duration::from_millis(300));
|
||||||
|
|
||||||
let pid = shell_pid_before.unwrap();
|
|
||||||
assert!(
|
|
||||||
unsafe { libc::kill(pid, 0) } == 0,
|
|
||||||
"implicit session shell pid {pid} must survive server restart"
|
|
||||||
);
|
|
||||||
|
|
||||||
let mut server = start_server(&dir, &config);
|
let mut server = start_server(&dir, &config);
|
||||||
let (socket2, bootstrap2, ok2) = direct_attach_session(&config, port, "read-write", &session);
|
let (socket2, bootstrap2, ok2) = direct_attach_session(&config, port, "read-write", &session);
|
||||||
let key2 = bootstrap2.session_key;
|
let key2 = bootstrap2.session_key;
|
||||||
@@ -2743,15 +2780,44 @@ fn implicit_session_survives_server_restart_for_same_ticket_holder() {
|
|||||||
|
|
||||||
let _ = server.kill();
|
let _ = server.kill();
|
||||||
let _ = server.wait();
|
let _ = server.wait();
|
||||||
kill_holder(&sessions_dir, &session);
|
|
||||||
|
|
||||||
assert_eq!(
|
assert!(
|
||||||
shell_pid_after, shell_pid_before,
|
shell_pid_after.is_none(),
|
||||||
"implicit session should re-adopt the same shell pid"
|
"implicit restart attach must stay ephemeral"
|
||||||
);
|
);
|
||||||
assert!(
|
assert!(
|
||||||
post.contains("IMPLICIT_MARK=implicit_restart_42"),
|
post.contains("IMPLICIT_MARK=") && !post.contains("implicit_restart_42"),
|
||||||
"implicit session state must survive restart, got {post:?}"
|
"implicit session must start fresh after server restart, got {post:?}"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn startup_discards_legacy_implicit_holders() {
|
||||||
|
let dir = tempfile::tempdir().unwrap();
|
||||||
|
let sessions_dir = dir.path().join("sessions");
|
||||||
|
let port = free_udp_port();
|
||||||
|
let config = write_persistent_server_config(&dir, port);
|
||||||
|
let session = protocol::generate_implicit_session_name();
|
||||||
|
|
||||||
|
spawn_legacy_holder(&sessions_dir, &session);
|
||||||
|
let shell_pid = holder_shell_pid(&sessions_dir, &session).expect("legacy holder shell pid");
|
||||||
|
assert!(
|
||||||
|
unsafe { libc::kill(shell_pid, 0) } == 0,
|
||||||
|
"legacy holder shell must be live before startup"
|
||||||
|
);
|
||||||
|
|
||||||
|
let mut server = start_server(&dir, &config);
|
||||||
|
thread::sleep(Duration::from_millis(300));
|
||||||
|
|
||||||
|
let _ = server.kill();
|
||||||
|
let _ = server.wait();
|
||||||
|
assert!(
|
||||||
|
holder_shell_pid(&sessions_dir, &session).is_none(),
|
||||||
|
"startup must remove old implicit holder metadata"
|
||||||
|
);
|
||||||
|
assert!(
|
||||||
|
unsafe { libc::kill(shell_pid, 0) } != 0,
|
||||||
|
"startup must shut down old implicit holder shell"
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -20,13 +20,33 @@ fn release_scripts_skip_stale_artifacts_when_auto_discovering() {
|
|||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn systemd_sandbox_allows_netlink_for_terminal_tools() {
|
fn systemd_service_does_not_sandbox_remote_shells() {
|
||||||
let service = include_str!("../packaging/systemd/dosh-server.service");
|
let service = include_str!("../packaging/systemd/dosh-server.service");
|
||||||
let install = include_str!("../install.sh");
|
let install = include_str!("../install.sh");
|
||||||
for raw in [service, install] {
|
for raw in [service, install] {
|
||||||
|
assert!(raw.contains("KillMode=process"));
|
||||||
assert!(
|
assert!(
|
||||||
raw.contains("RestrictAddressFamilies=AF_INET AF_INET6 AF_UNIX AF_NETLINK"),
|
raw.contains("Restart=always"),
|
||||||
"dosh sessions must allow AF_NETLINK so tools like btop can enumerate network interfaces"
|
"dosh-server should come back after accidental SIGTERM while preserving child shells"
|
||||||
|
);
|
||||||
|
for directive in [
|
||||||
|
"NoNewPrivileges=",
|
||||||
|
"PrivateTmp=",
|
||||||
|
"ProtectSystem=",
|
||||||
|
"ProtectHome=",
|
||||||
|
"RestrictAddressFamilies=",
|
||||||
|
"RestrictRealtime=",
|
||||||
|
"LockPersonality=",
|
||||||
|
"MemoryDenyWriteExecute=",
|
||||||
|
] {
|
||||||
|
assert!(
|
||||||
|
!raw.contains(directive),
|
||||||
|
"dosh sessions are user shells; systemd sandbox directive {directive} changes terminal/app behavior"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
assert!(
|
||||||
|
!raw.contains("ReadWritePaths="),
|
||||||
|
"remote shells must not be restricted to dosh config/data paths"
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user