Compare commits
12
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
e69be4fdf0 | ||
|
|
fdbd58b628 | ||
|
|
c65aba9d7a | ||
|
|
818b481154 | ||
|
|
70650e221b | ||
|
|
01e8870578 | ||
|
|
99d54899bd | ||
|
|
80e922957e | ||
|
|
1dcb33550e | ||
|
|
2c5b9ab30d | ||
|
|
bfe75dfbd2 | ||
|
|
4ea05fc14f |
Generated
+1
-1
@@ -436,7 +436,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "dosh"
|
name = "dosh"
|
||||||
version = "1.0.0-rc24"
|
version = "1.0.0-rc35"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"base64",
|
"base64",
|
||||||
|
|||||||
+1
-1
@@ -1,6 +1,6 @@
|
|||||||
[package]
|
[package]
|
||||||
name = "dosh"
|
name = "dosh"
|
||||||
version = "1.0.0-rc24"
|
version = "1.0.0-rc35"
|
||||||
edition = "2024"
|
edition = "2024"
|
||||||
license = "MIT"
|
license = "MIT"
|
||||||
|
|
||||||
|
|||||||
@@ -68,6 +68,31 @@ dosh restart HOST
|
|||||||
Agent forwarding is opt-in with `-A` and must also be enabled on the server.
|
Agent forwarding is opt-in with `-A` and must also be enabled on the server.
|
||||||
File copy must be enabled by the server config.
|
File copy must be enabled by the server config.
|
||||||
|
|
||||||
|
## Tracing
|
||||||
|
|
||||||
|
For terminal/reconnect bugs, run a client with:
|
||||||
|
|
||||||
|
```sh
|
||||||
|
dosh trace HOST
|
||||||
|
```
|
||||||
|
|
||||||
|
The client log path is printed before the session starts. To choose it:
|
||||||
|
|
||||||
|
```sh
|
||||||
|
dosh trace --client-log /tmp/dosh-client.log HOST
|
||||||
|
```
|
||||||
|
|
||||||
|
Summarize collected traces with:
|
||||||
|
|
||||||
|
```sh
|
||||||
|
dosh trace report HOST --client-log /tmp/dosh-client.log
|
||||||
|
```
|
||||||
|
|
||||||
|
When `HOST` is given, Dosh fetches `/tmp/dosh-server.log` over SSH before
|
||||||
|
building the report. Set `DOSH_TRACE=/tmp/dosh-server.log` on `dosh-server` for
|
||||||
|
matching server events. Trace byte prefixes are enabled for `dosh trace`, so use
|
||||||
|
it only for short reproductions.
|
||||||
|
|
||||||
## VS Code
|
## VS Code
|
||||||
|
|
||||||
Dosh can carry VS Code Remote-SSH through its transport:
|
Dosh can carry VS Code Remote-SSH through its transport:
|
||||||
@@ -108,6 +133,10 @@ dosh_host = "prod.example.com"
|
|||||||
port = 50000
|
port = 50000
|
||||||
```
|
```
|
||||||
|
|
||||||
|
`ProxyJump` and `ProxyCommand` can be used for SSH setup, but the Dosh UDP
|
||||||
|
endpoint still has to be reachable directly from the client. Set `dosh_host` to
|
||||||
|
the reachable UDP hostname or IP when it differs from the SSH alias target.
|
||||||
|
|
||||||
## Rust Library
|
## Rust Library
|
||||||
|
|
||||||
Dosh exposes a Rust transport for encrypted, reconnecting application streams.
|
Dosh exposes a Rust transport for encrypted, reconnecting application streams.
|
||||||
|
|||||||
+1892
-91
File diff suppressed because it is too large
Load Diff
+197
-44
@@ -67,6 +67,15 @@ static AGENT_SOCK_COUNTER: AtomicU64 = AtomicU64::new(0);
|
|||||||
/// before it is swept by the cleanup task.
|
/// before it is swept by the cleanup task.
|
||||||
const NATIVE_HANDSHAKE_TTL_SECS: u64 = 30;
|
const NATIVE_HANDSHAKE_TTL_SECS: u64 = 30;
|
||||||
|
|
||||||
|
fn hex_id(id: [u8; 16]) -> String {
|
||||||
|
let mut out = String::with_capacity(32);
|
||||||
|
for byte in id {
|
||||||
|
use std::fmt::Write as _;
|
||||||
|
let _ = write!(&mut out, "{byte:02x}");
|
||||||
|
}
|
||||||
|
out
|
||||||
|
}
|
||||||
|
|
||||||
#[derive(Debug, Parser)]
|
#[derive(Debug, Parser)]
|
||||||
#[command(
|
#[command(
|
||||||
name = "dosh-server",
|
name = "dosh-server",
|
||||||
@@ -1602,9 +1611,22 @@ async fn handle_resume(
|
|||||||
peer: SocketAddr,
|
peer: SocketAddr,
|
||||||
packet: &protocol::Packet,
|
packet: &protocol::Packet,
|
||||||
) -> Result<()> {
|
) -> Result<()> {
|
||||||
|
dosh::trace::event(
|
||||||
|
"server.resume_start",
|
||||||
|
&[
|
||||||
|
("peer", peer.to_string()),
|
||||||
|
("client", hex_id(packet.header.conn_id)),
|
||||||
|
("seq", packet.header.seq.to_string()),
|
||||||
|
("ack", packet.header.ack.to_string()),
|
||||||
|
],
|
||||||
|
);
|
||||||
let (key, session_name) = match find_client_decrypt_key(state, &packet.header) {
|
let (key, session_name) = match find_client_decrypt_key(state, &packet.header) {
|
||||||
Ok(found) => found,
|
Ok(found) => found,
|
||||||
Err(_) => {
|
Err(_) => {
|
||||||
|
dosh::trace::event(
|
||||||
|
"server.resume_unknown_client",
|
||||||
|
&[("client", hex_id(packet.header.conn_id))],
|
||||||
|
);
|
||||||
return send_reject_to_client(socket, peer, packet.header.conn_id, "unknown client")
|
return send_reject_to_client(socket, peer, packet.header.conn_id, "unknown client")
|
||||||
.await;
|
.await;
|
||||||
}
|
}
|
||||||
@@ -1623,8 +1645,25 @@ async fn handle_resume(
|
|||||||
.get_mut(&packet.header.conn_id)
|
.get_mut(&packet.header.conn_id)
|
||||||
.ok_or_else(|| anyhow!("unknown client"))?;
|
.ok_or_else(|| anyhow!("unknown client"))?;
|
||||||
if !client.replay.accept(packet.header.seq) {
|
if !client.replay.accept(packet.header.seq) {
|
||||||
|
dosh::trace::event(
|
||||||
|
"server.resume_replay_drop",
|
||||||
|
&[
|
||||||
|
("session", req.session.clone()),
|
||||||
|
("seq", packet.header.seq.to_string()),
|
||||||
|
],
|
||||||
|
);
|
||||||
return Ok(());
|
return Ok(());
|
||||||
}
|
}
|
||||||
|
if client.endpoint != peer {
|
||||||
|
dosh::trace::event(
|
||||||
|
"server.resume_roam",
|
||||||
|
&[
|
||||||
|
("session", req.session.clone()),
|
||||||
|
("from", client.endpoint.to_string()),
|
||||||
|
("to", peer.to_string()),
|
||||||
|
],
|
||||||
|
);
|
||||||
|
}
|
||||||
client.endpoint = peer;
|
client.endpoint = peer;
|
||||||
client.last_acked = req.last_rendered_seq;
|
client.last_acked = req.last_rendered_seq;
|
||||||
client.cols = req.cols;
|
client.cols = req.cols;
|
||||||
@@ -1662,6 +1701,14 @@ async fn handle_resume(
|
|||||||
&body,
|
&body,
|
||||||
)?;
|
)?;
|
||||||
let _ = send_udp(socket, &out, peer).await?;
|
let _ = send_udp(socket, &out, peer).await?;
|
||||||
|
dosh::trace::event(
|
||||||
|
"server.resume_ok",
|
||||||
|
&[
|
||||||
|
("session", frame.session),
|
||||||
|
("output_seq", frame.output_seq.to_string()),
|
||||||
|
("bytes", frame.bytes.len().to_string()),
|
||||||
|
],
|
||||||
|
);
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1673,6 +1720,7 @@ async fn handle_input(
|
|||||||
let (key, session_name) = find_client_decrypt_key(state, &packet.header)?;
|
let (key, session_name) = find_client_decrypt_key(state, &packet.header)?;
|
||||||
let body = protocol::decrypt_body(packet, &key, CLIENT_TO_SERVER)?;
|
let body = protocol::decrypt_body(packet, &key, CLIENT_TO_SERVER)?;
|
||||||
let input: Input = protocol::from_body(&body)?;
|
let input: Input = protocol::from_body(&body)?;
|
||||||
|
let input_summary = dosh::trace::bytes_summary(&input.bytes);
|
||||||
let mut locked = state.lock().expect("server state poisoned");
|
let mut locked = state.lock().expect("server state poisoned");
|
||||||
let session = locked
|
let session = locked
|
||||||
.sessions
|
.sessions
|
||||||
@@ -1683,13 +1731,37 @@ async fn handle_input(
|
|||||||
.get_mut(&packet.header.conn_id)
|
.get_mut(&packet.header.conn_id)
|
||||||
.ok_or_else(|| anyhow!("unknown client"))?;
|
.ok_or_else(|| anyhow!("unknown client"))?;
|
||||||
if !client.replay.accept(packet.header.seq) {
|
if !client.replay.accept(packet.header.seq) {
|
||||||
|
dosh::trace::event(
|
||||||
|
"server.input_replay_drop",
|
||||||
|
&[
|
||||||
|
("session", session_name.clone()),
|
||||||
|
("seq", packet.header.seq.to_string()),
|
||||||
|
("summary", input_summary),
|
||||||
|
],
|
||||||
|
);
|
||||||
return Ok(());
|
return Ok(());
|
||||||
}
|
}
|
||||||
if client.endpoint != peer {
|
if client.endpoint != peer {
|
||||||
|
dosh::trace::event(
|
||||||
|
"server.input_roam",
|
||||||
|
&[
|
||||||
|
("session", session_name.clone()),
|
||||||
|
("from", client.endpoint.to_string()),
|
||||||
|
("to", peer.to_string()),
|
||||||
|
],
|
||||||
|
);
|
||||||
client.endpoint = peer;
|
client.endpoint = peer;
|
||||||
}
|
}
|
||||||
client.last_seen = Instant::now();
|
client.last_seen = Instant::now();
|
||||||
if !mode_allows_terminal_updates(&client.mode) {
|
if !mode_allows_terminal_updates(&client.mode) {
|
||||||
|
dosh::trace::event(
|
||||||
|
"server.input_rejected_mode",
|
||||||
|
&[
|
||||||
|
("session", session_name),
|
||||||
|
("mode", client.mode.clone()),
|
||||||
|
("summary", input_summary),
|
||||||
|
],
|
||||||
|
);
|
||||||
return Ok(());
|
return Ok(());
|
||||||
}
|
}
|
||||||
session
|
session
|
||||||
@@ -1697,6 +1769,14 @@ async fn handle_input(
|
|||||||
.as_ref()
|
.as_ref()
|
||||||
.context("terminal session has no pty")?
|
.context("terminal session has no pty")?
|
||||||
.write_all(&input.bytes)?;
|
.write_all(&input.bytes)?;
|
||||||
|
dosh::trace::event(
|
||||||
|
"server.pty_write",
|
||||||
|
&[
|
||||||
|
("session", session_name),
|
||||||
|
("seq", packet.header.seq.to_string()),
|
||||||
|
("summary", input_summary),
|
||||||
|
],
|
||||||
|
);
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -2566,8 +2646,10 @@ struct UploadState {
|
|||||||
hasher: Sha256,
|
hasher: Sha256,
|
||||||
written: u64,
|
written: u64,
|
||||||
expected_size: u64,
|
expected_size: u64,
|
||||||
|
mode: Option<u32>,
|
||||||
modified_secs: Option<u64>,
|
modified_secs: Option<u64>,
|
||||||
atomic: bool,
|
atomic: bool,
|
||||||
|
original_len: Option<u64>,
|
||||||
}
|
}
|
||||||
|
|
||||||
async fn run_file_stream_service(
|
async fn run_file_stream_service(
|
||||||
@@ -2679,6 +2761,46 @@ async fn handle_file_request(
|
|||||||
send_file_response_to_client(state, socket, client_id, stream_id, FileResponse::Ok)
|
send_file_response_to_client(state, socket, client_id, stream_id, FileResponse::Ok)
|
||||||
.await
|
.await
|
||||||
}
|
}
|
||||||
|
FileRequest::Readlink { path } => {
|
||||||
|
let path = clean_remote_path(&path, home)?;
|
||||||
|
let target =
|
||||||
|
fs::read_link(&path).with_context(|| format!("readlink {}", path.display()))?;
|
||||||
|
let target = target
|
||||||
|
.to_str()
|
||||||
|
.ok_or_else(|| anyhow!("symlink target is not valid UTF-8"))?
|
||||||
|
.to_string();
|
||||||
|
send_file_response_to_client(
|
||||||
|
state,
|
||||||
|
socket,
|
||||||
|
client_id,
|
||||||
|
stream_id,
|
||||||
|
FileResponse::LinkTarget { target },
|
||||||
|
)
|
||||||
|
.await
|
||||||
|
}
|
||||||
|
FileRequest::Symlink {
|
||||||
|
path,
|
||||||
|
target,
|
||||||
|
overwrite,
|
||||||
|
} => {
|
||||||
|
let path = clean_remote_path(&path, home)?;
|
||||||
|
if let Some(parent) = path.parent() {
|
||||||
|
fs::create_dir_all(parent)
|
||||||
|
.with_context(|| format!("create {}", parent.display()))?;
|
||||||
|
}
|
||||||
|
if let Ok(metadata) = fs::symlink_metadata(&path) {
|
||||||
|
anyhow::ensure!(overwrite, "destination exists: {}", path.display());
|
||||||
|
anyhow::ensure!(
|
||||||
|
!metadata.is_dir(),
|
||||||
|
"destination is a directory: {}",
|
||||||
|
path.display()
|
||||||
|
);
|
||||||
|
fs::remove_file(&path).with_context(|| format!("remove {}", path.display()))?;
|
||||||
|
}
|
||||||
|
create_symlink(&target, &path)?;
|
||||||
|
send_file_response_to_client(state, socket, client_id, stream_id, FileResponse::Ok)
|
||||||
|
.await
|
||||||
|
}
|
||||||
FileRequest::Remove { path, recursive } => {
|
FileRequest::Remove { path, recursive } => {
|
||||||
let path = clean_remote_path(&path, home)?;
|
let path = clean_remote_path(&path, home)?;
|
||||||
let metadata =
|
let metadata =
|
||||||
@@ -2716,31 +2838,41 @@ async fn handle_file_request(
|
|||||||
bail!("destination exists: {}", final_path.display());
|
bail!("destination exists: {}", final_path.display());
|
||||||
}
|
}
|
||||||
let mut hasher = Sha256::new();
|
let mut hasher = Sha256::new();
|
||||||
let (file, temp_path, written, atomic) = if resume && final_path.exists() {
|
let (file, temp_path, written, atomic, original_len, prefix_sha256) =
|
||||||
let mut file = fs::OpenOptions::new()
|
if resume && final_path.exists() {
|
||||||
.read(true)
|
let original_len = fs::metadata(&final_path)
|
||||||
.append(true)
|
.with_context(|| format!("stat {}", final_path.display()))?
|
||||||
.open(&final_path)
|
.len();
|
||||||
.with_context(|| format!("open {}", final_path.display()))?;
|
let written = original_len.min(size);
|
||||||
let written = file.metadata()?.len().min(size);
|
if written > 0 {
|
||||||
file.set_len(written)
|
let mut prefix = fs::File::open(&final_path)?;
|
||||||
.with_context(|| format!("truncate {}", final_path.display()))?;
|
hash_exact_prefix(&mut prefix, written, &mut hasher)?;
|
||||||
if written > 0 {
|
}
|
||||||
let mut prefix = fs::File::open(&final_path)?;
|
let prefix_sha256 = (written > 0).then(|| hasher.clone().finalize().into());
|
||||||
hash_exact_prefix(&mut prefix, written, &mut hasher)?;
|
let mut file = fs::OpenOptions::new()
|
||||||
}
|
.read(true)
|
||||||
file.seek(SeekFrom::Start(written))?;
|
.append(true)
|
||||||
(file, None, written, false)
|
.open(&final_path)
|
||||||
} else {
|
.with_context(|| format!("open {}", final_path.display()))?;
|
||||||
let temp_path = upload_temp_path(&final_path, stream_id);
|
file.seek(SeekFrom::Start(written))?;
|
||||||
let file = fs::OpenOptions::new()
|
(
|
||||||
.create(true)
|
file,
|
||||||
.truncate(true)
|
None,
|
||||||
.write(true)
|
written,
|
||||||
.open(&temp_path)
|
false,
|
||||||
.with_context(|| format!("create {}", temp_path.display()))?;
|
Some(original_len),
|
||||||
(file, Some(temp_path), 0, true)
|
prefix_sha256,
|
||||||
};
|
)
|
||||||
|
} else {
|
||||||
|
let temp_path = upload_temp_path(&final_path, stream_id);
|
||||||
|
let file = fs::OpenOptions::new()
|
||||||
|
.create(true)
|
||||||
|
.truncate(true)
|
||||||
|
.write(true)
|
||||||
|
.open(&temp_path)
|
||||||
|
.with_context(|| format!("create {}", temp_path.display()))?;
|
||||||
|
(file, Some(temp_path), 0, true, None, None)
|
||||||
|
};
|
||||||
*upload = Some(UploadState {
|
*upload = Some(UploadState {
|
||||||
final_path,
|
final_path,
|
||||||
temp_path,
|
temp_path,
|
||||||
@@ -2748,26 +2880,20 @@ async fn handle_file_request(
|
|||||||
hasher,
|
hasher,
|
||||||
written,
|
written,
|
||||||
expected_size: size,
|
expected_size: size,
|
||||||
|
mode,
|
||||||
modified_secs,
|
modified_secs,
|
||||||
atomic,
|
atomic,
|
||||||
|
original_len,
|
||||||
});
|
});
|
||||||
if let Some(mode) = mode {
|
|
||||||
let Some(active_upload) = upload.as_ref() else {
|
|
||||||
return Err(anyhow!("upload state missing after start"));
|
|
||||||
};
|
|
||||||
let target = active_upload
|
|
||||||
.temp_path
|
|
||||||
.as_ref()
|
|
||||||
.unwrap_or(&active_upload.final_path)
|
|
||||||
.clone();
|
|
||||||
set_mode(&target, mode)?;
|
|
||||||
}
|
|
||||||
send_file_response_to_client(
|
send_file_response_to_client(
|
||||||
state,
|
state,
|
||||||
socket,
|
socket,
|
||||||
client_id,
|
client_id,
|
||||||
stream_id,
|
stream_id,
|
||||||
FileResponse::Resume { offset: written },
|
FileResponse::Resume {
|
||||||
|
offset: written,
|
||||||
|
prefix_sha256,
|
||||||
|
},
|
||||||
)
|
)
|
||||||
.await
|
.await
|
||||||
}
|
}
|
||||||
@@ -2789,8 +2915,6 @@ async fn handle_file_request(
|
|||||||
let Some(mut active) = upload.take() else {
|
let Some(mut active) = upload.take() else {
|
||||||
bail!("no upload in progress");
|
bail!("no upload in progress");
|
||||||
};
|
};
|
||||||
active.file.flush()?;
|
|
||||||
active.file.sync_all()?;
|
|
||||||
anyhow::ensure!(
|
anyhow::ensure!(
|
||||||
active.written == active.expected_size,
|
active.written == active.expected_size,
|
||||||
"upload size mismatch: got {}, expected {}",
|
"upload size mismatch: got {}, expected {}",
|
||||||
@@ -2801,9 +2925,17 @@ async fn handle_file_request(
|
|||||||
if digest != sha256 {
|
if digest != sha256 {
|
||||||
if let Some(temp_path) = &active.temp_path {
|
if let Some(temp_path) = &active.temp_path {
|
||||||
let _ = fs::remove_file(temp_path);
|
let _ = fs::remove_file(temp_path);
|
||||||
|
} else if let Some(original_len) = active.original_len {
|
||||||
|
let _ = active.file.set_len(original_len);
|
||||||
}
|
}
|
||||||
bail!("upload checksum mismatch");
|
bail!("upload checksum mismatch");
|
||||||
}
|
}
|
||||||
|
active
|
||||||
|
.file
|
||||||
|
.set_len(active.expected_size)
|
||||||
|
.with_context(|| format!("truncate {}", active.final_path.display()))?;
|
||||||
|
active.file.flush()?;
|
||||||
|
active.file.sync_all()?;
|
||||||
drop(active.file);
|
drop(active.file);
|
||||||
if active.atomic
|
if active.atomic
|
||||||
&& let Some(temp_path) = active.temp_path.take()
|
&& let Some(temp_path) = active.temp_path.take()
|
||||||
@@ -2816,6 +2948,9 @@ async fn handle_file_request(
|
|||||||
)
|
)
|
||||||
})?;
|
})?;
|
||||||
}
|
}
|
||||||
|
if let Some(mode) = active.mode {
|
||||||
|
set_mode(&active.final_path, mode)?;
|
||||||
|
}
|
||||||
if let Some(modified_secs) = active.modified_secs {
|
if let Some(modified_secs) = active.modified_secs {
|
||||||
filetime::set_file_mtime(
|
filetime::set_file_mtime(
|
||||||
&active.final_path,
|
&active.final_path,
|
||||||
@@ -2843,9 +2978,20 @@ async fn handle_file_request(
|
|||||||
"remote path is not a file: {}",
|
"remote path is not a file: {}",
|
||||||
meta.path
|
meta.path
|
||||||
);
|
);
|
||||||
|
anyhow::ensure!(
|
||||||
|
offset <= meta.len,
|
||||||
|
"download offset {offset} is beyond file size {}",
|
||||||
|
meta.len
|
||||||
|
);
|
||||||
let mut file =
|
let mut file =
|
||||||
fs::File::open(&path).with_context(|| format!("open {}", path.display()))?;
|
fs::File::open(&path).with_context(|| format!("open {}", path.display()))?;
|
||||||
file.seek(SeekFrom::Start(offset))?;
|
file.seek(SeekFrom::Start(offset))?;
|
||||||
|
let mut hasher = Sha256::new();
|
||||||
|
if offset > 0 {
|
||||||
|
let mut prefix = fs::File::open(&path)?;
|
||||||
|
hash_exact_prefix(&mut prefix, offset, &mut hasher)?;
|
||||||
|
}
|
||||||
|
let prefix_sha256 = (offset > 0).then(|| hasher.clone().finalize().into());
|
||||||
send_file_response_to_client(
|
send_file_response_to_client(
|
||||||
state,
|
state,
|
||||||
socket,
|
socket,
|
||||||
@@ -2854,14 +3000,10 @@ async fn handle_file_request(
|
|||||||
FileResponse::Start {
|
FileResponse::Start {
|
||||||
meta: meta.clone(),
|
meta: meta.clone(),
|
||||||
offset,
|
offset,
|
||||||
|
prefix_sha256,
|
||||||
},
|
},
|
||||||
)
|
)
|
||||||
.await?;
|
.await?;
|
||||||
let mut hasher = Sha256::new();
|
|
||||||
if offset > 0 {
|
|
||||||
let mut prefix = fs::File::open(&path)?;
|
|
||||||
hash_exact_prefix(&mut prefix, offset, &mut hasher)?;
|
|
||||||
}
|
|
||||||
let mut sent = offset;
|
let mut sent = offset;
|
||||||
let mut buf = vec![0u8; CHUNK_SIZE];
|
let mut buf = vec![0u8; CHUNK_SIZE];
|
||||||
loop {
|
loop {
|
||||||
@@ -3043,6 +3185,17 @@ fn set_mode(path: &Path, mode: u32) -> Result<()> {
|
|||||||
fs::set_permissions(path, permissions).with_context(|| format!("chmod {}", path.display()))
|
fs::set_permissions(path, permissions).with_context(|| format!("chmod {}", path.display()))
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[cfg(unix)]
|
||||||
|
fn create_symlink(target: &str, path: &Path) -> Result<()> {
|
||||||
|
std::os::unix::fs::symlink(target, path)
|
||||||
|
.with_context(|| format!("symlink {} -> {}", path.display(), target))
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(not(unix))]
|
||||||
|
fn create_symlink(_target: &str, _path: &Path) -> Result<()> {
|
||||||
|
bail!("symlink creation is not supported on this server platform")
|
||||||
|
}
|
||||||
|
|
||||||
fn upload_temp_path(final_path: &Path, stream_id: u64) -> PathBuf {
|
fn upload_temp_path(final_path: &Path, stream_id: u64) -> PathBuf {
|
||||||
let name = final_path
|
let name = final_path
|
||||||
.file_name()
|
.file_name()
|
||||||
|
|||||||
+37
-7
@@ -18,6 +18,14 @@ pub enum FileRequest {
|
|||||||
path: String,
|
path: String,
|
||||||
mode: Option<u32>,
|
mode: Option<u32>,
|
||||||
},
|
},
|
||||||
|
Readlink {
|
||||||
|
path: String,
|
||||||
|
},
|
||||||
|
Symlink {
|
||||||
|
path: String,
|
||||||
|
target: String,
|
||||||
|
overwrite: bool,
|
||||||
|
},
|
||||||
Remove {
|
Remove {
|
||||||
path: String,
|
path: String,
|
||||||
recursive: bool,
|
recursive: bool,
|
||||||
@@ -46,13 +54,35 @@ pub enum FileRequest {
|
|||||||
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
|
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
|
||||||
pub enum FileResponse {
|
pub enum FileResponse {
|
||||||
Ok,
|
Ok,
|
||||||
Resume { offset: u64 },
|
Resume {
|
||||||
Stat { meta: FileMeta },
|
offset: u64,
|
||||||
List { entries: Vec<FileEntry> },
|
prefix_sha256: Option<[u8; 32]>,
|
||||||
Start { meta: FileMeta, offset: u64 },
|
},
|
||||||
Chunk { offset: u64, bytes: Vec<u8> },
|
Stat {
|
||||||
Done { sha256: [u8; 32], bytes: u64 },
|
meta: FileMeta,
|
||||||
Error { message: String },
|
},
|
||||||
|
List {
|
||||||
|
entries: Vec<FileEntry>,
|
||||||
|
},
|
||||||
|
LinkTarget {
|
||||||
|
target: String,
|
||||||
|
},
|
||||||
|
Start {
|
||||||
|
meta: FileMeta,
|
||||||
|
offset: u64,
|
||||||
|
prefix_sha256: Option<[u8; 32]>,
|
||||||
|
},
|
||||||
|
Chunk {
|
||||||
|
offset: u64,
|
||||||
|
bytes: Vec<u8>,
|
||||||
|
},
|
||||||
|
Done {
|
||||||
|
sha256: [u8; 32],
|
||||||
|
bytes: u64,
|
||||||
|
},
|
||||||
|
Error {
|
||||||
|
message: String,
|
||||||
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
|
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
|
||||||
|
|||||||
@@ -22,5 +22,6 @@ pub mod protocol;
|
|||||||
pub mod pty;
|
pub mod pty;
|
||||||
pub mod server;
|
pub mod server;
|
||||||
pub mod ssh_agent;
|
pub mod ssh_agent;
|
||||||
|
pub mod trace;
|
||||||
pub mod transport;
|
pub mod transport;
|
||||||
pub mod udp;
|
pub mod udp;
|
||||||
|
|||||||
+161
@@ -0,0 +1,161 @@
|
|||||||
|
use std::fs::{File, OpenOptions};
|
||||||
|
use std::io::Write;
|
||||||
|
use std::path::PathBuf;
|
||||||
|
use std::sync::{Mutex, OnceLock};
|
||||||
|
use std::time::{SystemTime, UNIX_EPOCH};
|
||||||
|
|
||||||
|
static TRACE_FILE: OnceLock<Option<Mutex<File>>> = OnceLock::new();
|
||||||
|
static TRACE_BYTES: OnceLock<bool> = OnceLock::new();
|
||||||
|
|
||||||
|
pub fn enabled() -> bool {
|
||||||
|
TRACE_FILE.get_or_init(open_trace_file).is_some()
|
||||||
|
}
|
||||||
|
|
||||||
|
pub fn bytes_enabled() -> bool {
|
||||||
|
*TRACE_BYTES.get_or_init(|| truthy_env("DOSH_TRACE_BYTES"))
|
||||||
|
}
|
||||||
|
|
||||||
|
pub fn event(name: &str, fields: &[(&str, String)]) {
|
||||||
|
let Some(file) = TRACE_FILE.get_or_init(open_trace_file) else {
|
||||||
|
return;
|
||||||
|
};
|
||||||
|
let now = SystemTime::now()
|
||||||
|
.duration_since(UNIX_EPOCH)
|
||||||
|
.map(|duration| duration.as_millis())
|
||||||
|
.unwrap_or(0);
|
||||||
|
let mut line = format!(
|
||||||
|
"ts_ms={} pid={} event={}",
|
||||||
|
now,
|
||||||
|
std::process::id(),
|
||||||
|
shell_escape(name)
|
||||||
|
);
|
||||||
|
for (key, value) in fields {
|
||||||
|
line.push(' ');
|
||||||
|
line.push_str(key);
|
||||||
|
line.push('=');
|
||||||
|
line.push_str(&shell_escape(value));
|
||||||
|
}
|
||||||
|
line.push('\n');
|
||||||
|
if let Ok(mut file) = file.lock() {
|
||||||
|
let _ = file.write_all(line.as_bytes());
|
||||||
|
let _ = file.flush();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
pub fn bytes_summary(bytes: &[u8]) -> String {
|
||||||
|
let mut parts = vec![
|
||||||
|
format!("len={}", bytes.len()),
|
||||||
|
format!(
|
||||||
|
"esc={}",
|
||||||
|
contains_byte(bytes, 0x1b) || contains_byte(bytes, 0x9b)
|
||||||
|
),
|
||||||
|
format!("focus={}", has_focus_report(bytes)),
|
||||||
|
format!("mouseish={}", looks_mouseish(bytes)),
|
||||||
|
format!("printable={}", printable_count(bytes)),
|
||||||
|
];
|
||||||
|
if bytes_enabled() {
|
||||||
|
parts.push(format!("hex={}", hex_prefix(bytes, 160)));
|
||||||
|
}
|
||||||
|
parts.join(",")
|
||||||
|
}
|
||||||
|
|
||||||
|
fn open_trace_file() -> Option<Mutex<File>> {
|
||||||
|
let raw = std::env::var_os("DOSH_TRACE")?;
|
||||||
|
let normalized = raw.to_string_lossy().to_ascii_lowercase();
|
||||||
|
if normalized.is_empty() || matches!(normalized.as_str(), "0" | "false" | "off") {
|
||||||
|
return None;
|
||||||
|
}
|
||||||
|
let path = if matches!(normalized.as_str(), "1" | "true" | "on") {
|
||||||
|
default_trace_path()
|
||||||
|
} else {
|
||||||
|
PathBuf::from(raw)
|
||||||
|
};
|
||||||
|
if let Some(parent) = path.parent() {
|
||||||
|
let _ = std::fs::create_dir_all(parent);
|
||||||
|
}
|
||||||
|
OpenOptions::new()
|
||||||
|
.create(true)
|
||||||
|
.append(true)
|
||||||
|
.open(&path)
|
||||||
|
.ok()
|
||||||
|
.map(Mutex::new)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn default_trace_path() -> PathBuf {
|
||||||
|
let root = dirs::cache_dir()
|
||||||
|
.unwrap_or_else(std::env::temp_dir)
|
||||||
|
.join("dosh")
|
||||||
|
.join("trace");
|
||||||
|
let exe = std::env::current_exe()
|
||||||
|
.ok()
|
||||||
|
.and_then(|path| {
|
||||||
|
path.file_stem()
|
||||||
|
.map(|stem| stem.to_string_lossy().to_string())
|
||||||
|
})
|
||||||
|
.unwrap_or_else(|| "dosh".to_string());
|
||||||
|
root.join(format!("{}-{}.log", exe, std::process::id()))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn truthy_env(name: &str) -> bool {
|
||||||
|
std::env::var_os(name).is_some_and(|value| {
|
||||||
|
let normalized = value.to_string_lossy().to_ascii_lowercase();
|
||||||
|
!normalized.is_empty() && !matches!(normalized.as_str(), "0" | "false" | "off")
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
fn shell_escape(value: &str) -> String {
|
||||||
|
if value.bytes().all(|byte| {
|
||||||
|
byte.is_ascii_alphanumeric()
|
||||||
|
|| matches!(byte, b'.' | b'-' | b'_' | b':' | b'/' | b',' | b'=')
|
||||||
|
}) {
|
||||||
|
return value.to_string();
|
||||||
|
}
|
||||||
|
let mut out = String::from("'");
|
||||||
|
for ch in value.chars() {
|
||||||
|
if ch == '\'' {
|
||||||
|
out.push_str("'\\''");
|
||||||
|
} else {
|
||||||
|
out.push(ch);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
out.push('\'');
|
||||||
|
out
|
||||||
|
}
|
||||||
|
|
||||||
|
fn contains_byte(bytes: &[u8], needle: u8) -> bool {
|
||||||
|
bytes.contains(&needle)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn has_focus_report(bytes: &[u8]) -> bool {
|
||||||
|
bytes
|
||||||
|
.windows(3)
|
||||||
|
.any(|window| matches!(window, b"\x1b[I" | b"\x1b[O"))
|
||||||
|
|| bytes
|
||||||
|
.windows(2)
|
||||||
|
.any(|window| matches!(window, b"\x9bI" | b"\x9bO"))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn looks_mouseish(bytes: &[u8]) -> bool {
|
||||||
|
bytes.windows(3).any(|window| window == b"\x1b[<")
|
||||||
|
|| bytes.windows(2).any(|window| window == b"\x9b<")
|
||||||
|
|| bytes.iter().filter(|byte| **byte == b';').take(3).count() >= 2
|
||||||
|
}
|
||||||
|
|
||||||
|
fn printable_count(bytes: &[u8]) -> usize {
|
||||||
|
bytes
|
||||||
|
.iter()
|
||||||
|
.filter(|byte| byte.is_ascii_graphic() || **byte == b' ')
|
||||||
|
.count()
|
||||||
|
}
|
||||||
|
|
||||||
|
fn hex_prefix(bytes: &[u8], max: usize) -> String {
|
||||||
|
let mut out = String::with_capacity(bytes.len().min(max) * 2);
|
||||||
|
for byte in bytes.iter().take(max) {
|
||||||
|
use std::fmt::Write as _;
|
||||||
|
let _ = write!(&mut out, "{byte:02x}");
|
||||||
|
}
|
||||||
|
if bytes.len() > max {
|
||||||
|
out.push_str("...");
|
||||||
|
}
|
||||||
|
out
|
||||||
|
}
|
||||||
@@ -3,6 +3,7 @@
|
|||||||
use std::fs;
|
use std::fs;
|
||||||
use std::io::{Read, Write};
|
use std::io::{Read, Write};
|
||||||
use std::net::{TcpListener, TcpStream, UdpSocket};
|
use std::net::{TcpListener, TcpStream, UdpSocket};
|
||||||
|
use std::os::unix::fs::PermissionsExt;
|
||||||
use std::os::unix::net::{UnixListener, UnixStream};
|
use std::os::unix::net::{UnixListener, UnixStream};
|
||||||
use std::path::{Path, PathBuf};
|
use std::path::{Path, PathBuf};
|
||||||
use std::process::{Child, Command, Stdio};
|
use std::process::{Child, Command, Stdio};
|
||||||
@@ -1002,6 +1003,8 @@ fn native_file_copy_recursive_round_trip() {
|
|||||||
fs::create_dir_all(src.join("nested")).unwrap();
|
fs::create_dir_all(src.join("nested")).unwrap();
|
||||||
fs::write(src.join("root.txt"), b"root file\n").unwrap();
|
fs::write(src.join("root.txt"), b"root file\n").unwrap();
|
||||||
fs::write(src.join("nested/child.txt"), b"child file\n").unwrap();
|
fs::write(src.join("nested/child.txt"), b"child file\n").unwrap();
|
||||||
|
std::os::unix::fs::symlink("root.txt", src.join("root-link")).unwrap();
|
||||||
|
std::os::unix::fs::symlink("nested/child.txt", src.join("child-link")).unwrap();
|
||||||
|
|
||||||
let client_bin = env!("CARGO_BIN_EXE_dosh-client");
|
let client_bin = env!("CARGO_BIN_EXE_dosh-client");
|
||||||
let upload = Command::new(client_bin)
|
let upload = Command::new(client_bin)
|
||||||
@@ -1107,6 +1110,14 @@ fn native_file_copy_recursive_round_trip() {
|
|||||||
fs::read_to_string(downloaded.join("nested/child.txt")).unwrap(),
|
fs::read_to_string(downloaded.join("nested/child.txt")).unwrap(),
|
||||||
"child file\n"
|
"child file\n"
|
||||||
);
|
);
|
||||||
|
assert_eq!(
|
||||||
|
fs::read_link(downloaded.join("root-link")).unwrap(),
|
||||||
|
PathBuf::from("root.txt")
|
||||||
|
);
|
||||||
|
assert_eq!(
|
||||||
|
fs::read_link(downloaded.join("child-link")).unwrap(),
|
||||||
|
PathBuf::from("nested/child.txt")
|
||||||
|
);
|
||||||
|
|
||||||
let remove = Command::new(client_bin)
|
let remove = Command::new(client_bin)
|
||||||
.arg("--dosh-host")
|
.arg("--dosh-host")
|
||||||
@@ -1241,6 +1252,80 @@ fn native_file_copy_resume_truncates_oversized_destinations() {
|
|||||||
let _ = server.wait();
|
let _ = server.wait();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn native_file_copy_resume_prefix_mismatch_preserves_destinations() {
|
||||||
|
let dir = tempfile::tempdir().unwrap();
|
||||||
|
let port = free_udp_port();
|
||||||
|
let config = write_server_config(&dir, port);
|
||||||
|
write_native_client_auth(&dir, &config);
|
||||||
|
let mut server = start_server(&dir, &config);
|
||||||
|
let client_bin = env!("CARGO_BIN_EXE_dosh-client");
|
||||||
|
|
||||||
|
let local_upload = dir.path().join("upload-prefix.txt");
|
||||||
|
let remote_upload = dir.path().join("remote-upload.txt");
|
||||||
|
fs::write(&local_upload, b"local-prefix\n").unwrap();
|
||||||
|
fs::write(&remote_upload, b"remote-prefix-with-tail\n").unwrap();
|
||||||
|
fs::set_permissions(&local_upload, fs::Permissions::from_mode(0o755)).unwrap();
|
||||||
|
fs::set_permissions(&remote_upload, fs::Permissions::from_mode(0o600)).unwrap();
|
||||||
|
|
||||||
|
let bad_upload_resume = Command::new(client_bin)
|
||||||
|
.arg("--dosh-host")
|
||||||
|
.arg("127.0.0.1")
|
||||||
|
.arg("--dosh-port")
|
||||||
|
.arg(port.to_string())
|
||||||
|
.arg("cp")
|
||||||
|
.arg("--resume")
|
||||||
|
.arg(&local_upload)
|
||||||
|
.arg("local:remote-upload.txt")
|
||||||
|
.env("HOME", dir.path())
|
||||||
|
.output()
|
||||||
|
.unwrap();
|
||||||
|
assert!(
|
||||||
|
!bad_upload_resume.status.success(),
|
||||||
|
"bad upload resume unexpectedly succeeded: stdout={} stderr={}",
|
||||||
|
String::from_utf8_lossy(&bad_upload_resume.stdout),
|
||||||
|
String::from_utf8_lossy(&bad_upload_resume.stderr)
|
||||||
|
);
|
||||||
|
assert_eq!(
|
||||||
|
fs::read_to_string(&remote_upload).unwrap(),
|
||||||
|
"remote-prefix-with-tail\n"
|
||||||
|
);
|
||||||
|
assert_eq!(
|
||||||
|
fs::metadata(&remote_upload).unwrap().permissions().mode() & 0o777,
|
||||||
|
0o600
|
||||||
|
);
|
||||||
|
|
||||||
|
fs::write(dir.path().join("remote-download.txt"), b"remote-download\n").unwrap();
|
||||||
|
let local_download = dir.path().join("download-prefix.txt");
|
||||||
|
fs::write(&local_download, b"local-download-with-tail\n").unwrap();
|
||||||
|
|
||||||
|
let bad_download_resume = Command::new(client_bin)
|
||||||
|
.arg("--dosh-host")
|
||||||
|
.arg("127.0.0.1")
|
||||||
|
.arg("--dosh-port")
|
||||||
|
.arg(port.to_string())
|
||||||
|
.arg("cp")
|
||||||
|
.arg("--resume")
|
||||||
|
.arg("local:remote-download.txt")
|
||||||
|
.arg(&local_download)
|
||||||
|
.env("HOME", dir.path())
|
||||||
|
.output()
|
||||||
|
.unwrap();
|
||||||
|
assert!(
|
||||||
|
!bad_download_resume.status.success(),
|
||||||
|
"bad download resume unexpectedly succeeded: stdout={} stderr={}",
|
||||||
|
String::from_utf8_lossy(&bad_download_resume.stdout),
|
||||||
|
String::from_utf8_lossy(&bad_download_resume.stderr)
|
||||||
|
);
|
||||||
|
assert_eq!(
|
||||||
|
fs::read_to_string(&local_download).unwrap(),
|
||||||
|
"local-download-with-tail\n"
|
||||||
|
);
|
||||||
|
|
||||||
|
let _ = server.kill();
|
||||||
|
let _ = server.wait();
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn native_exec_command_smoke() {
|
fn native_exec_command_smoke() {
|
||||||
let dir = tempfile::tempdir().unwrap();
|
let dir = tempfile::tempdir().unwrap();
|
||||||
|
|||||||
Reference in New Issue
Block a user