Compare commits
23 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| bea4674700 | |||
| c9332f707d | |||
| d883e1cdb2 | |||
| e061b11974 | |||
| 0f2cb82be6 | |||
| f74495765f | |||
| b2c407ab6e | |||
| 4b9d05a185 | |||
| 3d5bb126c5 | |||
| 37632a96b7 | |||
| e69be4fdf0 | |||
| fdbd58b628 | |||
| c65aba9d7a | |||
| 818b481154 | |||
| 70650e221b | |||
| 01e8870578 | |||
| 99d54899bd | |||
| 80e922957e | |||
| 1dcb33550e | |||
| 2c5b9ab30d | |||
| bfe75dfbd2 | |||
| 4ea05fc14f | |||
| bae0d0ed56 |
@@ -86,6 +86,39 @@ jobs:
|
||||
target/dosh-release/dosh-*
|
||||
!target/dosh-release/stage/**
|
||||
|
||||
publish-gitea-release:
|
||||
if: github.event_name == 'workflow_dispatch' || startsWith(github.ref, 'refs/tags/')
|
||||
needs: package-release
|
||||
runs-on: ubuntu-latest
|
||||
env:
|
||||
GITEA_TOKEN: ${{ secrets.GITEA_TOKEN }}
|
||||
GITEA_URL: ${{ secrets.GITEA_URL || 'https://git.palav.dev' }}
|
||||
GITEA_REPO: ${{ secrets.GITEA_REPO || 'Palav/dosh' }}
|
||||
steps:
|
||||
- uses: actions/checkout@v4
|
||||
- uses: actions/download-artifact@v4
|
||||
with:
|
||||
pattern: dosh-*
|
||||
path: target/dosh-release
|
||||
merge-multiple: true
|
||||
- name: Verify release artifacts
|
||||
run: sh scripts/verify-release-artifacts.sh
|
||||
- name: Skip Gitea upload without token
|
||||
if: env.GITEA_TOKEN == ''
|
||||
run: echo "GITEA_TOKEN secret is not configured; release artifacts were verified but not uploaded."
|
||||
- name: Upload Gitea release assets
|
||||
if: env.GITEA_TOKEN != ''
|
||||
run: |
|
||||
set -eu
|
||||
case "$GITHUB_REF" in
|
||||
refs/tags/*) tag="${GITHUB_REF_NAME}" ;;
|
||||
*)
|
||||
version="$(sed -n 's/^version = "\(.*\)"/\1/p' Cargo.toml | sed -n '1p')"
|
||||
tag="v$version"
|
||||
;;
|
||||
esac
|
||||
scripts/upload-gitea-release.sh "$tag"
|
||||
|
||||
remote-bench:
|
||||
runs-on: ubuntu-latest
|
||||
env:
|
||||
|
||||
Generated
+1
-1
@@ -436,7 +436,7 @@ dependencies = [
|
||||
|
||||
[[package]]
|
||||
name = "dosh"
|
||||
version = "1.0.0-rc23"
|
||||
version = "1.0.0-rc42"
|
||||
dependencies = [
|
||||
"anyhow",
|
||||
"base64",
|
||||
|
||||
+1
-1
@@ -1,6 +1,6 @@
|
||||
[package]
|
||||
name = "dosh"
|
||||
version = "1.0.0-rc23"
|
||||
version = "1.0.0-rc42"
|
||||
edition = "2024"
|
||||
license = "MIT"
|
||||
|
||||
|
||||
@@ -68,6 +68,32 @@ dosh restart HOST
|
||||
Agent forwarding is opt-in with `-A` and must also be enabled on the server.
|
||||
File copy must be enabled by the server config.
|
||||
|
||||
## Tracing
|
||||
|
||||
For terminal/reconnect bugs, run a client with:
|
||||
|
||||
```sh
|
||||
dosh trace HOST
|
||||
```
|
||||
|
||||
The client log path is printed before the session starts. To choose it:
|
||||
|
||||
```sh
|
||||
dosh trace --client-log /tmp/dosh-client.log HOST
|
||||
```
|
||||
|
||||
Summarize collected traces with:
|
||||
|
||||
```sh
|
||||
dosh trace report HOST --client-log /tmp/dosh-client.log
|
||||
```
|
||||
|
||||
When `HOST` is given, Dosh fetches `/tmp/dosh-server.log` over SSH before
|
||||
building the report. Set `DOSH_TRACE=/tmp/dosh-server.log` on `dosh-server` for
|
||||
matching server events. Reports default to the latest traced client/server
|
||||
process run; add `--all-runs` to include older appended log entries. Trace byte
|
||||
prefixes are enabled for `dosh trace`, so use it only for short reproductions.
|
||||
|
||||
## VS Code
|
||||
|
||||
Dosh can carry VS Code Remote-SSH through its transport:
|
||||
@@ -108,6 +134,10 @@ dosh_host = "prod.example.com"
|
||||
port = 50000
|
||||
```
|
||||
|
||||
`ProxyJump` and `ProxyCommand` can be used for SSH setup, but the Dosh UDP
|
||||
endpoint still has to be reachable directly from the client. Set `dosh_host` to
|
||||
the reachable UDP hostname or IP when it differs from the SSH alias target.
|
||||
|
||||
## Rust Library
|
||||
|
||||
Dosh exposes a Rust transport for encrypted, reconnecting application streams.
|
||||
|
||||
@@ -25,7 +25,7 @@ artifact_version() {
|
||||
if [ "$#" -gt 0 ]; then
|
||||
artifacts="$*"
|
||||
else
|
||||
artifacts="$out_dir/dosh-linux-x86_64.tar.gz $out_dir/dosh-macos-aarch64.tar.gz $out_dir/dosh-windows-x86_64.zip"
|
||||
artifacts="$out_dir/dosh-linux-x86_64.tar.gz $out_dir/dosh-macos-aarch64.tar.gz $out_dir/dosh-macos-x86_64.tar.gz $out_dir/dosh-windows-x86_64.zip"
|
||||
fi
|
||||
|
||||
failed=0
|
||||
|
||||
+2445
-116
File diff suppressed because it is too large
Load Diff
+244
-44
@@ -67,6 +67,15 @@ static AGENT_SOCK_COUNTER: AtomicU64 = AtomicU64::new(0);
|
||||
/// before it is swept by the cleanup task.
|
||||
const NATIVE_HANDSHAKE_TTL_SECS: u64 = 30;
|
||||
|
||||
fn hex_id(id: [u8; 16]) -> String {
|
||||
let mut out = String::with_capacity(32);
|
||||
for byte in id {
|
||||
use std::fmt::Write as _;
|
||||
let _ = write!(&mut out, "{byte:02x}");
|
||||
}
|
||||
out
|
||||
}
|
||||
|
||||
#[derive(Debug, Parser)]
|
||||
#[command(
|
||||
name = "dosh-server",
|
||||
@@ -191,6 +200,13 @@ async fn serve(config_path: Option<std::path::PathBuf>) -> Result<()> {
|
||||
.with_context(|| format!("bind {bind}"))?,
|
||||
);
|
||||
eprintln!("dosh-server listening on {bind}");
|
||||
dosh::trace::event(
|
||||
"server.start",
|
||||
&[
|
||||
("version", dosh::build_info::VERSION.to_string()),
|
||||
("bind", bind.clone()),
|
||||
],
|
||||
);
|
||||
|
||||
let (pty_tx, mut pty_rx) = mpsc::unbounded_channel();
|
||||
let state = Arc::new(Mutex::new(ServerState::new(
|
||||
@@ -1447,6 +1463,7 @@ async fn handle_ticket_attach(
|
||||
peer: SocketAddr,
|
||||
body: Vec<u8>,
|
||||
) -> Result<()> {
|
||||
dosh::trace::event("server.ticket_attach_start", &[("peer", peer.to_string())]);
|
||||
let env: TicketAttachEnvelope = protocol::from_body(&body)?;
|
||||
let opened = {
|
||||
let locked = state.lock().expect("server state poisoned");
|
||||
@@ -1470,10 +1487,22 @@ async fn handle_ticket_attach(
|
||||
};
|
||||
let (ticket, request_plain) = match opened {
|
||||
Ok(opened) => opened,
|
||||
Err(err) => return send_reject(socket, peer, &err.to_string()).await,
|
||||
Err(err) => {
|
||||
let reason = err.to_string();
|
||||
dosh::trace::event("server.ticket_attach_reject", &[("reason", reason.clone())]);
|
||||
return send_reject(socket, peer, &reason).await;
|
||||
}
|
||||
};
|
||||
let req: TicketAttachBody = protocol::from_body(&request_plain)?;
|
||||
if req.session != ticket.session || req.mode != ticket.mode {
|
||||
dosh::trace::event(
|
||||
"server.ticket_attach_reject",
|
||||
&[
|
||||
("session", req.session.clone()),
|
||||
("mode", req.mode.clone()),
|
||||
("reason", "ticket scope mismatch".to_string()),
|
||||
],
|
||||
);
|
||||
return send_reject(socket, peer, "ticket scope mismatch").await;
|
||||
}
|
||||
|
||||
@@ -1544,7 +1573,18 @@ async fn handle_ticket_attach(
|
||||
};
|
||||
let (client_id, output_seq, snapshot) = match attached {
|
||||
Ok(attached) => attached,
|
||||
Err(err) => return send_reject(socket, peer, &err.to_string()).await,
|
||||
Err(err) => {
|
||||
let reason = err.to_string();
|
||||
dosh::trace::event(
|
||||
"server.ticket_attach_reject",
|
||||
&[
|
||||
("session", req.session.clone()),
|
||||
("mode", req.mode.clone()),
|
||||
("reason", reason.clone()),
|
||||
],
|
||||
);
|
||||
return send_reject(socket, peer, &reason).await;
|
||||
}
|
||||
};
|
||||
|
||||
let ok = AttachOk {
|
||||
@@ -1575,6 +1615,16 @@ async fn handle_ticket_attach(
|
||||
let body = protocol::to_body(&envelope)?;
|
||||
let out = protocol::encode_plain(PacketKind::AttachOk, client_id, 1, 0, &body)?;
|
||||
let _ = send_udp(socket, &out, peer).await?;
|
||||
dosh::trace::event(
|
||||
"server.ticket_attach_ok",
|
||||
&[
|
||||
("session", ok.session.clone()),
|
||||
("mode", ok.mode.clone()),
|
||||
("client", hex_id(client_id)),
|
||||
("output_seq", output_seq.to_string()),
|
||||
("bytes", ok.snapshot.len().to_string()),
|
||||
],
|
||||
);
|
||||
Ok(())
|
||||
}
|
||||
|
||||
@@ -1602,9 +1652,22 @@ async fn handle_resume(
|
||||
peer: SocketAddr,
|
||||
packet: &protocol::Packet,
|
||||
) -> Result<()> {
|
||||
dosh::trace::event(
|
||||
"server.resume_start",
|
||||
&[
|
||||
("peer", peer.to_string()),
|
||||
("client", hex_id(packet.header.conn_id)),
|
||||
("seq", packet.header.seq.to_string()),
|
||||
("ack", packet.header.ack.to_string()),
|
||||
],
|
||||
);
|
||||
let (key, session_name) = match find_client_decrypt_key(state, &packet.header) {
|
||||
Ok(found) => found,
|
||||
Err(_) => {
|
||||
dosh::trace::event(
|
||||
"server.resume_unknown_client",
|
||||
&[("client", hex_id(packet.header.conn_id))],
|
||||
);
|
||||
return send_reject_to_client(socket, peer, packet.header.conn_id, "unknown client")
|
||||
.await;
|
||||
}
|
||||
@@ -1623,8 +1686,25 @@ async fn handle_resume(
|
||||
.get_mut(&packet.header.conn_id)
|
||||
.ok_or_else(|| anyhow!("unknown client"))?;
|
||||
if !client.replay.accept(packet.header.seq) {
|
||||
dosh::trace::event(
|
||||
"server.resume_replay_drop",
|
||||
&[
|
||||
("session", req.session.clone()),
|
||||
("seq", packet.header.seq.to_string()),
|
||||
],
|
||||
);
|
||||
return Ok(());
|
||||
}
|
||||
if client.endpoint != peer {
|
||||
dosh::trace::event(
|
||||
"server.resume_roam",
|
||||
&[
|
||||
("session", req.session.clone()),
|
||||
("from", client.endpoint.to_string()),
|
||||
("to", peer.to_string()),
|
||||
],
|
||||
);
|
||||
}
|
||||
client.endpoint = peer;
|
||||
client.last_acked = req.last_rendered_seq;
|
||||
client.cols = req.cols;
|
||||
@@ -1662,6 +1742,14 @@ async fn handle_resume(
|
||||
&body,
|
||||
)?;
|
||||
let _ = send_udp(socket, &out, peer).await?;
|
||||
dosh::trace::event(
|
||||
"server.resume_ok",
|
||||
&[
|
||||
("session", frame.session),
|
||||
("output_seq", frame.output_seq.to_string()),
|
||||
("bytes", frame.bytes.len().to_string()),
|
||||
],
|
||||
);
|
||||
Ok(())
|
||||
}
|
||||
|
||||
@@ -1673,6 +1761,7 @@ async fn handle_input(
|
||||
let (key, session_name) = find_client_decrypt_key(state, &packet.header)?;
|
||||
let body = protocol::decrypt_body(packet, &key, CLIENT_TO_SERVER)?;
|
||||
let input: Input = protocol::from_body(&body)?;
|
||||
let input_summary = dosh::trace::bytes_summary(&input.bytes);
|
||||
let mut locked = state.lock().expect("server state poisoned");
|
||||
let session = locked
|
||||
.sessions
|
||||
@@ -1683,13 +1772,37 @@ async fn handle_input(
|
||||
.get_mut(&packet.header.conn_id)
|
||||
.ok_or_else(|| anyhow!("unknown client"))?;
|
||||
if !client.replay.accept(packet.header.seq) {
|
||||
dosh::trace::event(
|
||||
"server.input_replay_drop",
|
||||
&[
|
||||
("session", session_name.clone()),
|
||||
("seq", packet.header.seq.to_string()),
|
||||
("summary", input_summary),
|
||||
],
|
||||
);
|
||||
return Ok(());
|
||||
}
|
||||
if client.endpoint != peer {
|
||||
dosh::trace::event(
|
||||
"server.input_roam",
|
||||
&[
|
||||
("session", session_name.clone()),
|
||||
("from", client.endpoint.to_string()),
|
||||
("to", peer.to_string()),
|
||||
],
|
||||
);
|
||||
client.endpoint = peer;
|
||||
}
|
||||
client.last_seen = Instant::now();
|
||||
if !mode_allows_terminal_updates(&client.mode) {
|
||||
dosh::trace::event(
|
||||
"server.input_rejected_mode",
|
||||
&[
|
||||
("session", session_name),
|
||||
("mode", client.mode.clone()),
|
||||
("summary", input_summary),
|
||||
],
|
||||
);
|
||||
return Ok(());
|
||||
}
|
||||
session
|
||||
@@ -1697,6 +1810,14 @@ async fn handle_input(
|
||||
.as_ref()
|
||||
.context("terminal session has no pty")?
|
||||
.write_all(&input.bytes)?;
|
||||
dosh::trace::event(
|
||||
"server.pty_write",
|
||||
&[
|
||||
("session", session_name),
|
||||
("seq", packet.header.seq.to_string()),
|
||||
("summary", input_summary),
|
||||
],
|
||||
);
|
||||
Ok(())
|
||||
}
|
||||
|
||||
@@ -2566,8 +2687,10 @@ struct UploadState {
|
||||
hasher: Sha256,
|
||||
written: u64,
|
||||
expected_size: u64,
|
||||
mode: Option<u32>,
|
||||
modified_secs: Option<u64>,
|
||||
atomic: bool,
|
||||
original_len: Option<u64>,
|
||||
}
|
||||
|
||||
async fn run_file_stream_service(
|
||||
@@ -2679,6 +2802,46 @@ async fn handle_file_request(
|
||||
send_file_response_to_client(state, socket, client_id, stream_id, FileResponse::Ok)
|
||||
.await
|
||||
}
|
||||
FileRequest::Readlink { path } => {
|
||||
let path = clean_remote_path(&path, home)?;
|
||||
let target =
|
||||
fs::read_link(&path).with_context(|| format!("readlink {}", path.display()))?;
|
||||
let target = target
|
||||
.to_str()
|
||||
.ok_or_else(|| anyhow!("symlink target is not valid UTF-8"))?
|
||||
.to_string();
|
||||
send_file_response_to_client(
|
||||
state,
|
||||
socket,
|
||||
client_id,
|
||||
stream_id,
|
||||
FileResponse::LinkTarget { target },
|
||||
)
|
||||
.await
|
||||
}
|
||||
FileRequest::Symlink {
|
||||
path,
|
||||
target,
|
||||
overwrite,
|
||||
} => {
|
||||
let path = clean_remote_path(&path, home)?;
|
||||
if let Some(parent) = path.parent() {
|
||||
fs::create_dir_all(parent)
|
||||
.with_context(|| format!("create {}", parent.display()))?;
|
||||
}
|
||||
if let Ok(metadata) = fs::symlink_metadata(&path) {
|
||||
anyhow::ensure!(overwrite, "destination exists: {}", path.display());
|
||||
anyhow::ensure!(
|
||||
!metadata.is_dir(),
|
||||
"destination is a directory: {}",
|
||||
path.display()
|
||||
);
|
||||
fs::remove_file(&path).with_context(|| format!("remove {}", path.display()))?;
|
||||
}
|
||||
create_symlink(&target, &path)?;
|
||||
send_file_response_to_client(state, socket, client_id, stream_id, FileResponse::Ok)
|
||||
.await
|
||||
}
|
||||
FileRequest::Remove { path, recursive } => {
|
||||
let path = clean_remote_path(&path, home)?;
|
||||
let metadata =
|
||||
@@ -2716,31 +2879,41 @@ async fn handle_file_request(
|
||||
bail!("destination exists: {}", final_path.display());
|
||||
}
|
||||
let mut hasher = Sha256::new();
|
||||
let (file, temp_path, written, atomic) = if resume && final_path.exists() {
|
||||
let mut file = fs::OpenOptions::new()
|
||||
.read(true)
|
||||
.append(true)
|
||||
.open(&final_path)
|
||||
.with_context(|| format!("open {}", final_path.display()))?;
|
||||
let written = file.metadata()?.len().min(size);
|
||||
file.set_len(written)
|
||||
.with_context(|| format!("truncate {}", final_path.display()))?;
|
||||
if written > 0 {
|
||||
let mut prefix = fs::File::open(&final_path)?;
|
||||
hash_exact_prefix(&mut prefix, written, &mut hasher)?;
|
||||
}
|
||||
file.seek(SeekFrom::Start(written))?;
|
||||
(file, None, written, false)
|
||||
} else {
|
||||
let temp_path = upload_temp_path(&final_path, stream_id);
|
||||
let file = fs::OpenOptions::new()
|
||||
.create(true)
|
||||
.truncate(true)
|
||||
.write(true)
|
||||
.open(&temp_path)
|
||||
.with_context(|| format!("create {}", temp_path.display()))?;
|
||||
(file, Some(temp_path), 0, true)
|
||||
};
|
||||
let (file, temp_path, written, atomic, original_len, prefix_sha256) =
|
||||
if resume && final_path.exists() {
|
||||
let original_len = fs::metadata(&final_path)
|
||||
.with_context(|| format!("stat {}", final_path.display()))?
|
||||
.len();
|
||||
let written = original_len.min(size);
|
||||
if written > 0 {
|
||||
let mut prefix = fs::File::open(&final_path)?;
|
||||
hash_exact_prefix(&mut prefix, written, &mut hasher)?;
|
||||
}
|
||||
let prefix_sha256 = (written > 0).then(|| hasher.clone().finalize().into());
|
||||
let mut file = fs::OpenOptions::new()
|
||||
.read(true)
|
||||
.append(true)
|
||||
.open(&final_path)
|
||||
.with_context(|| format!("open {}", final_path.display()))?;
|
||||
file.seek(SeekFrom::Start(written))?;
|
||||
(
|
||||
file,
|
||||
None,
|
||||
written,
|
||||
false,
|
||||
Some(original_len),
|
||||
prefix_sha256,
|
||||
)
|
||||
} else {
|
||||
let temp_path = upload_temp_path(&final_path, stream_id);
|
||||
let file = fs::OpenOptions::new()
|
||||
.create(true)
|
||||
.truncate(true)
|
||||
.write(true)
|
||||
.open(&temp_path)
|
||||
.with_context(|| format!("create {}", temp_path.display()))?;
|
||||
(file, Some(temp_path), 0, true, None, None)
|
||||
};
|
||||
*upload = Some(UploadState {
|
||||
final_path,
|
||||
temp_path,
|
||||
@@ -2748,23 +2921,20 @@ async fn handle_file_request(
|
||||
hasher,
|
||||
written,
|
||||
expected_size: size,
|
||||
mode,
|
||||
modified_secs,
|
||||
atomic,
|
||||
original_len,
|
||||
});
|
||||
if let Some(mode) = mode {
|
||||
let target = upload
|
||||
.as_ref()
|
||||
.and_then(|state| state.temp_path.as_ref())
|
||||
.unwrap_or_else(|| &upload.as_ref().unwrap().final_path)
|
||||
.clone();
|
||||
set_mode(&target, mode)?;
|
||||
}
|
||||
send_file_response_to_client(
|
||||
state,
|
||||
socket,
|
||||
client_id,
|
||||
stream_id,
|
||||
FileResponse::Resume { offset: written },
|
||||
FileResponse::Resume {
|
||||
offset: written,
|
||||
prefix_sha256,
|
||||
},
|
||||
)
|
||||
.await
|
||||
}
|
||||
@@ -2786,8 +2956,6 @@ async fn handle_file_request(
|
||||
let Some(mut active) = upload.take() else {
|
||||
bail!("no upload in progress");
|
||||
};
|
||||
active.file.flush()?;
|
||||
active.file.sync_all()?;
|
||||
anyhow::ensure!(
|
||||
active.written == active.expected_size,
|
||||
"upload size mismatch: got {}, expected {}",
|
||||
@@ -2798,9 +2966,17 @@ async fn handle_file_request(
|
||||
if digest != sha256 {
|
||||
if let Some(temp_path) = &active.temp_path {
|
||||
let _ = fs::remove_file(temp_path);
|
||||
} else if let Some(original_len) = active.original_len {
|
||||
let _ = active.file.set_len(original_len);
|
||||
}
|
||||
bail!("upload checksum mismatch");
|
||||
}
|
||||
active
|
||||
.file
|
||||
.set_len(active.expected_size)
|
||||
.with_context(|| format!("truncate {}", active.final_path.display()))?;
|
||||
active.file.flush()?;
|
||||
active.file.sync_all()?;
|
||||
drop(active.file);
|
||||
if active.atomic
|
||||
&& let Some(temp_path) = active.temp_path.take()
|
||||
@@ -2813,6 +2989,9 @@ async fn handle_file_request(
|
||||
)
|
||||
})?;
|
||||
}
|
||||
if let Some(mode) = active.mode {
|
||||
set_mode(&active.final_path, mode)?;
|
||||
}
|
||||
if let Some(modified_secs) = active.modified_secs {
|
||||
filetime::set_file_mtime(
|
||||
&active.final_path,
|
||||
@@ -2840,9 +3019,20 @@ async fn handle_file_request(
|
||||
"remote path is not a file: {}",
|
||||
meta.path
|
||||
);
|
||||
anyhow::ensure!(
|
||||
offset <= meta.len,
|
||||
"download offset {offset} is beyond file size {}",
|
||||
meta.len
|
||||
);
|
||||
let mut file =
|
||||
fs::File::open(&path).with_context(|| format!("open {}", path.display()))?;
|
||||
file.seek(SeekFrom::Start(offset))?;
|
||||
let mut hasher = Sha256::new();
|
||||
if offset > 0 {
|
||||
let mut prefix = fs::File::open(&path)?;
|
||||
hash_exact_prefix(&mut prefix, offset, &mut hasher)?;
|
||||
}
|
||||
let prefix_sha256 = (offset > 0).then(|| hasher.clone().finalize().into());
|
||||
send_file_response_to_client(
|
||||
state,
|
||||
socket,
|
||||
@@ -2851,14 +3041,10 @@ async fn handle_file_request(
|
||||
FileResponse::Start {
|
||||
meta: meta.clone(),
|
||||
offset,
|
||||
prefix_sha256,
|
||||
},
|
||||
)
|
||||
.await?;
|
||||
let mut hasher = Sha256::new();
|
||||
if offset > 0 {
|
||||
let mut prefix = fs::File::open(&path)?;
|
||||
hash_exact_prefix(&mut prefix, offset, &mut hasher)?;
|
||||
}
|
||||
let mut sent = offset;
|
||||
let mut buf = vec![0u8; CHUNK_SIZE];
|
||||
loop {
|
||||
@@ -3040,6 +3226,17 @@ fn set_mode(path: &Path, mode: u32) -> Result<()> {
|
||||
fs::set_permissions(path, permissions).with_context(|| format!("chmod {}", path.display()))
|
||||
}
|
||||
|
||||
#[cfg(unix)]
|
||||
fn create_symlink(target: &str, path: &Path) -> Result<()> {
|
||||
std::os::unix::fs::symlink(target, path)
|
||||
.with_context(|| format!("symlink {} -> {}", path.display(), target))
|
||||
}
|
||||
|
||||
#[cfg(not(unix))]
|
||||
fn create_symlink(_target: &str, _path: &Path) -> Result<()> {
|
||||
bail!("symlink creation is not supported on this server platform")
|
||||
}
|
||||
|
||||
fn upload_temp_path(final_path: &Path, stream_id: u64) -> PathBuf {
|
||||
let name = final_path
|
||||
.file_name()
|
||||
@@ -3243,7 +3440,10 @@ async fn flush_stream_pending_data_to_client(
|
||||
if credit < bytes.len() {
|
||||
return Ok(());
|
||||
}
|
||||
let bytes = pending.pop_front().expect("pending front exists");
|
||||
let Some(bytes) = pending.pop_front() else {
|
||||
client.stream_pending_data.remove(&stream_id);
|
||||
return Ok(());
|
||||
};
|
||||
if pending.is_empty() {
|
||||
client.stream_pending_data.remove(&stream_id);
|
||||
}
|
||||
|
||||
+37
-7
@@ -18,6 +18,14 @@ pub enum FileRequest {
|
||||
path: String,
|
||||
mode: Option<u32>,
|
||||
},
|
||||
Readlink {
|
||||
path: String,
|
||||
},
|
||||
Symlink {
|
||||
path: String,
|
||||
target: String,
|
||||
overwrite: bool,
|
||||
},
|
||||
Remove {
|
||||
path: String,
|
||||
recursive: bool,
|
||||
@@ -46,13 +54,35 @@ pub enum FileRequest {
|
||||
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
|
||||
pub enum FileResponse {
|
||||
Ok,
|
||||
Resume { offset: u64 },
|
||||
Stat { meta: FileMeta },
|
||||
List { entries: Vec<FileEntry> },
|
||||
Start { meta: FileMeta, offset: u64 },
|
||||
Chunk { offset: u64, bytes: Vec<u8> },
|
||||
Done { sha256: [u8; 32], bytes: u64 },
|
||||
Error { message: String },
|
||||
Resume {
|
||||
offset: u64,
|
||||
prefix_sha256: Option<[u8; 32]>,
|
||||
},
|
||||
Stat {
|
||||
meta: FileMeta,
|
||||
},
|
||||
List {
|
||||
entries: Vec<FileEntry>,
|
||||
},
|
||||
LinkTarget {
|
||||
target: String,
|
||||
},
|
||||
Start {
|
||||
meta: FileMeta,
|
||||
offset: u64,
|
||||
prefix_sha256: Option<[u8; 32]>,
|
||||
},
|
||||
Chunk {
|
||||
offset: u64,
|
||||
bytes: Vec<u8>,
|
||||
},
|
||||
Done {
|
||||
sha256: [u8; 32],
|
||||
bytes: u64,
|
||||
},
|
||||
Error {
|
||||
message: String,
|
||||
},
|
||||
}
|
||||
|
||||
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
|
||||
|
||||
@@ -22,5 +22,6 @@ pub mod protocol;
|
||||
pub mod pty;
|
||||
pub mod server;
|
||||
pub mod ssh_agent;
|
||||
pub mod trace;
|
||||
pub mod transport;
|
||||
pub mod udp;
|
||||
|
||||
+223
@@ -0,0 +1,223 @@
|
||||
use std::fs::{File, OpenOptions};
|
||||
use std::io::Write;
|
||||
use std::path::{Path, PathBuf};
|
||||
use std::sync::{Mutex, OnceLock};
|
||||
use std::time::{SystemTime, UNIX_EPOCH};
|
||||
|
||||
static TRACE_FILE: OnceLock<Option<Mutex<File>>> = OnceLock::new();
|
||||
static HEALTH_FILE: OnceLock<Option<Mutex<File>>> = OnceLock::new();
|
||||
static TRACE_BYTES: OnceLock<bool> = OnceLock::new();
|
||||
const HEALTH_LOG_MAX_BYTES: u64 = 1024 * 1024;
|
||||
|
||||
pub fn enabled() -> bool {
|
||||
TRACE_FILE.get_or_init(open_trace_file).is_some()
|
||||
}
|
||||
|
||||
pub fn bytes_enabled() -> bool {
|
||||
*TRACE_BYTES.get_or_init(|| truthy_env("DOSH_TRACE_BYTES"))
|
||||
}
|
||||
|
||||
pub fn event(name: &str, fields: &[(&str, String)]) {
|
||||
let Some(file) = TRACE_FILE.get_or_init(open_trace_file) else {
|
||||
return;
|
||||
};
|
||||
write_event(file, name, fields);
|
||||
}
|
||||
|
||||
pub fn health_event(name: &str, fields: &[(&str, String)]) {
|
||||
let Some(file) = HEALTH_FILE.get_or_init(open_health_file) else {
|
||||
return;
|
||||
};
|
||||
write_event(file, name, fields);
|
||||
}
|
||||
|
||||
pub fn default_health_log_path() -> PathBuf {
|
||||
trace_root().join("health.log")
|
||||
}
|
||||
|
||||
fn write_event(file: &Mutex<File>, name: &str, fields: &[(&str, String)]) {
|
||||
let now = SystemTime::now()
|
||||
.duration_since(UNIX_EPOCH)
|
||||
.map(|duration| duration.as_millis())
|
||||
.unwrap_or(0);
|
||||
let mut line = format!(
|
||||
"ts_ms={} pid={} event={}",
|
||||
now,
|
||||
std::process::id(),
|
||||
shell_escape(name)
|
||||
);
|
||||
for (key, value) in fields {
|
||||
line.push(' ');
|
||||
line.push_str(key);
|
||||
line.push('=');
|
||||
line.push_str(&shell_escape(value));
|
||||
}
|
||||
line.push('\n');
|
||||
if let Ok(mut file) = file.lock() {
|
||||
let _ = file.write_all(line.as_bytes());
|
||||
let _ = file.flush();
|
||||
}
|
||||
}
|
||||
|
||||
pub fn bytes_summary(bytes: &[u8]) -> String {
|
||||
let mut parts = vec![
|
||||
format!("len={}", bytes.len()),
|
||||
format!(
|
||||
"esc={}",
|
||||
contains_byte(bytes, 0x1b) || contains_byte(bytes, 0x9b)
|
||||
),
|
||||
format!("focus={}", has_focus_report(bytes)),
|
||||
format!("mouseish={}", looks_mouseish(bytes)),
|
||||
format!("printable={}", printable_count(bytes)),
|
||||
];
|
||||
if bytes_enabled() {
|
||||
parts.push(format!("hex={}", hex_prefix(bytes, 160)));
|
||||
}
|
||||
parts.join(",")
|
||||
}
|
||||
|
||||
fn open_trace_file() -> Option<Mutex<File>> {
|
||||
let raw = std::env::var_os("DOSH_TRACE")?;
|
||||
let normalized = raw.to_string_lossy().to_ascii_lowercase();
|
||||
if normalized.is_empty() || matches!(normalized.as_str(), "0" | "false" | "off") {
|
||||
return None;
|
||||
}
|
||||
let path = if matches!(normalized.as_str(), "1" | "true" | "on") {
|
||||
default_trace_path()
|
||||
} else {
|
||||
PathBuf::from(raw)
|
||||
};
|
||||
if let Some(parent) = path.parent() {
|
||||
let _ = std::fs::create_dir_all(parent);
|
||||
}
|
||||
OpenOptions::new()
|
||||
.create(true)
|
||||
.append(true)
|
||||
.open(&path)
|
||||
.ok()
|
||||
.map(Mutex::new)
|
||||
}
|
||||
|
||||
fn open_health_file() -> Option<Mutex<File>> {
|
||||
let path = health_log_path_from_env()?;
|
||||
rotate_health_log_if_needed(&path);
|
||||
if let Some(parent) = path.parent() {
|
||||
let _ = std::fs::create_dir_all(parent);
|
||||
}
|
||||
OpenOptions::new()
|
||||
.create(true)
|
||||
.append(true)
|
||||
.open(&path)
|
||||
.ok()
|
||||
.map(Mutex::new)
|
||||
}
|
||||
|
||||
fn health_log_path_from_env() -> Option<PathBuf> {
|
||||
match std::env::var_os("DOSH_HEALTH_LOG") {
|
||||
Some(raw) => {
|
||||
let normalized = raw.to_string_lossy().to_ascii_lowercase();
|
||||
if normalized.is_empty() || matches!(normalized.as_str(), "0" | "false" | "off") {
|
||||
None
|
||||
} else if matches!(normalized.as_str(), "1" | "true" | "on") {
|
||||
Some(default_health_log_path())
|
||||
} else {
|
||||
Some(PathBuf::from(raw))
|
||||
}
|
||||
}
|
||||
None => Some(default_health_log_path()),
|
||||
}
|
||||
}
|
||||
|
||||
fn rotate_health_log_if_needed(path: &Path) {
|
||||
let Ok(metadata) = std::fs::metadata(path) else {
|
||||
return;
|
||||
};
|
||||
if metadata.len() <= HEALTH_LOG_MAX_BYTES {
|
||||
return;
|
||||
}
|
||||
let rotated = path.with_extension("log.1");
|
||||
let _ = std::fs::remove_file(&rotated);
|
||||
let _ = std::fs::rename(path, rotated);
|
||||
}
|
||||
|
||||
fn default_trace_path() -> PathBuf {
|
||||
let exe = std::env::current_exe()
|
||||
.ok()
|
||||
.and_then(|path| {
|
||||
path.file_stem()
|
||||
.map(|stem| stem.to_string_lossy().to_string())
|
||||
})
|
||||
.unwrap_or_else(|| "dosh".to_string());
|
||||
trace_root().join(format!("{}-{}.log", exe, std::process::id()))
|
||||
}
|
||||
|
||||
fn trace_root() -> PathBuf {
|
||||
dirs::cache_dir()
|
||||
.unwrap_or_else(std::env::temp_dir)
|
||||
.join("dosh")
|
||||
.join("trace")
|
||||
}
|
||||
|
||||
fn truthy_env(name: &str) -> bool {
|
||||
std::env::var_os(name).is_some_and(|value| {
|
||||
let normalized = value.to_string_lossy().to_ascii_lowercase();
|
||||
!normalized.is_empty() && !matches!(normalized.as_str(), "0" | "false" | "off")
|
||||
})
|
||||
}
|
||||
|
||||
fn shell_escape(value: &str) -> String {
|
||||
if value.bytes().all(|byte| {
|
||||
byte.is_ascii_alphanumeric()
|
||||
|| matches!(byte, b'.' | b'-' | b'_' | b':' | b'/' | b',' | b'=')
|
||||
}) {
|
||||
return value.to_string();
|
||||
}
|
||||
let mut out = String::from("'");
|
||||
for ch in value.chars() {
|
||||
if ch == '\'' {
|
||||
out.push_str("'\\''");
|
||||
} else {
|
||||
out.push(ch);
|
||||
}
|
||||
}
|
||||
out.push('\'');
|
||||
out
|
||||
}
|
||||
|
||||
fn contains_byte(bytes: &[u8], needle: u8) -> bool {
|
||||
bytes.contains(&needle)
|
||||
}
|
||||
|
||||
fn has_focus_report(bytes: &[u8]) -> bool {
|
||||
bytes
|
||||
.windows(3)
|
||||
.any(|window| matches!(window, b"\x1b[I" | b"\x1b[O"))
|
||||
|| bytes
|
||||
.windows(2)
|
||||
.any(|window| matches!(window, b"\x9bI" | b"\x9bO"))
|
||||
}
|
||||
|
||||
fn looks_mouseish(bytes: &[u8]) -> bool {
|
||||
bytes.windows(3).any(|window| window == b"\x1b[<")
|
||||
|| bytes.windows(2).any(|window| window == b"\x9b<")
|
||||
|| bytes.iter().filter(|byte| **byte == b';').take(3).count() >= 2
|
||||
}
|
||||
|
||||
fn printable_count(bytes: &[u8]) -> usize {
|
||||
bytes
|
||||
.iter()
|
||||
.filter(|byte| byte.is_ascii_graphic() || **byte == b' ')
|
||||
.count()
|
||||
}
|
||||
|
||||
fn hex_prefix(bytes: &[u8], max: usize) -> String {
|
||||
let mut out = String::with_capacity(bytes.len().min(max) * 2);
|
||||
for byte in bytes.iter().take(max) {
|
||||
use std::fmt::Write as _;
|
||||
let _ = write!(&mut out, "{byte:02x}");
|
||||
}
|
||||
if bytes.len() > max {
|
||||
out.push_str("...");
|
||||
}
|
||||
out
|
||||
}
|
||||
+4
-2
@@ -596,11 +596,13 @@ impl StreamMux {
|
||||
if self.send_credit.get(&stream_id).copied().unwrap_or(0) < front_len {
|
||||
break;
|
||||
}
|
||||
let bytes = self
|
||||
let Some(bytes) = self
|
||||
.pending_data
|
||||
.get_mut(&stream_id)
|
||||
.and_then(VecDeque::pop_front)
|
||||
.expect("pending front exists");
|
||||
else {
|
||||
break;
|
||||
};
|
||||
if self
|
||||
.pending_data
|
||||
.get(&stream_id)
|
||||
|
||||
@@ -29,7 +29,7 @@ use std::io::{Read, Write};
|
||||
use std::net::{SocketAddr, TcpListener, UdpSocket};
|
||||
use std::process::{Child, Command, Stdio};
|
||||
use std::sync::Arc;
|
||||
use std::sync::atomic::{AtomicBool, AtomicU64, Ordering};
|
||||
use std::sync::atomic::{AtomicBool, AtomicU32, AtomicU64, Ordering};
|
||||
use std::sync::mpsc::{Receiver, Sender, channel};
|
||||
use std::thread;
|
||||
use std::time::{Duration, Instant};
|
||||
@@ -49,9 +49,20 @@ use ed25519_dalek::{SigningKey, VerifyingKey};
|
||||
use rand::rngs::StdRng;
|
||||
use rand::{Rng, SeedableRng};
|
||||
|
||||
const TEST_UDP_PORT_START: u16 = 31_000;
|
||||
const TEST_UDP_PORT_END: u16 = 60_999;
|
||||
static NEXT_UDP_PORT: AtomicU32 = AtomicU32::new(TEST_UDP_PORT_START as u32);
|
||||
|
||||
fn free_udp_port() -> u16 {
|
||||
let socket = UdpSocket::bind("127.0.0.1:0").unwrap();
|
||||
socket.local_addr().unwrap().port()
|
||||
let span = u32::from(TEST_UDP_PORT_END - TEST_UDP_PORT_START) + 1;
|
||||
for _ in TEST_UDP_PORT_START..=TEST_UDP_PORT_END {
|
||||
let offset = NEXT_UDP_PORT.fetch_add(1, Ordering::SeqCst) % span;
|
||||
let port = TEST_UDP_PORT_START + offset as u16;
|
||||
if UdpSocket::bind(("127.0.0.1", port)).is_ok() {
|
||||
return port;
|
||||
}
|
||||
}
|
||||
panic!("no free UDP test port in {TEST_UDP_PORT_START}-{TEST_UDP_PORT_END}");
|
||||
}
|
||||
|
||||
fn write_server_config(dir: &tempfile::TempDir, port: u16) -> std::path::PathBuf {
|
||||
|
||||
+135
-7
@@ -3,6 +3,7 @@
|
||||
use std::fs;
|
||||
use std::io::{Read, Write};
|
||||
use std::net::{TcpListener, TcpStream, UdpSocket};
|
||||
use std::os::unix::fs::PermissionsExt;
|
||||
use std::os::unix::net::{UnixListener, UnixStream};
|
||||
use std::path::{Path, PathBuf};
|
||||
use std::process::{Child, Command, Stdio};
|
||||
@@ -151,21 +152,41 @@ fn write_server_config_with_retransmit_window(
|
||||
}
|
||||
|
||||
fn start_server(dir: &tempfile::TempDir, config: &std::path::Path) -> Child {
|
||||
start_server_with_trace(dir, config, None)
|
||||
}
|
||||
|
||||
fn start_server_with_trace(
|
||||
dir: &tempfile::TempDir,
|
||||
config: &std::path::Path,
|
||||
trace: Option<&Path>,
|
||||
) -> Child {
|
||||
let server = env!("CARGO_BIN_EXE_dosh-server");
|
||||
let child = Command::new(server)
|
||||
let mut command = Command::new(server);
|
||||
command
|
||||
.arg("serve")
|
||||
.arg("--config")
|
||||
.arg(config)
|
||||
.env("HOME", dir.path())
|
||||
.stdout(Stdio::null())
|
||||
.stderr(Stdio::null())
|
||||
.spawn()
|
||||
.unwrap();
|
||||
.stderr(Stdio::null());
|
||||
if let Some(trace) = trace {
|
||||
command.env("DOSH_TRACE", trace);
|
||||
}
|
||||
let child = command.spawn().unwrap();
|
||||
thread::sleep(Duration::from_millis(500));
|
||||
child
|
||||
}
|
||||
|
||||
fn attach_once(dir: &tempfile::TempDir, port: u16, cache: bool) -> std::process::Output {
|
||||
attach_once_with_trace(dir, port, cache, None)
|
||||
}
|
||||
|
||||
fn attach_once_with_trace(
|
||||
dir: &tempfile::TempDir,
|
||||
port: u16,
|
||||
cache: bool,
|
||||
trace: Option<&Path>,
|
||||
) -> std::process::Output {
|
||||
let client = env!("CARGO_BIN_EXE_dosh-client");
|
||||
let mut cmd = Command::new(client);
|
||||
cmd.arg("--local-auth")
|
||||
@@ -180,6 +201,9 @@ fn attach_once(dir: &tempfile::TempDir, port: u16, cache: bool) -> std::process:
|
||||
if !cache {
|
||||
cmd.arg("--no-cache");
|
||||
}
|
||||
if let Some(trace) = trace {
|
||||
cmd.env("DOSH_TRACE", trace);
|
||||
}
|
||||
cmd.output().unwrap()
|
||||
}
|
||||
|
||||
@@ -1002,6 +1026,8 @@ fn native_file_copy_recursive_round_trip() {
|
||||
fs::create_dir_all(src.join("nested")).unwrap();
|
||||
fs::write(src.join("root.txt"), b"root file\n").unwrap();
|
||||
fs::write(src.join("nested/child.txt"), b"child file\n").unwrap();
|
||||
std::os::unix::fs::symlink("root.txt", src.join("root-link")).unwrap();
|
||||
std::os::unix::fs::symlink("nested/child.txt", src.join("child-link")).unwrap();
|
||||
|
||||
let client_bin = env!("CARGO_BIN_EXE_dosh-client");
|
||||
let upload = Command::new(client_bin)
|
||||
@@ -1107,6 +1133,14 @@ fn native_file_copy_recursive_round_trip() {
|
||||
fs::read_to_string(downloaded.join("nested/child.txt")).unwrap(),
|
||||
"child file\n"
|
||||
);
|
||||
assert_eq!(
|
||||
fs::read_link(downloaded.join("root-link")).unwrap(),
|
||||
PathBuf::from("root.txt")
|
||||
);
|
||||
assert_eq!(
|
||||
fs::read_link(downloaded.join("child-link")).unwrap(),
|
||||
PathBuf::from("nested/child.txt")
|
||||
);
|
||||
|
||||
let remove = Command::new(client_bin)
|
||||
.arg("--dosh-host")
|
||||
@@ -1241,6 +1275,80 @@ fn native_file_copy_resume_truncates_oversized_destinations() {
|
||||
let _ = server.wait();
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn native_file_copy_resume_prefix_mismatch_preserves_destinations() {
|
||||
let dir = tempfile::tempdir().unwrap();
|
||||
let port = free_udp_port();
|
||||
let config = write_server_config(&dir, port);
|
||||
write_native_client_auth(&dir, &config);
|
||||
let mut server = start_server(&dir, &config);
|
||||
let client_bin = env!("CARGO_BIN_EXE_dosh-client");
|
||||
|
||||
let local_upload = dir.path().join("upload-prefix.txt");
|
||||
let remote_upload = dir.path().join("remote-upload.txt");
|
||||
fs::write(&local_upload, b"local-prefix\n").unwrap();
|
||||
fs::write(&remote_upload, b"remote-prefix-with-tail\n").unwrap();
|
||||
fs::set_permissions(&local_upload, fs::Permissions::from_mode(0o755)).unwrap();
|
||||
fs::set_permissions(&remote_upload, fs::Permissions::from_mode(0o600)).unwrap();
|
||||
|
||||
let bad_upload_resume = Command::new(client_bin)
|
||||
.arg("--dosh-host")
|
||||
.arg("127.0.0.1")
|
||||
.arg("--dosh-port")
|
||||
.arg(port.to_string())
|
||||
.arg("cp")
|
||||
.arg("--resume")
|
||||
.arg(&local_upload)
|
||||
.arg("local:remote-upload.txt")
|
||||
.env("HOME", dir.path())
|
||||
.output()
|
||||
.unwrap();
|
||||
assert!(
|
||||
!bad_upload_resume.status.success(),
|
||||
"bad upload resume unexpectedly succeeded: stdout={} stderr={}",
|
||||
String::from_utf8_lossy(&bad_upload_resume.stdout),
|
||||
String::from_utf8_lossy(&bad_upload_resume.stderr)
|
||||
);
|
||||
assert_eq!(
|
||||
fs::read_to_string(&remote_upload).unwrap(),
|
||||
"remote-prefix-with-tail\n"
|
||||
);
|
||||
assert_eq!(
|
||||
fs::metadata(&remote_upload).unwrap().permissions().mode() & 0o777,
|
||||
0o600
|
||||
);
|
||||
|
||||
fs::write(dir.path().join("remote-download.txt"), b"remote-download\n").unwrap();
|
||||
let local_download = dir.path().join("download-prefix.txt");
|
||||
fs::write(&local_download, b"local-download-with-tail\n").unwrap();
|
||||
|
||||
let bad_download_resume = Command::new(client_bin)
|
||||
.arg("--dosh-host")
|
||||
.arg("127.0.0.1")
|
||||
.arg("--dosh-port")
|
||||
.arg(port.to_string())
|
||||
.arg("cp")
|
||||
.arg("--resume")
|
||||
.arg("local:remote-download.txt")
|
||||
.arg(&local_download)
|
||||
.env("HOME", dir.path())
|
||||
.output()
|
||||
.unwrap();
|
||||
assert!(
|
||||
!bad_download_resume.status.success(),
|
||||
"bad download resume unexpectedly succeeded: stdout={} stderr={}",
|
||||
String::from_utf8_lossy(&bad_download_resume.stdout),
|
||||
String::from_utf8_lossy(&bad_download_resume.stderr)
|
||||
);
|
||||
assert_eq!(
|
||||
fs::read_to_string(&local_download).unwrap(),
|
||||
"local-download-with-tail\n"
|
||||
);
|
||||
|
||||
let _ = server.kill();
|
||||
let _ = server.wait();
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn native_exec_command_smoke() {
|
||||
let dir = tempfile::tempdir().unwrap();
|
||||
@@ -1479,7 +1587,9 @@ fn ticket_attach_after_server_restart_smoke() {
|
||||
let dir = tempfile::tempdir().unwrap();
|
||||
let port = free_udp_port();
|
||||
let config = write_server_config(&dir, port);
|
||||
let mut server = start_server(&dir, &config);
|
||||
let server_trace = dir.path().join("server-trace.log");
|
||||
let client_trace = dir.path().join("client-trace.log");
|
||||
let mut server = start_server_with_trace(&dir, &config, Some(&server_trace));
|
||||
let first = attach_once(&dir, port, true);
|
||||
let _ = server.kill();
|
||||
let _ = server.wait();
|
||||
@@ -1489,8 +1599,8 @@ fn ticket_attach_after_server_restart_smoke() {
|
||||
String::from_utf8_lossy(&first.stderr)
|
||||
);
|
||||
|
||||
let mut server = start_server(&dir, &config);
|
||||
let second = attach_once(&dir, port, true);
|
||||
let mut server = start_server_with_trace(&dir, &config, Some(&server_trace));
|
||||
let second = attach_once_with_trace(&dir, port, true, Some(&client_trace));
|
||||
let _ = server.kill();
|
||||
let _ = server.wait();
|
||||
let stderr = String::from_utf8_lossy(&second.stderr);
|
||||
@@ -1499,6 +1609,24 @@ fn ticket_attach_after_server_restart_smoke() {
|
||||
stderr.contains("udp_ticket_attach_ready"),
|
||||
"stderr={stderr}"
|
||||
);
|
||||
let server_trace = fs::read_to_string(&server_trace).unwrap();
|
||||
let client_trace = fs::read_to_string(&client_trace).unwrap();
|
||||
assert!(
|
||||
server_trace.contains("event=server.ticket_attach_start"),
|
||||
"server trace={server_trace}"
|
||||
);
|
||||
assert!(
|
||||
server_trace.contains("event=server.ticket_attach_ok"),
|
||||
"server trace={server_trace}"
|
||||
);
|
||||
assert!(
|
||||
client_trace.contains("event=client.ticket_attach_start"),
|
||||
"client trace={client_trace}"
|
||||
);
|
||||
assert!(
|
||||
client_trace.contains("event=client.ticket_attach_ok"),
|
||||
"client trace={client_trace}"
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
|
||||
@@ -42,6 +42,15 @@ fn package_check_verifies_only_artifacts_it_builds() {
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn complete_release_verifier_requires_both_macos_architectures() {
|
||||
let verify = include_str!("../scripts/verify-release-artifacts.sh");
|
||||
assert!(verify.contains("dosh-linux-x86_64.tar.gz"));
|
||||
assert!(verify.contains("dosh-macos-aarch64.tar.gz"));
|
||||
assert!(verify.contains("dosh-macos-x86_64.tar.gz"));
|
||||
assert!(verify.contains("dosh-windows-x86_64.zip"));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn package_release_stamps_git_build_info() {
|
||||
let package = include_str!("../scripts/package-release.sh");
|
||||
|
||||
Reference in New Issue
Block a user